Fix basename() and dirname()

libc/calls/lseek-nt.c

@@ -17,15 +17,23 @@
 │ PERFORMANCE OF THIS SOFTWARE.                                                │
 ╚─────────────────────────────────────────────────────────────────────────────*/
 #include "libc/calls/internal.h"
+#include "libc/nt/enum/filetype.h"
 #include "libc/nt/files.h"
 #include "libc/sysv/errfuns.h"
 
 textwindows int64_t sys_lseek_nt(int fd, int64_t offset, int whence) {
   int64_t res;
-  if (!__isfdkind(fd, kFdFile)) return ebadf();
-  if (SetFilePointerEx(g_fds.p[fd].handle, offset, &res, whence)) {
-    return res;
+  if (__isfdkind(fd, kFdFile)) {
+    if (GetFileType(g_fds.p[fd].handle) != kNtFileTypePipe) {
+      if (SetFilePointerEx(g_fds.p[fd].handle, offset, &res, whence)) {
+        return res;
+      } else {
+        return __winerr();
+      }
+    } else {
+      return espipe();
+    }
   } else {
-    return __winerr();
+    return ebadf();
   }
 }

libc/calls/open-nt.c

@@ -53,8 +53,8 @@
 
 static textwindows int64_t sys_open_nt_impl(int dirfd, const char *path,
                                             uint32_t flags, int32_t mode) {
-  uint32_t br;
   int64_t handle;
+  uint32_t br, err;
   char16_t path16[PATH_MAX];
   uint32_t perm, share, disp, attr;
   if (__mkntpathat(dirfd, path, flags, path16) == -1) return -1;
@@ -96,6 +96,18 @@ static textwindows int64_t sys_open_nt_impl(int dirfd, const char *path,
   } else {
     attr = kNtFileAttributeNormal;
     if (flags & _O_DIRECTORY) attr |= kNtFileFlagBackupSemantics;
+    if (~mode & 0200) {
+      attr |= kNtFileAttributeReadonly;
+      if (!IsTiny() && disp == kNtCreateAlways) {
+        // iron out esoteric unix/win32 inconsistency (golang #38225)
+        if ((handle = CreateFile(path16, perm, share, &kNtIsInheritable,
+                                 kNtTruncateExisting, kNtFileAttributeNormal,
+                                 0)) != -1 ||
+            (errno != ENOENT && errno != ENOTDIR)) {
+          return handle;
+        }
+      }
+    }
   }
   flags |= kNtFileFlagOverlapped;
   if (~flags & _O_INDEXED) attr |= kNtFileAttributeNotContentIndexed;
@@ -105,14 +117,7 @@ static textwindows int64_t sys_open_nt_impl(int dirfd, const char *path,
   if (flags & _O_DIRECT) attr |= kNtFileFlagNoBuffering;
   if (flags & _O_NDELAY) attr |= kNtFileFlagWriteThrough;
 
-  if ((handle = CreateFile(path16, perm, share, &kNtIsInheritable, disp, attr,
-                           0)) != -1) {
-  } else if (GetLastError() == kNtErrorFileExists &&
-             ((flags & _O_CREAT) &&
-              (flags & _O_TRUNC))) { /* TODO(jart): What was this? */
-    handle = eisdir();
-  }
-  return handle;
+  return CreateFile(path16, perm, share, &kNtIsInheritable, disp, attr, 0);
 }
 
 static textwindows ssize_t sys_open_nt_console(int dirfd,

libc/calls/openanon.c

@@ -21,13 +21,13 @@
 #include "libc/calls/internal.h"
 #include "libc/dce.h"
 #include "libc/fmt/conv.h"
-#include "libc/fmt/isslash.internal.h"
 #include "libc/fmt/itoa.h"
 #include "libc/nt/createfile.h"
 #include "libc/nt/enum/accessmask.h"
 #include "libc/nt/enum/creationdisposition.h"
 #include "libc/nt/enum/fileflagandattributes.h"
 #include "libc/nt/enum/filesharemode.h"
+#include "libc/str/path.h"
 #include "libc/str/str.h"
 #include "libc/sysv/consts/at.h"
 #include "libc/sysv/consts/o.h"
@@ -44,7 +44,7 @@ static void openanon_genpath(const char *name, struct OpenAnon *state,
   if (!name) name = "openanon";
   for (i = 0; p < pe; ++i) {
     if (!(c = name[i])) break;
-    if (isslash(c)) c = '_';
+    if (_isdirsep(c)) c = '_';
     *p++ = c;
   }
   *p++ = '.';

libc/calls/program_executable_name.c

@@ -29,6 +29,7 @@
 #include "libc/mem/alloca.h"
 #include "libc/nt/runtime.h"
 #include "libc/runtime/runtime.h"
+#include "libc/str/path.h"
 #include "libc/str/str.h"
 #include "libc/str/tpenc.h"
 #include "libc/str/utf16.h"