Fix warnings

This change fixes Cosmopolitan so it has fewer opinions about compiler
warnings. The whole repository had to be cleaned up to be buildable in
-Werror -Wall mode. This lets us benefit from things like strict const
checking. Some actual bugs might have been caught too.
This commit is contained in:
Justine Tunney 2023-09-01 20:49:13 -07:00
parent e2b3c3618e
commit 0d748ad58e
No known key found for this signature in database
GPG key ID: BE714B4575D6E328
571 changed files with 1306 additions and 1888 deletions

View file

@ -6,14 +6,14 @@ COSMOPOLITAN_C_START_
int64_t CreateFile(
const char16_t *lpFileName, uint32_t dwDesiredAccess, uint32_t dwShareMode,
struct NtSecurityAttributes *opt_lpSecurityAttributes,
const struct NtSecurityAttributes *opt_lpSecurityAttributes,
int dwCreationDisposition,
uint32_t dwFlagsAndAttributes, /* libc/nt/enum/fileflagandattributes.h */
int64_t opt_hTemplateFile) paramsnonnull((1));
int64_t CreateFileA(
const char *lpFileName, uint32_t dwDesiredAccess, uint32_t dwShareMode,
struct NtSecurityAttributes *opt_lpSecurityAttributes,
const struct NtSecurityAttributes *opt_lpSecurityAttributes,
int dwCreationDisposition,
uint32_t dwFlagsAndAttributes, /* libc/nt/enum/fileflagandattributes.h */
int64_t opt_hTemplateFile) paramsnonnull((1));

View file

@ -66,8 +66,8 @@ void *VirtualAlloc(void *opt_lpAddress, uint64_t dwSize,
bool32 VirtualFree(void *lpAddress, uint64_t dwSize, uint32_t dwFreeType);
bool32 VirtualProtect(void *lpAddress, uint64_t dwSize, uint32_t flNewProtect,
uint32_t *lpflOldProtect) paramsnonnull();
bool32 VirtualLock(void *lpAddress, size_t dwSize);
bool32 VirtualUnlock(void *lpAddress, size_t dwSize);
bool32 VirtualLock(const void *lpAddress, size_t dwSize);
bool32 VirtualUnlock(const void *lpAddress, size_t dwSize);
uint64_t VirtualQuery(const void *lpAddress,
struct NtMemoryBasicInformation *lpBuffer,
uint64_t dwLength);

View file

@ -42,7 +42,7 @@ struct NtObjectAttributes;
NtStatus NtClose(int64_t handle);
NtStatus NtCreateFile(int64_t *out_FileHandle, uint32_t DesiredAccess,
struct NtObjectAttributes *ObjectAttributes,
const struct NtObjectAttributes *ObjectAttributes,
struct NtIoStatusBlock *out_IoStatusBlock,
int64_t *opt_AllocationSize, uint32_t FileAttributes,
uint32_t ShareAccess, uint32_t CreateDisposition,

View file

@ -7,7 +7,7 @@
struct NtObjectAttributes {
uint32_t Length;
int64_t RootDirectory;
struct NtUnicodeString *ObjectName;
const struct NtUnicodeString *ObjectName;
uint32_t Attributes; /* OBJ_INHERIT, etc. */
struct NtSecurityDescriptor *SecurityDescriptor;
void *SecurityQualityOfService;

View file

@ -50,7 +50,7 @@ typedef void (*NtWaitOrTimerCallback)(void *lpParameter,
void WakeByAddressAll(void *Address);
void WakeByAddressSingle(void *Address);
bool32 WaitOnAddress(volatile void *Address, void *CompareAddress,
bool32 WaitOnAddress(const volatile void *Address, void *CompareAddress,
size_t AddressSize, uint32_t opt_dwMilliseconds);
void Sleep(uint32_t dwMilliseconds);