Fix warnings

This change fixes Cosmopolitan so it has fewer opinions about compiler
warnings. The whole repository had to be cleaned up to be buildable in
-Werror -Wall mode. This lets us benefit from things like strict const
checking. Some actual bugs might have been caught too.

libc/stdio/puts.c

@@ -20,20 +20,6 @@
 #include "libc/stdio/stdio.h"
 #include "libc/str/str.h"
 
-static inline int puts_unlocked(const char *s, FILE *f) {
-  size_t n, r;
-  if ((n = strlen(s))) {
-    r = fwrite_unlocked(s, 1, n, f);
-    if (!r) return -1;
-    if (r < n) return r;
-  }
-  if (fputc_unlocked('\n', f) == -1) {
-    if (feof_unlocked(f)) return n;
-    return -1;
-  }
-  return n + 1;
-}
-
 /**
  * Writes string w/ trailing newline to stdout.
  *
@@ -41,11 +27,9 @@ static inline int puts_unlocked(const char *s, FILE *f) {
  *     `errno` set and the `ferror(stdout)` state is updated
  */
 int puts(const char *s) {
-  FILE *f;
   int bytes;
-  f = stdout;
-  flockfile(f);
-  bytes = puts_unlocked(s, f);
-  funlockfile(f);
+  flockfile(stdout);
+  bytes = puts_unlocked(s);
+  funlockfile(stdout);
   return bytes;
 }