Fix warnings

This change fixes Cosmopolitan so it has fewer opinions about compiler
warnings. The whole repository had to be cleaned up to be buildable in
-Werror -Wall mode. This lets us benefit from things like strict const
checking. Some actual bugs might have been caught too.
This commit is contained in:
Justine Tunney 2023-09-01 20:49:13 -07:00
parent e2b3c3618e
commit 0d748ad58e
No known key found for this signature in database
GPG key ID: BE714B4575D6E328
571 changed files with 1306 additions and 1888 deletions

View file

@ -78,7 +78,6 @@ int option_verbose = 1;
mbedtls_test_info_t mbedtls_test_info;
int mbedtls_test_platform_setup(void) {
char *p;
int ret = 0;
static char mybuf[2][BUFSIZ];
ShowCrashReports();
@ -132,8 +131,7 @@ int mbedtls_hardware_poll(void *wut, unsigned char *p, size_t n, size_t *olen) {
}
int mbedtls_test_write(const char *fmt, ...) {
int i, n;
char *p;
int n;
va_list va;
va_start(va, fmt);
if (option_verbose) {

View file

@ -59,14 +59,6 @@ TEST(secp384r1, testIsTheSame) {
TEST(secp384r1, needsDownwardCorrection) {
int i;
uint64_t P[6] = {
0x00000000ffffffff, //
0xffffffff00000000, //
0xfffffffffffffffe, //
0xffffffffffffffff, //
0xffffffffffffffff, //
0xffffffffffffffff, //
};
uint64_t X[12] = {
0xffffffffffffffff, //
0xffffffffffffffff, //

View file

@ -512,6 +512,8 @@ void test_aes_check_params( )
const int valid_mode = MBEDTLS_AES_ENCRYPT;
const int invalid_mode = 42;
(void)size;
TEST_INVALID_PARAM( mbedtls_aes_init( NULL ) );
#if defined(MBEDTLS_CIPHER_MODE_XTS)
TEST_INVALID_PARAM( mbedtls_aes_xts_init( NULL ) );

View file

@ -502,6 +502,8 @@ void test_aes_check_params( )
const int valid_mode = MBEDTLS_AES_ENCRYPT;
const int invalid_mode = 42;
(void)size;
TEST_INVALID_PARAM( mbedtls_aes_init( NULL ) );
#if defined(MBEDTLS_CIPHER_MODE_XTS)
TEST_INVALID_PARAM( mbedtls_aes_xts_init( NULL ) );

View file

@ -501,6 +501,8 @@ void test_aes_check_params( )
size_t size;
const int valid_mode = MBEDTLS_AES_ENCRYPT;
const int invalid_mode = 42;
(void)size;
TEST_INVALID_PARAM( mbedtls_aes_init( NULL ) );
#if defined(MBEDTLS_CIPHER_MODE_XTS)

View file

@ -502,6 +502,8 @@ void test_aes_check_params( )
const int valid_mode = MBEDTLS_AES_ENCRYPT;
const int invalid_mode = 42;
(void)size;
TEST_INVALID_PARAM( mbedtls_aes_init( NULL ) );
#if defined(MBEDTLS_CIPHER_MODE_XTS)
TEST_INVALID_PARAM( mbedtls_aes_xts_init( NULL ) );

View file

@ -502,6 +502,8 @@ void test_aes_check_params( )
const int valid_mode = MBEDTLS_AES_ENCRYPT;
const int invalid_mode = 42;
(void)size;
TEST_INVALID_PARAM( mbedtls_aes_init( NULL ) );
#if defined(MBEDTLS_CIPHER_MODE_XTS)
TEST_INVALID_PARAM( mbedtls_aes_xts_init( NULL ) );

View file

@ -502,6 +502,8 @@ void test_aes_check_params( )
const int valid_mode = MBEDTLS_AES_ENCRYPT;
const int invalid_mode = 42;
(void)size;
TEST_INVALID_PARAM( mbedtls_aes_init( NULL ) );
#if defined(MBEDTLS_CIPHER_MODE_XTS)
TEST_INVALID_PARAM( mbedtls_aes_xts_init( NULL ) );