Fix warnings

This change fixes Cosmopolitan so it has fewer opinions about compiler
warnings. The whole repository had to be cleaned up to be buildable in
-Werror -Wall mode. This lets us benefit from things like strict const
checking. Some actual bugs might have been caught too.
This commit is contained in:
Justine Tunney 2023-09-01 20:49:13 -07:00
parent e2b3c3618e
commit 0d748ad58e
No known key found for this signature in database
GPG key ID: BE714B4575D6E328
571 changed files with 1306 additions and 1888 deletions

View file

@ -2941,7 +2941,7 @@ local int ucs4_string_to_utf8(ucs4, utf8buf, buflen)
if (mbl < c)
c = mbl;
if (utf8buf && count < buflen)
strncpy(utf8buf + count, mb, c);
strlcpy(utf8buf + count, mb, c);
if (mbl == 1 && !mb[0])
return count; /* terminating nul */
count += mbl;
@ -3204,7 +3204,6 @@ char *wide_to_local_string(wide_string)
int i;
wchar_t wc;
int b;
int state_dependent;
int wsize = 0;
int max_bytes = MB_CUR_MAX;
char buf[9];
@ -3225,10 +3224,6 @@ char *wide_to_local_string(wide_string)
/* set initial state if state-dependent encoding */
wc = (wchar_t)'a';
b = wctomb(NULL, wc);
if (b == 0)
state_dependent = 0;
else
state_dependent = 1;
for (i = 0; i < wsize; i++) {
if (sizeof(wchar_t) < 4 && wide_string[i] > 0xFFFF) {
/* wchar_t probably 2 bytes */