From 15276ad00292476aa87819cdc9b178380f8318da Mon Sep 17 00:00:00 2001 From: tkchia Date: Fri, 14 Oct 2022 13:22:53 +0000 Subject: [PATCH] [metal] Minor fixes to libc/runtime/*.internal.h comments --- libc/runtime/mman.internal.h | 2 +- libc/runtime/pc.internal.h | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/libc/runtime/mman.internal.h b/libc/runtime/mman.internal.h index 2488a4ac2..64c0fcb95 100644 --- a/libc/runtime/mman.internal.h +++ b/libc/runtime/mman.internal.h @@ -40,7 +40,7 @@ struct mman { COSMOPOLITAN_C_END_ #endif /* !(__ASSEMBLER__ + __LINKER__ + 0) */ -/* Values for mman::pc_video_type. TODO: implement graphics modes. */ +/* Values for mman::pc_video_type. */ #define PC_VIDEO_TEXT 0 #define PC_VIDEO_BGR565 1 #define PC_VIDEO_BGR555 2 diff --git a/libc/runtime/pc.internal.h b/libc/runtime/pc.internal.h index 9ef963f11..24c552c3a 100644 --- a/libc/runtime/pc.internal.h +++ b/libc/runtime/pc.internal.h @@ -145,15 +145,15 @@ │ (If this maps 2MB/1GB page and CR4.PGE) Global┐││││││││ │ (If IsPage 2MB/1GB, see Intel V3A § 11.12) PAT │││││││││ │ │ │││││││││ - │ ┌────────────────────────────────────┤ │││││││││ - │ Must Be 0┐│ Next Page Table Address (!IsPage) │ │││││││││ - │ │├────────────────────────────────────┤ │││││││││ - │ ││ Physical Address 4KB │ │││││││││ - │┌───┐┌─────┐│├───────────────────────────┐ │ign│││││││││ - ││PKE││ ign │││ Physical Address 2MB │ │┌┴┐│││││││││ - ││ ││ ││├──────────────────┐ │ ││ ││││││││││ - ││ ││ │││ Phys. Addr. 1GB │ │ ││ ││││││││││ - ││ ││ │││ │ │ ││ ││││││││││ + │ ┌─────────────────────────────────────┤ │││││││││ + │ Must Be 0┐│ Next Page Table Address (!IsPage) │ │││││││││ + │ │├─────────────────────────────────────┤ │││││││││ + │ ││ Physical Address 4KB │ │││││││││ + │┌──┐┌─────┐│├────────────────────────────┐ │ign│││││││││ + ││PK││ ign │││ Physical Address 2MB │ │┌┴┐│││││││││ + ││ ││ ││├───────────────────┐ │ ││ ││││││││││ + ││ ││ │││ Phys. Addr. 1GB │ │ ││ ││││││││││ + ││ ││ │││ │ │ ││ ││││││││││ 6666555555555544444444443333333333222222222211111111110000000000 3210987654321098765432109876543210987654321098765432109876543210*/ #define PAGE_V /* */ 0b000000000001 @@ -163,7 +163,7 @@ #define PAGE_2MB /* */ 0b000110000000 #define PAGE_1GB /* */ 0b000110000000 #define PAGE_IGN1 /* */ 0b111000000000 -#define PAGE_RSRV /* blinkenlights reservation */ 0b001000000000 +#define PAGE_RSRV /* blinkenlights/libc reservation */ 0b001000000000 #define PAGE_GROD /* blinkenlights MAP_GROWSDOWN */ 0b010000000000 #define PAGE_TA 0x00007ffffffff000 #define PAGE_PA2 0x00007fffffe00000