Add C++ demangling to privileged runtime

Cosmo will now print C++ symbols correctly in --ftrace logs and
backtraces. Doing this required reducing the memory requirement
of the __demangle() function by 3x. This was accomplished using
16-bit indices and 16-bit malloc granularity. That puts a limit
on the longest symbol we can successfully decode, which I think
would be around 6553 characters long, given a 65536-byte buffer

libc/intrin/asan.c

@@ -1136,10 +1136,7 @@ int __asan_print_trace(void *p) {
     kprintf(" (shadow not mapped?!)");
   }
   for (i = 0; i < ARRAYLEN(e->bt.p) && e->bt.p[i]; ++i) {
-    kprintf("\n%*lx %s", 12, e->bt.p[i],
-            _weaken(GetSymbolByAddr)
-                ? _weaken(GetSymbolByAddr)(e->bt.p[i])
-                : "please __static_yoink(\"GetSymbolByAddr\")");
+    kprintf("\n%*lx %t", 12, e->bt.p[i], e->bt.p[i]);
   }
   return 0;
 }

libc/intrin/kprintf.greg.c

@@ -18,6 +18,7 @@
 ╚─────────────────────────────────────────────────────────────────────────────*/
 #include "libc/intrin/kprintf.h"
 #include "ape/sections.internal.h"
+#include "libc/cosmo.h"
 #include "libc/dce.h"
 #include "libc/errno.h"
 #include "libc/fmt/divmod10.internal.h"
@@ -457,6 +458,7 @@ privileged static size_t kformat(char *b, size_t n, const char *fmt,
   const char *abet;
   signed char type;
   const char *s, *f;
+  char cxxbuf[2048];
   struct CosmoTib *tib;
   unsigned long long x;
   unsigned i, j, m, rem, sign, hash, cols, prec;
@@ -804,10 +806,12 @@ privileged static size_t kformat(char *b, size_t n, const char *fmt,
           x = va_arg(va, intptr_t);
           if (_weaken(__symtab) && *_weaken(__symtab) &&
               (idx = _weaken(__get_symbol)(0, x)) != -1) {
-            if (p + 1 <= e)
-              *p++ = '&';
+            /* if (p + 1 <= e) */
+            /*   *p++ = '&'; */
             s = (*_weaken(__symtab))->name_base +
                 (*_weaken(__symtab))->names[idx];
+            if (__is_mangled(s) && __demangle(cxxbuf, s, sizeof(cxxbuf)) != -1)
+              s = cxxbuf;
             goto FormatString;
           }
           base = 4;

libc/intrin/quick_exit.c

@@ -1,41 +0,0 @@
-/*-*- mode:c;indent-tabs-mode:nil;c-basic-offset:2;tab-width:8;coding:utf-8 -*-│
-│ vi: set et ft=c ts=2 sts=2 sw=2 fenc=utf-8                               :vi │
-╞══════════════════════════════════════════════════════════════════════════════╡
-│ Copyright 2021 Justine Alexandra Roberts Tunney                              │
-│                                                                              │
-│ Permission to use, copy, modify, and/or distribute this software for         │
-│ any purpose with or without fee is hereby granted, provided that the         │
-│ above copyright notice and this permission notice appear in all copies.      │
-│                                                                              │
-│ THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL                │
-│ WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED                │
-│ WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE             │
-│ AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL         │
-│ DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR        │
-│ PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER               │
-│ TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR             │
-│ PERFORMANCE OF THIS SOFTWARE.                                                │
-╚─────────────────────────────────────────────────────────────────────────────*/
-#include "libc/intrin/strace.internal.h"
-#include "libc/intrin/weaken.h"
-#include "libc/runtime/internal.h"
-#include "libc/runtime/runtime.h"
-#include "libc/stdio/stdio.h"
-
-/**
- * Exits process faster.
- *
- * @param exitcode is masked with 255
- * @noreturn
- */
-wontreturn void quick_exit(int exitcode) {
-  const uintptr_t *p;
-  STRACE("quick_exit(%d)", exitcode);
-  if (_weaken(fflush)) {
-    _weaken(fflush)(0);
-  }
-  for (p = __fini_array_end; p > __fini_array_start;) {
-    ((void (*)(void))(*--p))();
-  }
-  _Exit(exitcode);
-}

libc/log/backtrace3.c

@@ -51,10 +51,9 @@ dontinstrument dontasan int PrintBacktraceUsingSymbols(
   size_t gi;
   intptr_t addr;
   const char *name;
+  char cxxbuf[3000];
   int i, symbol, addend;
-  static char cxxbuf[8192];
   struct Garbages *garbage;
-  static pthread_spinlock_t lock;
   const struct StackFrame *frame;
   (void)gi;
   if (!bp)
@@ -92,10 +91,8 @@ dontinstrument dontasan int PrintBacktraceUsingSymbols(
       addend = 0;
     }
     if ((name = __get_symbol_name(st, symbol)) && __is_mangled(name)) {
-      pthread_spin_lock(&lock);
       __demangle(cxxbuf, name, sizeof(cxxbuf));
       kprintf("%012lx %lx %s%+d\n", frame, addr, cxxbuf, addend);
-      pthread_spin_unlock(&lock);
       name = cxxbuf;
     } else {
       kprintf("%012lx %lx %s%+d\n", frame, addr, name, addend);

libc/mem/alg.h

@@ -8,10 +8,10 @@ void *bsearch_r(const void *, const void *, size_t, size_t,
                 int (*)(const void *, const void *, void *), void *)
     paramsnonnull((1, 2, 5)) nosideeffect;
 void djbsort(int32_t *, size_t) libcesque;
-void qsort3(void *, size_t, size_t, int (*)(const void *, const void *))
-    paramsnonnull();
-void qsort(void *, size_t, size_t, int (*)(const void *, const void *))
-    paramsnonnull();
+void qsort3(void *, size_t, size_t,
+            int (*)(const void *, const void *)) libcesque paramsnonnull();
+void qsort(void *, size_t, size_t,
+           int (*)(const void *, const void *)) libcesque paramsnonnull();
 void qsort_r(void *, size_t, size_t,
              int (*)(const void *, const void *, void *), void *)
     paramsnonnull((1, 4));

libc/runtime/hog.py

@@ -1,2 +0,0 @@
-for i, c in enumerate("Asia/Kolkata"):
-  print("buf[%d] = '%c';" % (i, c))

libc/runtime/quick_exit.c

@@ -21,6 +21,12 @@
 
 void __funcs_on_quick_exit(void);
 
+/**
+ * Exits process faster.
+ *
+ * @param exitcode is masked with 255
+ * @noreturn
+ */
 wontreturn void quick_exit(int code) {
   if (_weaken(__funcs_on_quick_exit))
     _weaken(__funcs_on_quick_exit)();

libc/str/BUILD.mk

@@ -100,6 +100,10 @@ $(LIBC_STR_A_OBJS): private					\
 			-Wframe-larger-than=4096		\
 			-Walloca-larger-than=4096
 
+o/$(MODE)/libc/str/demangle.o: private				\
+		OVERRIDE_CFLAGS +=				\
+			-ffreestanding
+
 LIBC_STR_LIBS = $(foreach x,$(LIBC_STR_ARTIFACTS),$($(x)))
 LIBC_STR_SRCS = $(foreach x,$(LIBC_STR_ARTIFACTS),$($(x)_SRCS))
 LIBC_STR_HDRS = $(foreach x,$(LIBC_STR_ARTIFACTS),$($(x)_HDRS))