Make more fixes and improvements

- Remove PAGESIZE constant
- Fix realloc() documentation
- Fix ttyname_r() error reporting
- Make forking more reliable on Windows
- Make execvp() a few microseconds faster
- Make system() a few microseconds faster
- Tighten up the socket-related magic numbers
- Loosen restrictions on mmap() offset alignment
- Improve GetProgramExecutableName() with getenv("_")
- Use mkstemp() as basis for mktemp(), tmpfile(), tmpfd()
- Fix flakes in pthread_cancel_test, unix_test, fork_test
- Fix recently introduced futex stack overflow regression
- Let sockets be passed as stdio to subprocesses on Windows
- Improve security of bind() on Windows w/ SO_EXCLUSIVEADDRUSE
This commit is contained in:
Justine Tunney 2023-07-29 18:44:15 -07:00
parent 140a8a52e5
commit 18bb5888e1
No known key found for this signature in database
GPG key ID: BE714B4575D6E328
311 changed files with 1239 additions and 2622 deletions

View file

@ -196,10 +196,13 @@ struct itimerval timer;
struct timespec signalled;
sigset_t mask;
char buf[4096];
sigset_t savemask;
char buf[PAGESIZE];
char tmpout[PATH_MAX];
char *g_tmpout;
const char *g_tmpout_original;
const char *const kSafeEnv[] = {
"ADDR2LINE", // needed by GetAddr2linePath
"HOME", // needed by ~/.runit.psk
@ -454,7 +457,13 @@ char *StripPrefix(char *s, char *p) {
}
}
void AddArg(char *s) {
void AddArg(char *actual) {
const char *s;
if (actual == g_tmpout) {
s = g_tmpout_original;
} else {
s = actual;
}
if (args.n) {
appendw(&command, ' ');
}
@ -487,7 +496,7 @@ void AddArg(char *s) {
appendw(&shortened, ' ');
appends(&shortened, s);
}
AddStr(&args, s);
AddStr(&args, actual);
}
static int GetBaseCpuFreqMhz(void) {
@ -810,6 +819,7 @@ char *MakeTmpOut(const char *path) {
int c;
char *p = tmpout;
char *e = tmpout + sizeof(tmpout) - 1;
g_tmpout_original = path;
p = stpcpy(p, kTmpPath);
while ((c = *path++)) {
if (c == '/') c = '_';
@ -820,6 +830,7 @@ char *MakeTmpOut(const char *path) {
*p++ = c;
}
*p = 0;
g_tmpout = tmpout;
return tmpout;
}

View file

@ -16,13 +16,13 @@
TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
PERFORMANCE OF THIS SOFTWARE.
*/
#include "tool/build/lib/demangle.h"
#include "libc/assert.h"
#include "libc/calls/calls.h"
#include "libc/calls/struct/iovec.h"
#include "libc/intrin/safemacros.internal.h"
#include "libc/str/str.h"
#include "libc/sysv/consts/o.h"
#include "tool/build/lib/demangle.h"
struct CxxFilt {
int pid;
@ -83,7 +83,7 @@ char *DemangleCxxFilt(char *p, size_t pn, const char *s, size_t sn) {
ssize_t rc;
size_t got;
struct iovec iov[2];
static char buf[PAGESIZE];
static char buf[4096];
if (!g_cxxfilt.pid) SpawnCxxFilt();
if (g_cxxfilt.pid == -1) return NULL;
buf[0] = '\n';

View file

@ -105,9 +105,9 @@
bool use_ftrace;
bool use_strace;
char *g_exepath;
unsigned char g_buf[4096];
volatile bool g_interrupted;
struct sockaddr_in g_servaddr;
unsigned char g_buf[PAGESIZE];
bool g_daemonize, g_sendready;
int g_timeout, g_bogusfd, g_servfd, g_clifd, g_exefd;