mirrors/cosmopolitan
1
0
Fork 0
mirror of https://github.com/jart/cosmopolitan.git synced 2025-06-26 22:38:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Improve crash backtrace reliability

Browse source 
We're now able to pretty print a C++ backtrace upon crashing in pretty
much any runtime execution scenario. The default pledge sandbox policy
on Linux is now to return EPERM. If you call pledge and have debugging
functions linked (e.g. GetSymbolTable) then the symbol table shall get
loaded before any security policy is put in place. This change updates
build/bootstrap/fixupobj too and fixes some other sneaky build errors.
This commit is contained in:
Justine Tunney 2024-05-07 17:36:17 -07:00
parent 7d31fc311a
commit 19c81863a3
No known key found for this signature in database
GPG key ID: BE714B4575D6E328
17 changed files with 103 additions and 64 deletions
Download patch file Download diff file Expand all files Collapse all files

27
libc/str/demangle.c
View file

@ -43,7 +43,7 @@ Copyright (c) 2007 Hyogeol Lee <hyogeollee@gmail.com>\n\
Copyright (c) 2015-2017 Kai Wang <kaiwang27@gmail.com>\n\
Copyright (c) 2024 Justine Tunney <jtunney@gmail.com>");
// https://github.com/freebsd/freebsd-src/blob/2176c9ab71c85efd90a6c7af4a9e04fe8e3d49ca/contrib/libcxxrt/libelftc_dem_gnu3.c
// clang -format off
// clang-format off
/**
* @file demangle.c
@ -321,9 +321,9 @@ static char *
vector_str_get_flat(struct cpp_demangle_data *ddata, const struct vector_str *v,
size_t *l)
{
ssize_t elem_pos, elem_size, rtn_size;
size_t i;
char *rtn;
char *rtn, *p;
ssize_t rtn_size;
if (!v || !v->size)
return 0;
@ -334,14 +334,9 @@ vector_str_get_flat(struct cpp_demangle_data *ddata, const struct vector_str *v,
if (!(rtn = (char *)alloc(ddata, 1, rtn_size + 1)))
return 0;
elem_pos = 0;
for (i = 0; i < v->size; ++i) {
elem_size = strlen(v->container[i]);
memcpy(rtn + elem_pos, v->container[i], elem_size);
elem_pos += elem_size;
}
rtn[rtn_size] = '\0';
p = rtn;
for (i = 0; i < v->size; ++i)
p = stpcpy(p, v->container[i]);
if (l)
*l = rtn_size;
@ -2878,7 +2873,7 @@ static int
cpp_demangle_read_tmpl_args(struct cpp_demangle_data *ddata)
{
struct vector_str *v;
size_t arg_len, idx, limit, size;
size_t arg_len, idx, limit;
char *arg;
if (!ddata || *ddata->cur == '\0')
@ -2907,12 +2902,7 @@ cpp_demangle_read_tmpl_args(struct cpp_demangle_data *ddata)
if (*ddata->cur == 'E') {
++ddata->cur;
size = v->size;
ASSERT(size > 0);
if (!strncmp(v->container[size - 1], ">", 1)) {
if (!DEM_PUSH_STR(ddata, ">"))
return 0;
} else if (!DEM_PUSH_STR(ddata, ">"))
if (!DEM_PUSH_STR(ddata, ">"))
return 0;
ddata->is_tmpl = true;
break;
@ -4070,6 +4060,7 @@ failure(char *buf, const char *org, size_t buflen)
* be a partially copied result. In both cases, -1 is returned. The size
* of the output is only returned if this routine is fully succesful. To
* successfully cover nearly all the test cases from libcxxabi use 65536
* and to be able to print 99% of the symbols LLVM's libcxx.a, use 5632.
*
* It's important to call ismangled() before this, since non-c++ symbols
* have a special meaning; for example, "g" will return "__float128". It