Make C memory safe like Rust

This change enables Address Sanitizer systemically w/ `make MODE=dbg`.
Our version of Rust's `unsafe` keyword is named `noasan` which is used
for two functions that do aligned memory chunking, like `strcpy.c` and
we need to fix the tiny DEFLATE code, but that's it everything else is
fabulous you can have all the fischer price security blankets you need

Best of all is we're now able to use the ASAN data in Blinkenlights to
colorize the memory dumps. See the screenshot below of a test program:

  https://justine.lol/blinkenlights/asan.png

Which is operating on float arrays stored on the stack, with red areas
indicating poisoned memory, and the green areas indicate valid memory.

third_party/chibicc/as.c

@@ -522,6 +522,7 @@ static int AppendSection(struct As *a, int name, int flags, int type) {
   int i;
   APPEND(a->sections);
   i = a->sections.n - 1;
+  CHECK_LT(i, SHN_LORESERVE);
   a->sections.p[i].name = name;
   a->sections.p[i].flags = flags;
   a->sections.p[i].type = type;
@@ -1805,6 +1806,15 @@ static void OnSize(struct As *a, struct Slice s) {
   a->symbols.p[i].size = GetInt(a);
 }
 
+static void OnComm(struct As *a, struct Slice s) {
+  int i;
+  i = GetSymbol(a, a->things.p[a->i++].i);
+  ConsumeComma(a);
+  a->symbols.p[i].size = GetInt(a);
+  a->symbols.p[i].type = STT_COMMON;
+  a->symbols.p[i].section = SHN_COMMON;
+}
+
 static void OpVisibility(struct As *a, int visibility) {
   int i;
   for (;;) {
@@ -3118,6 +3128,7 @@ static const struct Directive8 {
     {".balign", OnAlign},      //
     {".bss", OnBss},           //
     {".byte", OnByte},         //
+    {".comm", OnComm},         //
     {".data", OnData},         //
     {".double", OnDouble},     //
     {".err", OnErr},           //
@@ -3280,8 +3291,8 @@ static const struct Directive8 {
     {"fildll", OnFildll},      //
     {"fildq", OnFildq},        //
     {"filds", OnFilds},        //
-    {"fistpq", OnFistpq},      //
     {"fistpll", OnFistpq},     //
+    {"fistpq", OnFistpq},      //
     {"fisttpll", OnFisttpq},   //
     {"fisttpq", OnFisttpq},    //
     {"fisttps", OnFisttps},    //
@@ -3906,6 +3917,9 @@ static void Objectify(struct As *a, int path) {
     a->symbols.p[i].ref = elfwriter_appendsym(
         elf, p, ELF64_ST_INFO(a->symbols.p[i].stb, a->symbols.p[i].type),
         a->symbols.p[i].stv, a->symbols.p[i].offset, a->symbols.p[i].size);
+    if (a->symbols.p[i].section >= SHN_LORESERVE) {
+      elfwriter_setsection(elf, a->symbols.p[i].ref, a->symbols.p[i].section);
+    }
     free(p);
   }
   for (i = 0; i < a->sections.n; ++i) {

third_party/chibicc/test/test.mk

@@ -21,8 +21,13 @@ THIRD_PARTY_CHIBICC_TEST_HDRS = $(filter %.h,$(THIRD_PARTY_CHIBICC_TEST_FILES))
 THIRD_PARTY_CHIBICC_TEST_TESTS = $(THIRD_PARTY_CHIBICC_TEST_COMS:%=%.ok)
 
 THIRD_PARTY_CHIBICC_TEST_COMS =							\
-	$(THIRD_PARTY_CHIBICC_TEST_SRCS_TEST:%.c=o/$(MODE)/%.com)		\
+	$(THIRD_PARTY_CHIBICC_TEST_SRCS_TEST:%.c=o/$(MODE)/%.com)
+
+# TODO(jart): make chibicc compiled chibicc work with asan runtime
+ifneq ($(MODE),dbg)
+THIRD_PARTY_CHIBICC_TEST_COMS +=						\
 	$(THIRD_PARTY_CHIBICC_TEST_SRCS_TEST:%.c=o/$(MODE)/%2.com)
+endif
 
 THIRD_PARTY_CHIBICC_TEST_OBJS =							\
 	$(THIRD_PARTY_CHIBICC_TEST_SRCS:%.c=o/$(MODE)/%.chibicc.o)

third_party/dlmalloc/dlmalloc-usable.c

@@ -1,10 +0,0 @@
-#include "libc/mem/mem.h"
-#include "third_party/dlmalloc/dlmalloc.internal.h"
-
-size_t dlmalloc_usable_size(const void* mem) {
-  if (mem != 0) {
-    mchunkptr p = mem2chunk(mem);
-    if (is_inuse(p)) return chunksize(p) - overhead_for(p);
-  }
-  return 0;
-}

third_party/dlmalloc/dlmalloc.c

@@ -1,9 +1,11 @@
 #include "libc/bits/initializer.internal.h"
 #include "libc/bits/safemacros.h"
+#include "libc/bits/weaken.h"
 #include "libc/calls/internal.h"
 #include "libc/calls/struct/sysinfo.h"
 #include "libc/dce.h"
 #include "libc/fmt/conv.h"
+#include "libc/intrin/asan.internal.h"
 #include "libc/limits.h"
 #include "libc/macros.h"
 #include "libc/mem/mem.h"
@@ -34,20 +36,12 @@ hidden struct MallocParams g_mparams;
  * Note that contiguous allocations are what Doug Lea recommends.
  */
 static void *dlmalloc_requires_more_vespene_gas(size_t size) {
-  if (0) {
-    size_t need = mallinfo().arena + size;
-    if (need > 8 * 1024 * 1024) {
-      struct sysinfo info;
-      if (sysinfo(&info) != -1) {
-        if (info.freeram < (info.totalram >> 1) &&
-            need > info.totalram * info.mem_unit / 2) {
-          write(STDERR_FILENO, OOM_WARNING, strlen(OOM_WARNING));
-          return NULL;
-        }
-      }
-    }
+  char *p;
+  p = mapanon(size);
+  if (weaken(__asan_poison)) {
+    weaken(__asan_poison)((uintptr_t)p, size, kAsanHeapFree);
   }
-  return mapanon(size);
+  return p;
 }
 
 /* ─────────────────────────── mspace management ─────────────────────────── */
@@ -826,6 +820,14 @@ void dlfree(void *mem) {
 #endif /* FOOTERS */
 }
 
+size_t dlmalloc_usable_size(const void *mem) {
+  if (mem != 0) {
+    mchunkptr p = mem2chunk(mem);
+    if (is_inuse(p)) return chunksize(p) - overhead_for(p);
+  }
+  return 0;
+}
+
 textstartup void dlmalloc_init(void) {
 #ifdef NEED_GLOBAL_LOCK_INIT
   if (malloc_global_mutex_status <= 0) init_malloc_global_mutex();
@@ -868,3 +870,75 @@ textstartup void dlmalloc_init(void) {
   }
   RELEASE_MALLOC_GLOBAL_LOCK();
 }
+
+void *dlmemalign$impl(mstate m, size_t alignment, size_t bytes) {
+  void *mem = 0;
+  if (alignment < MIN_CHUNK_SIZE) { /* must be at least a minimum chunk size */
+    alignment = MIN_CHUNK_SIZE;     /* is 32 bytes on NexGen32e */
+  }
+  if ((alignment & (alignment - SIZE_T_ONE)) != 0) { /* Ensure a power of 2 */
+    alignment = roundup2pow(alignment);
+  }
+  if (bytes >= MAX_REQUEST - alignment) {
+    if (m != 0) { /* Test isn't needed but avoids compiler warning */
+      enomem();
+    }
+  } else {
+    size_t nb = request2size(bytes);
+    size_t req = nb + alignment + MIN_CHUNK_SIZE - CHUNK_OVERHEAD;
+    mem = dlmalloc(req);
+    if (mem != 0) {
+      mchunkptr p = mem2chunk(mem);
+      if (PREACTION(m)) return 0;
+      if ((((size_t)(mem)) & (alignment - 1)) != 0) { /* misaligned */
+        /*
+          Find an aligned spot inside chunk.  Since we need to give
+          back leading space in a chunk of at least MIN_CHUNK_SIZE, if
+          the first calculation places us at a spot with less than
+          MIN_CHUNK_SIZE leader, we can move to the next aligned spot.
+          We've allocated enough total room so that this is always
+          possible.
+        */
+        char *br = (char *)mem2chunk((size_t)(
+            ((size_t)((char *)mem + alignment - SIZE_T_ONE)) & -alignment));
+        char *pos = ((size_t)(br - (char *)(p)) >= MIN_CHUNK_SIZE)
+                        ? br
+                        : br + alignment;
+        mchunkptr newp = (mchunkptr)pos;
+        size_t leadsize = pos - (char *)(p);
+        size_t newsize = chunksize(p) - leadsize;
+        if (is_mmapped(p)) { /* For mmapped chunks, just adjust offset */
+          newp->prev_foot = p->prev_foot + leadsize;
+          newp->head = newsize;
+        } else { /* Otherwise, give back leader, use the rest */
+          set_inuse(m, newp, newsize);
+          set_inuse(m, p, leadsize);
+          dlmalloc_dispose_chunk(m, p, leadsize);
+        }
+        p = newp;
+      }
+      /* Give back spare room at the end */
+      if (!is_mmapped(p)) {
+        size_t size = chunksize(p);
+        if (size > nb + MIN_CHUNK_SIZE) {
+          size_t remainder_size = size - nb;
+          mchunkptr remainder = chunk_plus_offset(p, nb);
+          set_inuse(m, p, nb);
+          set_inuse(m, remainder, remainder_size);
+          dlmalloc_dispose_chunk(m, remainder, remainder_size);
+        }
+      }
+      mem = chunk2mem(p);
+      assert(chunksize(p) >= nb);
+      assert(((size_t)mem & (alignment - 1)) == 0);
+      check_inuse_chunk(m, p);
+      POSTACTION(m);
+    }
+  }
+  return ADDRESS_BIRTH_ACTION(mem);
+}
+
+void *dlmemalign(size_t alignment, size_t bytes) {
+  if (alignment <= MALLOC_ALIGNMENT) return dlmalloc(bytes);
+  return dlmemalign$impl(g_dlmalloc, alignment, bytes);
+}

third_party/dlmalloc/dlmemalign-impl.c

@@ -1,70 +0,0 @@
-#include "libc/bits/bits.h"
-#include "libc/mem/mem.h"
-#include "libc/sysv/errfuns.h"
-#include "third_party/dlmalloc/dlmalloc.internal.h"
-
-void* dlmemalign$impl(mstate m, size_t alignment, size_t bytes) {
-  void* mem = 0;
-  if (alignment < MIN_CHUNK_SIZE) { /* must be at least a minimum chunk size */
-    alignment = MIN_CHUNK_SIZE;     /* is 32 bytes on NexGen32e */
-  }
-  if ((alignment & (alignment - SIZE_T_ONE)) != 0) { /* Ensure a power of 2 */
-    alignment = roundup2pow(alignment);
-  }
-  if (bytes >= MAX_REQUEST - alignment) {
-    if (m != 0) { /* Test isn't needed but avoids compiler warning */
-      enomem();
-    }
-  } else {
-    size_t nb = request2size(bytes);
-    size_t req = nb + alignment + MIN_CHUNK_SIZE - CHUNK_OVERHEAD;
-    mem = dlmalloc(req);
-    if (mem != 0) {
-      mchunkptr p = mem2chunk(mem);
-      if (PREACTION(m)) return 0;
-      if ((((size_t)(mem)) & (alignment - 1)) != 0) { /* misaligned */
-        /*
-          Find an aligned spot inside chunk.  Since we need to give
-          back leading space in a chunk of at least MIN_CHUNK_SIZE, if
-          the first calculation places us at a spot with less than
-          MIN_CHUNK_SIZE leader, we can move to the next aligned spot.
-          We've allocated enough total room so that this is always
-          possible.
-        */
-        char* br = (char*)mem2chunk((size_t)(
-            ((size_t)((char*)mem + alignment - SIZE_T_ONE)) & -alignment));
-        char* pos =
-            ((size_t)(br - (char*)(p)) >= MIN_CHUNK_SIZE) ? br : br + alignment;
-        mchunkptr newp = (mchunkptr)pos;
-        size_t leadsize = pos - (char*)(p);
-        size_t newsize = chunksize(p) - leadsize;
-        if (is_mmapped(p)) { /* For mmapped chunks, just adjust offset */
-          newp->prev_foot = p->prev_foot + leadsize;
-          newp->head = newsize;
-        } else { /* Otherwise, give back leader, use the rest */
-          set_inuse(m, newp, newsize);
-          set_inuse(m, p, leadsize);
-          dlmalloc_dispose_chunk(m, p, leadsize);
-        }
-        p = newp;
-      }
-      /* Give back spare room at the end */
-      if (!is_mmapped(p)) {
-        size_t size = chunksize(p);
-        if (size > nb + MIN_CHUNK_SIZE) {
-          size_t remainder_size = size - nb;
-          mchunkptr remainder = chunk_plus_offset(p, nb);
-          set_inuse(m, p, nb);
-          set_inuse(m, remainder, remainder_size);
-          dlmalloc_dispose_chunk(m, remainder, remainder_size);
-        }
-      }
-      mem = chunk2mem(p);
-      assert(chunksize(p) >= nb);
-      assert(((size_t)mem & (alignment - 1)) == 0);
-      check_inuse_chunk(m, p);
-      POSTACTION(m);
-    }
-  }
-  return ADDRESS_BIRTH_ACTION(mem);
-}

third_party/dlmalloc/dlmemalign.c

@@ -1,7 +0,0 @@
-#include "libc/mem/mem.h"
-#include "third_party/dlmalloc/dlmalloc.internal.h"
-
-void *dlmemalign(size_t alignment, size_t bytes) {
-  if (alignment <= MALLOC_ALIGNMENT) return dlmalloc(bytes);
-  return dlmemalign$impl(g_dlmalloc, alignment, bytes);
-}

third_party/stb/stb.mk

@@ -62,12 +62,6 @@ $(THIRD_PARTY_STB_A_OBJS):				\
 			-ffunction-sections		\
 			-fdata-sections
 
-# o//third_party/stb/stb_image_write.o			\
-# o//third_party/stb/stb_image.o:				\
-# 		OVERRIDE_CFLAGS +=			\
-# 			-ftrapv				\
-# 			-fsanitize=address
-
 $(THIRD_PARTY_STB_A_OBJS):				\
 		OVERRIDE_CPPFLAGS +=			\
 			-DSTACK_FRAME_UNLIMITED

third_party/third_party.mk

@@ -1,10 +1,15 @@
 #-*-mode:makefile-gmake;indent-tabs-mode:t;tab-width:8;coding:utf-8-*-┐
 #───vi: set et ft=make ts=8 tw=8 fenc=utf-8 :vi───────────────────────┘
 
+# TODO(jart): make chibicc compiled chibicc work with asan runtime
+ifneq ($(MODE),dbg)
+THIRD_PARTY_CHIBICC_XXX = o/$(MODE)/third_party/chibicc
+endif
+
 .PHONY:	o/$(MODE)/third_party
 o/$(MODE)/third_party:				\
 	o/$(MODE)/third_party/blas		\
-	o/$(MODE)/third_party/chibicc		\
+	$(THIRD_PARTY_CHIBICC_XXX)		\
 	o/$(MODE)/third_party/compiler_rt	\
 	o/$(MODE)/third_party/dlmalloc		\
 	o/$(MODE)/third_party/gdtoa		\

third_party/zlib/zlib.mk

@@ -27,6 +27,7 @@ THIRD_PARTY_ZLIB_A_CHECKS =				\
 THIRD_PARTY_ZLIB_A_DIRECTDEPS =				\
 	LIBC_INTRIN					\
 	LIBC_NEXGEN32E					\
+	LIBC_STR					\
 	LIBC_STUBS
 
 THIRD_PARTY_ZLIB_A_DEPS :=				\