Polish recent changes and make improvements

- Simulate SIGPIPE on Windows NT
- Fix commandv() regression on Windows NT
- Fix sigprocmask() strace bug on OpenBSD
- Add many more system calls to --strace logging
- Make errno state more pristine in redbean strace

libc/runtime/memtrack.internal.h

@@ -46,6 +46,7 @@ extern hidden struct MemoryIntervals _mmi;
 
 const char *DescribeFrame(int);
 void PrintSystemMappings(int) hidden;
+char *DescribeProt(int, char[hasatleast 4]);
 char *DescribeMapping(int, int, char[hasatleast 8]) hidden;
 bool AreMemoryIntervalsOk(const struct MemoryIntervals *) nosideeffect hidden;
 void PrintMemoryIntervals(int, const struct MemoryIntervals *) hidden;

libc/runtime/mmap.c

@@ -109,7 +109,7 @@ static noasan void *MapMemory(void *addr, size_t size, int prot, int flags,
   dm = sys_mmap(addr, size, prot, f, fd, off);
   if (UNLIKELY(dm.addr == MAP_FAILED)) {
     if (IsWindows() && (flags & MAP_FIXED)) {
-      STRACE("mmap(%.12p, %'ld) → %s (%s)", addr, size, strerror(errno),
+      STRACE("mmap(%.12p, %'ld) → %m (%s)", addr, size,
              "can't recover from MAP_FIXED errors on Windows");
       assert(!"MapMemory() failed");
       Die();
@@ -123,14 +123,14 @@ static noasan void *MapMemory(void *addr, size_t size, int prot, int flags,
   }
   if (!IsWindows() && (flags & MAP_FIXED)) {
     if (UntrackMemoryIntervals(addr, size)) {
-      STRACE("FIXED UNTRACK FAILED %s", strerror(errno));
+      STRACE("FIXED UNTRACK FAILED %m");
       assert(!"MapMemory() failed");
       Die();
     }
   }
   if (TrackMemoryInterval(&_mmi, x, x + (n - 1), dm.maphandle, prot, flags)) {
     if (sys_munmap(addr, n) == -1) {
-      STRACE("TRACK MUNMAP FAILED %s", strerror(errno));
+      STRACE("TRACK MUNMAP FAILED %m");
       assert(!"MapMemory() failed");
       Die();
     }

libc/runtime/opensymboltable.c

@@ -187,7 +187,7 @@ RaiseEnobufs:
 RaiseEnoexec:
   errno = ENOEXEC;
 SystemError:
-  STRACE("OpenSymbolTable() %m");
+  STRACE("OpenSymbolTable()% m");
   if (map != MAP_FAILED) {
     munmap(map, st.st_size);
   }

libc/runtime/winmain.greg.c

@@ -22,6 +22,7 @@
 #include "libc/calls/internal.h"
 #include "libc/calls/strace.internal.h"
 #include "libc/dce.h"
+#include "libc/errno.h"
 #include "libc/fmt/fmt.h"
 #include "libc/intrin/kprintf.h"
 #include "libc/log/libfatal.internal.h"
@@ -100,7 +101,9 @@ forceinline void MakeLongDoubleLongAgain(void) {
   asm volatile("fldcw\t%0" : /* no outputs */ : "m"(x87cw));
 }
 
-static noasan textwindows wontreturn noinstrument void WinMainNew(void) {
+static noasan textwindows wontreturn noinstrument void WinMainNew(
+    const char16_t *cmdline) {
+  bool32 rc;
   int64_t h;
   int version;
   int i, count;
@@ -112,13 +115,17 @@ static noasan textwindows wontreturn noinstrument void WinMainNew(void) {
   version = NtGetPeb()->OSMajorVersion;
   __oldstack = (intptr_t)__builtin_frame_address(0);
   if ((intptr_t)v_ntsubsystem == kNtImageSubsystemWindowsCui && version >= 10) {
-    SetConsoleCP(kNtCpUtf8);
-    SetConsoleOutputCP(kNtCpUtf8);
+    rc = SetConsoleCP(kNtCpUtf8);
+    STRACE("SetConsoleCP(kNtCpUtf8) → %hhhd", rc);
+    rc = SetConsoleOutputCP(kNtCpUtf8);
+    STRACE("SetConsoleOutputCP(kNtCpUtf8) → %hhhd", rc);
     SetEnvironmentVariable(u"TERM", u"xterm-truecolor");
     for (i = 0; i < 2; ++i) {
       hand = GetStdHandle(kConsoleHandles[i]);
-      GetConsoleMode(hand, __ntconsolemode + i);
-      SetConsoleMode(hand, kConsoleModes[i]);
+      rc = GetConsoleMode(hand, __ntconsolemode + i);
+      STRACE("GetConsoleMode(%p, [%#x]) → %hhhd", hand, __ntconsolemode[i], rc);
+      rc = SetConsoleMode(hand, kConsoleModes[i]);
+      STRACE("SetConsoleMode(%p, %#x) → %hhhd", hand, kConsoleModes[i], rc);
     }
   }
   _mmi.p = _mmi.s;
@@ -128,7 +135,8 @@ static noasan textwindows wontreturn noinstrument void WinMainNew(void) {
   stacksize = GetStackSize();
   allocsize = argsize + stacksize;
   allocaddr = stackaddr - argsize;
-  STRACE("WinMainNew() mapping arg block / stack");
+  STRACE("WinMainNew() mapping %'zu byte arg block + stack at %p", allocsize,
+         allocaddr);
   MapViewOfFileExNuma(
       (_mmi.p[0].h = CreateFileMappingNuma(
            -1, &kNtIsInheritable, kNtPageExecuteReadwrite, allocsize >> 32,
@@ -142,8 +150,8 @@ static noasan textwindows wontreturn noinstrument void WinMainNew(void) {
   _mmi.i = 1;
   wa = (struct WinArgs *)allocaddr;
   STRACE("WinMainNew() loading arg block");
-  count = GetDosArgv(GetCommandLine(), wa->argblock, ARRAYLEN(wa->argblock),
-                     wa->argv, ARRAYLEN(wa->argv));
+  count = GetDosArgv(cmdline, wa->argblock, ARRAYLEN(wa->argblock), wa->argv,
+                     ARRAYLEN(wa->argv));
   for (i = 0; wa->argv[0][i]; ++i) {
     if (wa->argv[0][i] == '\\') {
       wa->argv[0][i] = '/';
@@ -197,15 +205,21 @@ noasan textwindows noinstrument int64_t WinMain(int64_t hInstance,
                                                 int64_t hPrevInstance,
                                                 const char *lpCmdLine,
                                                 int nCmdShow) {
+  const char16_t *cmdline;
   extern char os asm("__hostos");
   extern uint64_t ts asm("kStartTsc");
   os = WINDOWS; /* madness https://news.ycombinator.com/item?id=21019722 */
   ts = rdtsc();
   __nomultics = true;
   __pid = GetCurrentProcessId();
+  cmdline = GetCommandLine();
+#ifdef SYSDEBUG
+  /* sloppy flag-only check for early initialization */
+  if (__strstr16(cmdline, u"--strace")) ++__strace;
+#endif
   STRACE("WinMain()");
   MakeLongDoubleLongAgain();
   if (weaken(WinSockInit)) weaken(WinSockInit)();
   if (weaken(WinMainForked)) weaken(WinMainForked)();
-  WinMainNew();
+  WinMainNew(cmdline);
 }