mirrors/cosmopolitan
1
0
Fork 0
mirror of https://github.com/jart/cosmopolitan.git synced 2025-03-03 15:38:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Make printf %La test-case work properly on AArch64 (#1298)

Browse source 
As the size of long double changes between x86 and AArch64, this results
in one of the printf a conversion specifier test-cases getting different
output between the two. Note that both outputs (and a few more) are 100%
standards-conforming, but the testcase currently only expects a specific
one - the one that had been seen on x86 when initially writing the test.

This patch fixes the testcase so it accepts either of those two outputs.
This commit is contained in:
Gabriel Ravier 2024-09-22 10:21:03 +02:00 • committed by GitHub
parent dd8c4dbd7d
commit 476926790a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
test/libc/stdio/snprintf_test.c
View file

@ -237,6 +237,22 @@ void check_a_conversion_specifier_long_double(const char *fmt,
ASSERT_STREQ(expected_str, buf);
}
void check_a_conversion_specifier_long_double_arr_allowed(
const char *fmt, const char *allowed_strs[], long double value) {
char buf[30] = {0};
int res = snprintf(buf, sizeof(buf), fmt, value);
for (size_t i = 0; allowed_strs[i] != NULL; ++i)
if (strlen(allowed_strs[i]) == res && strcmp(allowed_strs[i], buf) == 0)
return;
printf("Failed to find matching str for %`'s, allowed strs:\n", buf);
for (size_t i = 0; allowed_strs[i] != NULL; ++i)
printf("- %`'s\n", allowed_strs[i]);
fflush(stdout);
ASSERT_EQ(false, true);
}
void check_a_conversion_specifier_double_prec_1(const char *expected_str,
double value) {
check_a_conversion_specifier_double("%.1a", expected_str, value);
@ -272,8 +288,11 @@ TEST(snprintf, testAConversionSpecifier) {
check_a_conversion_specifier_double("%.2a", "0x1.00p-1026", 0xf.fffp-1030);
// TODO(GabrielRavier): fix me on aarch64
/* check_a_conversion_specifier_long_double("%.1La", "0x1.0p+1", 1.999L); */
check_a_conversion_specifier_double("%.1a", "0x2.0p+0", 1.999);
const char *acceptable_results1[] = {"0x1.0p+1", "0x2.0p+0", NULL};
check_a_conversion_specifier_long_double_arr_allowed(
"%.1La", acceptable_results1, 1.999L);
}
TEST(snprintf, apostropheFlag) {