mirrors/cosmopolitan
1
0
Fork 0
mirror of https://github.com/jart/cosmopolitan.git synced 2025-07-26 20:40:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix bugs in termios library and cleanup code

Browse source 
This change fixes an issue with the tcflow() magic numbers that was
causing bash to freeze up on Linux. While auditing termios polyfills,
several other issues were identified with XNU/BSD compatibility.

Out of an abundance of caution this change undefines as much surface
area from libc/calls/struct/termios.h as possible, so that autoconf
scripts are less likely to detect non-POSIX teletypewriter APIs that
haven't been polyfilled by Cosmopolitan.

This is a *breaking change* for your static archives in /opt/cosmos if
you use the cosmocc toolchain. That's because this change disables the
ioctl() undiamonding trick for code outside the monorepo, specifically
because it'll lead to brittle ABI breakages like this. If you're using
the cosmocc toolchain, you'll need to rebuild libraries like ncurses,
readline, etc. Yes diamonds cause bloat. To work around that, consider
using tcgetwinsize() instead of ioctl(TIOCGWINSZ) since it'll help you
avoid pulling every single ioctl-related polyfill into the linkage.

The cosmocc script was specifying -DNDEBUG for some reason. It's fixed.
This commit is contained in:
Justine Tunney 2023-06-14 17:02:57 -07:00
parent 06b749ae03
commit 4778cd4d27
No known key found for this signature in database
GPG key ID: BE714B4575D6E328
187 changed files with 1025 additions and 1848 deletions
Download patch file Download diff file Expand all files Collapse all files

19
libc/calls/tcdrain.c
View file

@ -27,7 +27,10 @@
#include "libc/sysv/consts/termios.h"
#include "libc/sysv/errfuns.h"
static textwindows int sys_tcdrain_nt(int fd) {
#define TCSBRK 0x5409 // linux
#define TIOCDRAIN 0x2000745e // xnu, freebsd, openbsd, netbsd
static dontinline textwindows int sys_tcdrain_nt(int fd) {
if (!__isfdopen(fd)) return ebadf();
if (_check_interrupts(false, g_fds.p)) return -1;
if (!FlushFileBuffers(g_fds.p[fd].handle)) return __winerr();
@ -40,7 +43,7 @@ static textwindows int sys_tcdrain_nt(int fd) {
* @param fd is file descriptor of tty
* @raise EBADF if `fd` isn't an open file descriptor
* @raise ENOTTY if `fd` is open but not a teletypewriter
* @raise EIO if process group of writer is orphoned, calling thread is
* @raise EIO if process group of writer is orphaned, calling thread is
* not blocking `SIGTTOU`, and process isn't ignoring `SIGTTOU`
* @raise ECANCELED if thread was cancelled in masked mode
* @raise EINTR if signal was delivered
@ -51,12 +54,14 @@ static textwindows int sys_tcdrain_nt(int fd) {
int tcdrain(int fd) {
int rc;
BEGIN_CANCELLATION_POINT;
if (IsMetal()) {
rc = enosys();
} else if (!IsWindows()) {
rc = sys_ioctl_cp(fd, TCSBRK, (void *)(intptr_t)1);
} else {
if (IsLinux()) {
rc = sys_ioctl_cp(fd, TCSBRK, (uintptr_t)1);
} else if (IsBsd()) {
rc = sys_ioctl_cp(fd, TIOCDRAIN, 0);
} else if (IsWindows()) {
rc = sys_tcdrain_nt(fd);
} else {
rc = enosys();
}
END_CANCELLATION_POINT;
STRACE("tcdrain(%d) → %d% m", fd, rc);