mirrors/cosmopolitan
1
0
Fork 0
mirror of https://github.com/jart/cosmopolitan.git synced 2025-05-29 00:32:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Disable argv[0] tests on non-XnuSilicon (#1015)

Browse source 
Adds a TODO explaining the correct condition.
This commit is contained in:
Jōshin 2023-12-24 19:43:32 -05:00 • committed by GitHub
parent 25266b037b
commit 4c6f928fbf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
test/libc/calls/getprogramexecutablename_test.c
View file

@ -36,10 +36,15 @@ void SetUpOnce(void) {
__attribute__((__constructor__)) static void Child(int argc, char *argv[]) { __attribute__((__constructor__)) static void Child(int argc, char *argv[]) {
static bool skiparg0tests; static bool skiparg0tests;
if (!__program_executable_name && !IsFreebsd() && !IsNetbsd()) { if (!IsXnuSilicon()) {
/* TODO(mrdomino): these tests only pass on XnuSilicon right now because
__sys_execve fails there, so the ape loader is used.
the correct check here is "we have been invoked either
as an assimilated binary or via the ape loader, and not
via a raw __sys_execve." */
skiparg0tests = true; skiparg0tests = true;
if (argc < 2) { if (argc < 2) {
fprintf(stderr, "warning: old/no loader; skipping argv[0] tests\n"); fprintf(stderr, "warning: skipping argv[0] tests\n");
} }
} }
if (argc >= 2 && !strcmp(argv[1], "Child")) { if (argc >= 2 && !strcmp(argv[1], "Child")) {