mirrors/cosmopolitan
1
0
Fork 0
mirror of https://github.com/jart/cosmopolitan.git synced 2025-06-28 15:28:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Eliminate some flakes

Browse source 
- Get ASAN working on Windows.

- Deleting directories and then recreating them with the same name in a
  short period of time appears to be a no-no on Windows.

- There's no reason to call FlushFileBuffers on close() for pipes, and
  it's harmful since it might block indefinitely for no good reason.
This commit is contained in:
Justine Tunney 2021-02-03 06:22:51 -08:00
parent 27c899af56
commit 4e56d89dcd
60 changed files with 588 additions and 751 deletions
Download patch file Download diff file Expand all files Collapse all files

11
test/libc/calls/commandv_test.c
View file

@ -34,12 +34,13 @@
#include "libc/x/x.h"
uint64_t i;
char pathbuf[PATH_MAX], testdir[PATH_MAX], *oldpath;
char *oldpath;
char tmp[PATH_MAX];
char pathbuf[PATH_MAX];
char testlib_enable_tmp_setup_teardown;
void SetUp(void) {
sprintf(testdir, "o/tmp/%s.%d", program_invocation_short_name, getpid());
makedirs(testdir, 0755);
CHECK_NE(-1, chdir(testdir));
static int x;
mkdir("bin", 0755);
mkdir("home", 0755);
oldpath = strdup(nulltoempty(getenv("PATH")));
@ -48,8 +49,6 @@ void SetUp(void) {
void TearDown(void) {
CHECK_NE(-1, setenv("PATH", oldpath, true));
CHECK_NE(-1, chdir("../../.."));
CHECK_NE(-1, rmrf(testdir));
}
TEST(commandv, testPathSearch) {

15
test/libc/calls/fcntl_test.c
View file

@ -26,20 +26,7 @@
#include "libc/testlib/testlib.h"
#include "libc/x/x.h"
char basedir[PATH_MAX];
char testdir[PATH_MAX];
void SetUp(void) {
getcwd(basedir, ARRAYLEN(basedir));
sprintf(testdir, "o/tmp/%s.%d", program_invocation_short_name, getpid());
makedirs(testdir, 0755);
CHECK_NE(-1, chdir(testdir));
}
void TearDown(void) {
CHECK_NE(-1, chdir(basedir));
CHECK_NE(-1, rmrf(testdir));
}
char testlib_enable_tmp_setup_teardown;
TEST(fcntl_getfl, testRemembersAccessMode) {
int fd;

15
test/libc/calls/getcwd_test.c
View file

@ -26,20 +26,7 @@
#include "libc/testlib/testlib.h"
#include "libc/x/x.h"
char basedir[PATH_MAX];
char testdir[PATH_MAX];
void SetUp(void) {
getcwd(basedir, ARRAYLEN(basedir));
sprintf(testdir, "o/tmp/%s.%d", program_invocation_short_name, getpid());
makedirs(testdir, 0755);
CHECK_NE(-1, chdir(testdir));
}
void TearDown(void) {
CHECK_NE(-1, chdir(basedir));
CHECK_NE(-1, rmrf(testdir));
}
char testlib_enable_tmp_setup_teardown;
TEST(getcwd, test) {
char buf[PATH_MAX];

13
test/libc/calls/lseek_test.c
View file

@ -25,18 +25,7 @@
#include "libc/testlib/testlib.h"
#include "libc/x/x.h"
char testdir[PATH_MAX];
void SetUp(void) {
sprintf(testdir, "o/tmp/%s.%d", program_invocation_short_name, getpid());
makedirs(testdir, 0755);
CHECK_NE(-1, chdir(testdir));
}
void TearDown(void) {
CHECK_NE(-1, chdir("../../.."));
CHECK_NE(-1, rmrf(testdir));
}
char testlib_enable_tmp_setup_teardown;
TEST(lseek, wat) {
int fd, pid;

13
test/libc/calls/mkdir_test.c
View file

@ -25,18 +25,7 @@
#include "libc/testlib/testlib.h"
#include "libc/x/x.h"
char testdir[PATH_MAX];
void SetUp(void) {
sprintf(testdir, "o/tmp/%s.%d", program_invocation_short_name, getpid());
makedirs(testdir, 0755);
CHECK_NE(-1, chdir(testdir));
}
void TearDown(void) {
CHECK_NE(-1, chdir("../../.."));
CHECK_NE(-1, rmrf(testdir));
}
char testlib_enable_tmp_setup_teardown;
TEST(mkdir, testNothingExists_ENOENT) {
EXPECT_EQ(-1, mkdir("yo/yo/yo", 0755));

8
test/libc/runtime/mmap_test.c
View file

@ -34,6 +34,8 @@
#include "libc/testlib/testlib.h"
#include "libc/x/x.h"
char testlib_enable_tmp_setup_teardown;
TEST(mmap, testMapFile) {
int fd;
char *p;
@ -107,10 +109,6 @@ TEST(mmap, customStackMemory_isAuthorized) {
TEST(mmap, fileOffset) {
int fd;
char *map;
char testdir[PATH_MAX];
sprintf(testdir, "o/tmp/%s.%d", program_invocation_short_name, getpid());
ASSERT_NE(-1, makedirs(testdir, 0755));
ASSERT_NE(-1, chdir(testdir));
ASSERT_NE(-1, (fd = open("foo", O_CREAT | O_RDWR, 0644)));
EXPECT_NE(-1, ftruncate(fd, FRAMESIZE * 2));
EXPECT_NE(-1, pwrite(fd, "hello", 5, FRAMESIZE * 0));
@ -120,8 +118,6 @@ TEST(mmap, fileOffset) {
EXPECT_EQ(0, memcmp(map, "there", 5), "%#.*s", 5, map);
EXPECT_NE(-1, munmap(map, FRAMESIZE));
EXPECT_NE(-1, close(fd));
ASSERT_NE(-1, chdir("../../.."));
ASSERT_NE(-1, rmrf(testdir));
}
TEST(isheap, nullPtr) {