mirrors/cosmopolitan
1
0
Fork 0
mirror of https://github.com/jart/cosmopolitan.git synced 2025-05-22 21:32:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Make forking off threads reliable on Windows

Browse source 
This change makes posix_spawn_test no longer flaky on Windows, by (1)
fixing a race condition in wait(), and (2) removing a misguided vfork
implementation which was letting Windows bypass pthread_atfork().
This commit is contained in:
Justine Tunney 2023-07-30 08:55:01 -07:00
parent 2ebc5781a1
commit 58352df0a4
No known key found for this signature in database
GPG key ID: BE714B4575D6E328
30 changed files with 230 additions and 187 deletions
Download patch file Download diff file Expand all files Collapse all files

56
test/libc/stdio/fds_torture_test.c Normal file
View file

@ -0,0 +1,56 @@
/*-*- mode:c;indent-tabs-mode:nil;c-basic-offset:2;tab-width:8;coding:utf-8 -*-│
│vi: set net ft=c ts=2 sts=2 sw=2 fenc=utf-8 :vi│
╞══════════════════════════════════════════════════════════════════════════════╡
│ Copyright 2023 Justine Alexandra Roberts Tunney │
│ │
│ Permission to use, copy, modify, and/or distribute this software for │
│ any purpose with or without fee is hereby granted, provided that the │
│ above copyright notice and this permission notice appear in all copies. │
│ │
│ THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL │
│ WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED │
│ WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE │
│ AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL │
│ DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR │
│ PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER │
│ TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR │
│ PERFORMANCE OF THIS SOFTWARE. │
╚─────────────────────────────────────────────────────────────────────────────*/
#include "libc/calls/calls.h"
#include "libc/runtime/runtime.h"
#include "libc/runtime/syslib.internal.h"
#include "libc/stdio/stdio.h"
#include "libc/sysv/consts/o.h"
#include "libc/testlib/testlib.h"
#include "libc/thread/thread.h"
#define THREADS 5
#define FDS 10
void *Torturer(void *arg) {
int i;
int fd[FDS];
for (i = 0; i < FDS; ++i) {
ASSERT_NE(-1, (fd[i] = open("/dev/null", O_WRONLY)));
}
for (i = 0; i < FDS; ++i) {
ASSERT_EQ(2, write(fd[i], "hi", 2));
if (!fork()) _Exit(0);
wait(0);
}
for (i = 0; i < FDS; ++i) {
ASSERT_NE(-1, close(fd[i]));
}
return 0;
}
TEST(fds_torture, test) {
int i;
pthread_t t[THREADS];
for (i = 0; i < THREADS; ++i) {
ASSERT_EQ(0, pthread_create(t + i, 0, Torturer, 0));
}
for (i = 0; i < THREADS; ++i) {
ASSERT_EQ(0, pthread_join(t[i], 0));
}
}

3
test/libc/stdio/posix_spawn_test.c
View file

@ -28,14 +28,17 @@
#include "libc/mem/gc.h"
#include "libc/mem/mem.h"
#include "libc/runtime/internal.h"
#include "libc/runtime/memtrack.internal.h"
#include "libc/runtime/runtime.h"
#include "libc/stdio/stdio.h"
#include "libc/str/str.h"
#include "libc/sysv/consts/auxv.h"
#include "libc/sysv/consts/o.h"
#include "libc/sysv/consts/sig.h"
#include "libc/testlib/ezbench.h"
#include "libc/testlib/testlib.h"
#include "libc/thread/thread.h"
#include "third_party/nsync/mu.h"
#ifdef __x86_64__
char testlib_enable_tmp_setup_teardown;

1
test/libc/stdio/test.mk
View file

@ -43,6 +43,7 @@ TEST_LIBC_STDIO_DIRECTDEPS = \
THIRD_PARTY_MBEDTLS \
THIRD_PARTY_MUSL \
THIRD_PARTY_TR \
THIRD_PARTY_NSYNC \
THIRD_PARTY_ZLIB \
THIRD_PARTY_ZLIB_GZ