mirror of
https://github.com/jart/cosmopolitan.git
synced 2025-08-01 23:40:28 +00:00
Make threads faster and more reliable
This change doubles the performance of thread spawning. That's thanks to our new stack manager, which allows us to avoid zeroing stacks. It gives us 15µs spawns rather than 30µs spawns on Linux. Also, pthread_exit() is faster now, since it doesn't need to acquire the pthread GIL. On NetBSD, that helps us avoid allocating too many semaphores. Even if that happens we're now able to survive semaphores running out and even memory running out, when allocating *NSYNC waiter objects. I found a lot more rare bugs in the POSIX threads runtime that could cause things to crash, if you've got dozens of threads all spawning and joining dozens of threads. I want cosmo to be world class production worthy for 2025 so happy holidays all
This commit is contained in:
parent
906bd06a5a
commit
624573207e
51 changed files with 1006 additions and 321 deletions
26
third_party/nsync/common.c
vendored
26
third_party/nsync/common.c
vendored
|
@ -40,6 +40,7 @@
|
|||
#include "third_party/nsync/mu_semaphore.h"
|
||||
#include "third_party/nsync/mu_semaphore.internal.h"
|
||||
#include "libc/intrin/kprintf.h"
|
||||
#include "libc/intrin/strace.h"
|
||||
#include "third_party/nsync/wait_s.internal.h"
|
||||
__static_yoink("nsync_notice");
|
||||
|
||||
|
@ -179,10 +180,10 @@ static waiter *free_waiters_pop (void) {
|
|||
return w;
|
||||
}
|
||||
|
||||
static void free_waiters_populate (void) {
|
||||
static bool free_waiters_populate (void) {
|
||||
int n;
|
||||
if (IsNetbsd ()) {
|
||||
// netbsd needs a real file descriptor per semaphore
|
||||
// netbsd semaphores are file descriptors
|
||||
n = 1;
|
||||
} else {
|
||||
n = __pagesize / sizeof(waiter);
|
||||
|
@ -192,14 +193,17 @@ static void free_waiters_populate (void) {
|
|||
MAP_PRIVATE | MAP_ANONYMOUS,
|
||||
-1, 0);
|
||||
if (waiters == MAP_FAILED)
|
||||
nsync_panic_ ("out of memory\n");
|
||||
return false;
|
||||
for (size_t i = 0; i < n; ++i) {
|
||||
waiter *w = &waiters[i];
|
||||
w->tag = WAITER_TAG;
|
||||
w->nw.tag = NSYNC_WAITER_TAG;
|
||||
if (!nsync_mu_semaphore_init (&w->sem)) {
|
||||
if (!i)
|
||||
nsync_panic_ ("out of semaphores\n");
|
||||
if (!i) {
|
||||
// netbsd can run out of semaphores
|
||||
munmap (waiters, n * sizeof (waiter));
|
||||
return false;
|
||||
}
|
||||
break;
|
||||
}
|
||||
w->nw.sem = &w->sem;
|
||||
|
@ -208,6 +212,7 @@ static void free_waiters_populate (void) {
|
|||
dll_init (&w->same_condition);
|
||||
free_waiters_push (w);
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
/* -------------------------------- */
|
||||
|
@ -232,11 +237,18 @@ void nsync_waiter_destroy (void *v) {
|
|||
waiter *nsync_waiter_new_ (void) {
|
||||
waiter *w;
|
||||
waiter *tw;
|
||||
unsigned attempts = 0;
|
||||
bool out_of_semaphores = false;
|
||||
tw = waiter_for_thread;
|
||||
w = tw;
|
||||
if (w == NULL || (w->flags & (WAITER_RESERVED|WAITER_IN_USE)) != WAITER_RESERVED) {
|
||||
while (!(w = free_waiters_pop ()))
|
||||
free_waiters_populate ();
|
||||
while (!(w = free_waiters_pop ())) {
|
||||
if (!out_of_semaphores)
|
||||
if (!free_waiters_populate ())
|
||||
out_of_semaphores = true;
|
||||
if (out_of_semaphores)
|
||||
attempts = pthread_delay_np (&free_waiters, attempts);
|
||||
}
|
||||
if (tw == NULL) {
|
||||
w->flags |= WAITER_RESERVED;
|
||||
waiter_for_thread = w;
|
||||
|
|
6
third_party/nsync/mu_semaphore_sem.c
vendored
6
third_party/nsync/mu_semaphore_sem.c
vendored
|
@ -33,7 +33,6 @@
|
|||
#include "third_party/nsync/time.h"
|
||||
#include "third_party/nsync/mu_semaphore.h"
|
||||
#include "libc/intrin/atomic.h"
|
||||
#include "libc/atomic.h"
|
||||
#include "third_party/nsync/time.h"
|
||||
|
||||
/**
|
||||
|
@ -83,8 +82,9 @@ void nsync_mu_semaphore_sem_fork_child (void) {
|
|||
for (f = atomic_load_explicit (&g_sems, memory_order_relaxed); f; f = f->next) {
|
||||
int rc = sys_close (f->id);
|
||||
STRACE ("close(%ld) → %d", f->id, rc);
|
||||
ASSERT (nsync_mu_semaphore_sem_create (f));
|
||||
}
|
||||
for (f = atomic_load_explicit (&g_sems, memory_order_relaxed); f; f = f->next)
|
||||
ASSERT (nsync_mu_semaphore_sem_create (f));
|
||||
}
|
||||
|
||||
/* Initialize *s; the initial value is 0. */
|
||||
|
@ -92,7 +92,7 @@ bool nsync_mu_semaphore_init_sem (nsync_semaphore *s) {
|
|||
struct sem *f = (struct sem *) s;
|
||||
if (!nsync_mu_semaphore_sem_create (f))
|
||||
return false;
|
||||
sems_push(f);
|
||||
sems_push (f);
|
||||
return true;
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue