mirrors/cosmopolitan
1
0
Fork 0
mirror of https://github.com/jart/cosmopolitan.git synced 2025-05-29 00:32:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix printing decimal-point character on printf %#a (#1296)

Browse source 
The C standard indicates that when processing the a conversion specifier
"if the precision is zero *and* the # flag is not specified, no decimal-
point character appears.". This means that __fmt needs to ensure that it
prints the decimal-point character not only when the precision is non-0,
but also when the # flag is specified - cosmopolitan currently does not.

This patch fixes this, along with adding a few tests for this behaviour.
This commit is contained in:
Gabriel Ravier 2024-09-16 01:42:51 +02:00 • committed by GitHub
parent ef62730ae4
commit 81bc8d0963
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 26 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

25
test/libc/stdio/snprintf_test.c
View file

@ -217,12 +217,24 @@ TEST(snprintf, testLongDoubleRounding) {
ASSERT_EQ(0, fesetround(previous_rounding));
}
void check_a_conversion_specifier_prec_1(const char *result_str, double value) {
void check_a_conversion_specifier_double(const char *fmt, const char *expected_str, double value) {
char buf[30] = {0};
int i = snprintf(buf, sizeof(buf), "%.1a", value);
int i = snprintf(buf, sizeof(buf), fmt, value);
ASSERT_EQ(strlen(result_str), i);
ASSERT_STREQ(result_str, buf);
ASSERT_EQ(strlen(expected_str), i);
ASSERT_STREQ(expected_str, buf);
}
void check_a_conversion_specifier_long_double(const char *fmt, const char *expected_str, long double value) {
char buf[30] = {0};
int i = snprintf(buf, sizeof(buf), fmt, value);
ASSERT_EQ(strlen(expected_str), i);
ASSERT_STREQ(expected_str, buf);
}
void check_a_conversion_specifier_prec_1(const char *expected_str, double value) {
check_a_conversion_specifier_double("%.1a", expected_str, value);
}
TEST(snprintf, testAConversionSpecifierRounding) {
@ -247,6 +259,11 @@ TEST(snprintf, testAConversionSpecifier) {
check_a_conversion_specifier_prec_1("0x1.6p+4", 0x1.68p+4);
check_a_conversion_specifier_prec_1("0x1.ap+4", 0x1.98p+4);
check_a_conversion_specifier_prec_1("0x1.ap+4", 0x1.a8p+4);
check_a_conversion_specifier_double("%#a", "0x0.p+0", 0x0.0p0);
check_a_conversion_specifier_double("%#A", "0X0.P+0", 0x0.0p0);
check_a_conversion_specifier_long_double("%#La", "0x0.p+0", 0x0.0p0L);
check_a_conversion_specifier_long_double("%#LA", "0X0.P+0", 0x0.0p0L);
}
TEST(snprintf, apostropheFlag) {