Make more Windows socket fixes and improvements

This change makes send() / sendto() always block on Windows. It's needed
because poll(POLLOUT) doesn't guarantee a socket is immediately writable
on Windows, and it caused rsync to fail because it made that assumption.
The only exception is when a SO_SNDTIMEO is specified which will EAGAIN.

Tests are added confirming MSG_WAITALL and MSG_NOSIGNAL work as expected
on all our supported OSes. Most of the platform-specific MSG_FOO magnums
have been deleted, with the exception of MSG_FASTOPEN. Your --strace log
will now show MSG_FOO flags as symbols rather than numbers.

I've also removed cv_wait_example_test because it's 0.3% flaky with Qemu
under system load since it depends on a process being readily scheduled.
This commit is contained in:
Justine Tunney 2024-09-18 19:54:56 -07:00
parent ce2fbf9325
commit 87a6669900
No known key found for this signature in database
GPG key ID: BE714B4575D6E328
41 changed files with 584 additions and 184 deletions

View file

@ -6790,24 +6790,9 @@ PyInit__socket(void)
PyModule_AddIntMacro(m, MSG_TRUNC);
PyModule_AddIntMacro(m, MSG_CTRUNC);
PyModule_AddIntMacro(m, MSG_WAITALL);
if (MSG_DONTWAIT) PyModule_AddIntMacro(m, MSG_DONTWAIT);
if (MSG_EOR) PyModule_AddIntMacro(m, MSG_EOR);
if (MSG_NOSIGNAL) PyModule_AddIntMacro(m, MSG_NOSIGNAL);
if (MSG_BCAST) PyModule_AddIntMacro(m, MSG_BCAST);
if (MSG_MCAST) PyModule_AddIntMacro(m, MSG_MCAST);
if (MSG_CMSG_CLOEXEC) PyModule_AddIntMacro(m, MSG_CMSG_CLOEXEC);
if (MSG_ERRQUEUE) PyModule_AddIntMacro(m, MSG_ERRQUEUE);
if (MSG_CONFIRM) PyModule_AddIntMacro(m, MSG_CONFIRM);
if (MSG_MORE) PyModule_AddIntMacro(m, MSG_MORE);
if (MSG_NOTIFICATION) PyModule_AddIntMacro(m, MSG_NOTIFICATION);
if (MSG_EOF) PyModule_AddIntMacro(m, MSG_EOF);
if (MSG_FASTOPEN) PyModule_AddIntMacro(m, MSG_FASTOPEN);
#ifdef MSG_BTAG
if (MSG_BTAG) PyModule_AddIntMacro(m, MSG_BTAG);
#endif
#ifdef MSG_ETAG
if (MSG_ETAG) PyModule_AddIntMacro(m, MSG_ETAG);
#endif
PyModule_AddIntMacro(m, MSG_DONTWAIT);
PyModule_AddIntMacro(m, MSG_NOSIGNAL);
if (MSG_FASTOPEN != -1) PyModule_AddIntMacro(m, MSG_FASTOPEN);
/* Protocol level and numbers, usable for [gs]etsockopt */
PyModule_AddIntMacro(m, SOL_SOCKET);