Apply even more fixups

- Finish cleaning up the stdio unlocked APIs
- Make __cxa_finalize() properly thread safe
- Don't log locks if threads aren't being used
- Add some more mutex guards to places using _mmi
- Specific lock names now appear in the --ftrace logs
- Fix mkdeps.com generating invalid Makefiles sometimes
- Simplify and fix bugs in the test runner infrastructure
- Fix issue where sometimes some functions wouldn't be logged

libc/log/backtrace.internal.h

@@ -7,6 +7,7 @@
 COSMOPOLITAN_C_START_
 
 forceinline pureconst bool IsValidStackFramePointer(struct StackFrame *x) {
+  /* assumes __mmi_lock() is held */
   return IsLegalPointer(x) && !((uintptr_t)x & 15) &&
          (IsStaticStackFrame((uintptr_t)x >> 16) ||
           IsSigAltStackFrame((uintptr_t)x >> 16) ||

libc/log/backtrace2.c

@@ -53,6 +53,7 @@ static void ShowHint(const char *s) {
 }
 
 static int PrintBacktraceUsingAddr2line(int fd, const struct StackFrame *bp) {
+  bool ok;
   ssize_t got;
   intptr_t addr;
   size_t i, j, gi;
@@ -99,7 +100,10 @@ static int PrintBacktraceUsingAddr2line(int fd, const struct StackFrame *bp) {
   garbage = weaken(__garbage);
   gi = garbage ? garbage->i : 0;
   for (frame = bp; frame && i < kBacktraceMaxFrames - 1; frame = frame->next) {
-    if (!IsValidStackFramePointer(frame)) {
+    __mmi_lock();
+    ok = IsValidStackFramePointer(frame);
+    __mmi_unlock();
+    if (!ok) {
       return -1;
     }
     addr = frame->addr;

libc/log/backtrace3.c

@@ -27,6 +27,7 @@
 #include "libc/macros.internal.h"
 #include "libc/nexgen32e/gc.internal.h"
 #include "libc/nexgen32e/stackframe.h"
+#include "libc/runtime/memtrack.internal.h"
 #include "libc/runtime/runtime.h"
 #include "libc/runtime/symbols.internal.h"
 #include "libc/str/str.h"
@@ -46,6 +47,7 @@
 noinstrument noasan int PrintBacktraceUsingSymbols(int fd,
                                                    const struct StackFrame *bp,
                                                    struct SymbolTable *st) {
+  bool ok;
   size_t gi;
   intptr_t addr;
   int i, symbol, addend;
@@ -55,7 +57,10 @@ noinstrument noasan int PrintBacktraceUsingSymbols(int fd,
   garbage = weaken(__garbage);
   gi = garbage ? garbage->i : 0;
   for (i = 0, frame = bp; frame; frame = frame->next) {
-    if (!IsValidStackFramePointer(frame)) {
+    __mmi_lock();
+    ok = IsValidStackFramePointer(frame);
+    __mmi_unlock();
+    if (!ok) {
       kprintf("%p corrupt frame pointer\n", frame);
       break;
     }