Improve synchronization

- Fix bugs in kDos2Errno definition
- malloc() should now be thread safe
- Fix bug in rollup.com header generator
- Fix open(O_APPEND) on the New Technology
- Fix select() on the New Technology and test it
- Work towards refactoring i/o for thread safety
- Socket reads and writes on NT now poll for signals
- Work towards i/o completion ports on the New Technology
- Make read() and write() intermittently check for signals
- Blinkenlights keyboard i/o so much better on NT w/ poll()
- You can now poll() files and sockets at the same time on NT
- Fix bug in appendr() that manifests with dlmalloc footers off

libc/calls/open-nt.c

@@ -36,89 +36,12 @@
 #include "libc/sysv/consts/o.h"
 #include "libc/sysv/errfuns.h"
 
-#define _O_APPEND     0x00000400 /* kNtFileAppendData */
-#define _O_CREAT      0x00000040 /* kNtOpenAlways */
-#define _O_EXCL       0x00000080 /* kNtCreateNew */
-#define _O_TRUNC      0x00000200 /* kNtCreateAlways */
-#define _O_DIRECTORY  0x00010000 /* kNtFileFlagBackupSemantics */
-#define _O_TMPFILE    0x00410000 /* AttributeTemporary|FlagDeleteOnClose */
-#define _O_DIRECT     0x00004000 /* kNtFileFlagNoBuffering */
-#define _O_NDELAY     0x00000800 /* kNtFileFlagWriteThrough */
-#define _O_RANDOM     0x80000000 /* kNtFileFlagRandomAccess */
-#define _O_SEQUENTIAL 0x40000000 /* kNtFileFlagSequentialScan */
-#define _O_COMPRESSED 0x20000000 /* kNtFileAttributeCompressed */
-#define _O_INDEXED    0x10000000 /* !kNtFileAttributeNotContentIndexed */
-#define _O_NONBLOCK   0x00000800
-#define _O_CLOEXEC    0x00080000
-
 static textwindows int64_t sys_open_nt_impl(int dirfd, const char *path,
                                             uint32_t flags, int32_t mode) {
-  int64_t handle;
-  uint32_t br, err;
   char16_t path16[PATH_MAX];
   uint32_t perm, share, disp, attr;
-
   if (__mkntpathat(dirfd, path, flags, path16) == -1) return -1;
-
-  switch (flags & O_ACCMODE) {
-    case O_RDONLY:
-      perm = kNtFileGenericRead | kNtGenericExecute;
-      break;
-    case O_WRONLY:
-      perm = kNtFileGenericWrite | kNtGenericExecute;
-      break;
-    case O_RDWR:
-      perm = kNtFileGenericRead | kNtFileGenericWrite | kNtGenericExecute;
-      break;
-    default:
-      unreachable;
-  }
-
-  if (flags & _O_EXCL) {
-    share = kNtFileShareExclusive;
-  } else {
-    share = kNtFileShareRead | kNtFileShareWrite | kNtFileShareDelete;
-  }
-
-  if ((flags & _O_CREAT) && (flags & _O_EXCL)) {
-    disp = kNtCreateNew;
-  } else if ((flags & _O_CREAT) && (flags & _O_TRUNC)) {
-    disp = kNtCreateAlways;
-  } else if (flags & _O_CREAT) {
-    disp = kNtOpenAlways;
-  } else if (flags & _O_TRUNC) {
-    disp = kNtTruncateExisting;
-  } else {
-    disp = kNtOpenExisting;
-  }
-
-  if ((flags & _O_TMPFILE) == _O_TMPFILE) {
-    attr = kNtFileAttributeTemporary | kNtFileFlagDeleteOnClose;
-  } else {
-    attr = kNtFileAttributeNormal;
-    if (flags & _O_DIRECTORY) attr |= kNtFileFlagBackupSemantics;
-    if (~mode & 0200) {
-      attr |= kNtFileAttributeReadonly;
-      if (!IsTiny() && disp == kNtCreateAlways) {
-        // iron out esoteric unix/win32 inconsistency (golang #38225)
-        if ((handle = CreateFile(path16, perm, share, &kNtIsInheritable,
-                                 kNtTruncateExisting, kNtFileAttributeNormal,
-                                 0)) != -1 ||
-            (errno != ENOENT && errno != ENOTDIR)) {
-          return handle;
-        }
-      }
-    }
-  }
-
-  flags |= kNtFileFlagOverlapped;
-  if (~flags & _O_INDEXED) attr |= kNtFileAttributeNotContentIndexed;
-  if (flags & _O_COMPRESSED) attr |= kNtFileAttributeCompressed;
-  if (flags & _O_SEQUENTIAL) attr |= kNtFileFlagSequentialScan;
-  if (flags & _O_RANDOM) attr |= kNtFileFlagRandomAccess;
-  if (flags & _O_DIRECT) attr |= kNtFileFlagNoBuffering;
-  if (flags & _O_NDELAY) attr |= kNtFileFlagWriteThrough;
-
+  if (GetNtOpenFlags(flags, mode, &perm, &share, &disp, &attr) == -1) return -1;
   return CreateFile(path16, perm, share, &kNtIsInheritable, disp, attr, 0);
 }
 
@@ -141,6 +64,7 @@ static textwindows ssize_t sys_open_nt_console(int dirfd,
   }
   g_fds.p[fd].kind = kFdConsole;
   g_fds.p[fd].flags = flags;
+  g_fds.p[fd].mode = mode;
   return fd;
 }
 
@@ -150,6 +74,7 @@ static textwindows ssize_t sys_open_nt_file(int dirfd, const char *file,
   if ((g_fds.p[fd].handle = sys_open_nt_impl(dirfd, file, flags, mode)) != -1) {
     g_fds.p[fd].kind = kFdFile;
     g_fds.p[fd].flags = flags;
+    g_fds.p[fd].mode = mode;
     return fd;
   } else {
     return -1;
@@ -160,7 +85,7 @@ textwindows ssize_t sys_open_nt(int dirfd, const char *file, uint32_t flags,
                                 int32_t mode) {
   int fd;
   ssize_t rc;
-  if ((fd = __reservefd()) == -1) return -1;
+  if ((fd = __reservefd(-1)) == -1) return -1;
   if ((flags & O_ACCMODE) == O_RDWR && !strcmp(file, kNtMagicPaths.devtty)) {
     rc = sys_open_nt_console(dirfd, &kNtMagicPaths, flags, mode, fd);
   } else {