mirrors/cosmopolitan
1
0
Fork 0
mirror of https://github.com/jart/cosmopolitan.git synced 2025-06-26 22:38:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Improve getservbyname and getservbyport (#207)

Browse source 
- support aliases in /etc/services
- use case insensitive comparisons
- add tests
This commit is contained in:
Gautham 2021-07-06 00:55:26 +05:30 • committed by GitHub
parent 58fb2fb3d3
commit c0bec24fa2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 202 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

13
libc/dns/getservbyname.c
View file

@ -31,21 +31,19 @@
struct servent *getservbyname(const char *name, const char *proto) {
static struct servent *ptr0, se0;
static char s_name[DNS_NAME_MAX + 1];
char *localproto = proto;
int p;
if (!ptr0) {
se0.s_name = NULL;
se0.s_aliases = (char **)malloc(sizeof(char *) * 1);
if (!se0.s_aliases) return NULL;
se0.s_aliases[0] = NULL;
se0.s_name = s_name;
if (!(se0.s_aliases = calloc(1, sizeof(char *)))) return NULL;
se0.s_port = 0;
se0.s_proto = NULL;
ptr0 = &se0;
}
p = LookupServicesByName(name, &localproto);
p = LookupServicesByName(name, &localproto, ptr0->s_name, DNS_NAME_MAX, NULL);
if (p == -1) {
// localproto got alloc'd during the lookup?
if (!proto && localproto != proto) free(localproto);
@ -53,9 +51,6 @@ struct servent *getservbyname(const char *name, const char *proto) {
}
ptr0->s_port = p;
if (ptr0->s_name) free(ptr0->s_name);
ptr0->s_name = strdup(name);
if (ptr0->s_proto) free(ptr0->s_proto);
ptr0->s_proto = strdup(localproto);