Make locks more reliable

This change switches most of the core locks to be re-entrant, in order
to reduce the chance of deadlocking code that does, clever things with
asynchronous signal handlers. This change implements it it in pthreads
so we're one step closer to having a standardized threading primitives

test/libc/intrin/pthread_mutex_lock_test.c

@@ -0,0 +1,43 @@
+/*-*- mode:c;indent-tabs-mode:nil;c-basic-offset:2;tab-width:8;coding:utf-8 -*-│
+│vi: set net ft=c ts=2 sts=2 sw=2 fenc=utf-8                                :vi│
+╞══════════════════════════════════════════════════════════════════════════════╡
+│ Copyright 2022 Justine Alexandra Roberts Tunney                              │
+│                                                                              │
+│ Permission to use, copy, modify, and/or distribute this software for         │
+│ any purpose with or without fee is hereby granted, provided that the         │
+│ above copyright notice and this permission notice appear in all copies.      │
+│                                                                              │
+│ THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL                │
+│ WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED                │
+│ WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE             │
+│ AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL         │
+│ DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR        │
+│ PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER               │
+│ TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR             │
+│ PERFORMANCE OF THIS SOFTWARE.                                                │
+╚─────────────────────────────────────────────────────────────────────────────*/
+#include "libc/intrin/pthread.h"
+#include "libc/testlib/ezbench.h"
+#include "libc/testlib/testlib.h"
+#include "libc/thread/thread.h"
+
+static void *DoNothing(void *arg) {
+  return 0;
+}
+
+static void MakeSureThreadingModeIsEnabled(void) {
+  void *exitcode;
+  cthread_t thread;
+  ASSERT_EQ(0, cthread_create(&thread, 0, DoNothing, 0));
+  ASSERT_EQ(0, cthread_join(thread, 0));
+}
+
+void SetUp(void) {
+  MakeSureThreadingModeIsEnabled();
+}
+
+BENCH(pthread_mutex_lock, bench) {
+  pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZER;
+  EZBENCH2("pthread_mutex_lock", donothing,
+           (pthread_mutex_lock(&lock), pthread_mutex_unlock(&lock)));
+}

test/libc/intrin/test.mk

@@ -36,6 +36,7 @@ TEST_LIBC_INTRIN_DIRECTDEPS =				\
 	LIBC_STUBS					\
 	LIBC_SYSV					\
 	LIBC_TESTLIB					\
+	LIBC_THREAD					\
 	LIBC_TINYMATH					\
 	LIBC_UNICODE					\
 	LIBC_X						\

test/libc/runtime/mmap_test.c

@@ -223,7 +223,6 @@ TEST(mmap, cow) {
   char *p;
   char path[PATH_MAX];
   sprintf(path, "%s%s.%ld", kTmpPath, program_invocation_short_name, lemur64());
-  kprintf("path = %#s\n", path);
   ASSERT_NE(-1, (fd = open(path, O_CREAT | O_TRUNC | O_RDWR, 0644)));
   EXPECT_EQ(5, write(fd, "hello", 5));
   EXPECT_NE(-1, fdatasync(fd));

test/libc/thread/create_test.c

@@ -37,7 +37,6 @@ TEST(cthread_create, testJoinDeadlock) {
 }
 
 TEST(cthread_create, testCreateReturnJoin) {
-  if (IsOpenbsd()) return;  // TODO(jart): we've getting flakes
   void *exitcode;
   cthread_t thread;
   ASSERT_EQ(0, cthread_create(&thread, 0, ReturnArg, ReturnArg));
@@ -50,7 +49,6 @@ static void *ExitArg(void *arg) {
 }
 
 TEST(cthread_create, testCreateExitJoin) {
-  if (IsOpenbsd()) return;  // TODO(jart): we've getting flakes
   void *exitcode;
   cthread_t thread;
   ASSERT_EQ(0, cthread_create(&thread, 0, ExitArg, (void *)-31337));
@@ -61,7 +59,6 @@ TEST(cthread_create, testCreateExitJoin) {
 TEST(gcctls, size) {
   if (IsXnu()) return;      // TODO(jart): codemorph
   if (IsWindows()) return;  // TODO(jart): codemorph
-  if (IsOpenbsd()) return;  // TODO(jart): we've getting flakes
   // schlep in .zip section too
   // make sure executable isn't too huge
   size_t size;
@@ -87,7 +84,6 @@ static void *TlsWorker(void *arg) {
 TEST(gcctls, worksAndIsNonInheritable) {
   if (IsXnu()) return;      // TODO(jart): codemorph
   if (IsWindows()) return;  // TODO(jart): codemorph
-  if (IsOpenbsd()) return;  // TODO(jart): we've getting flakes
   void *exitcode;
   cthread_t thread;
   ASSERT_EQ(tdata, 31337);