mirrors/cosmopolitan
1
0
Fork 0
mirror of https://github.com/jart/cosmopolitan.git synced 2025-05-29 00:32:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Improve wait statuses

Browse source 
This change has the insight that dwExitCode isn't an exit code but
rather should be used to pass the wait status. This lets us report
killing as a termination status, similar to UNIX. This change also
fixes the fact that exit(259) on Windows will break the parent due
way WIN32 is designed. We now work around that.

It turns out that NetBSD and OpenBSD, will let you have exit codes
beyond 255. This change will let you use them when it's possible.
This commit is contained in:
Justine Tunney 2023-07-30 14:26:21 -07:00
parent d9d5f45e2d
commit c8aa33e0e2
No known key found for this signature in database
GPG key ID: BE714B4575D6E328
22 changed files with 259 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

24
libc/intrin/exit.c
View file

@ -20,6 +20,7 @@
#include "libc/intrin/promises.internal.h"
#include "libc/intrin/strace.internal.h"
#include "libc/nexgen32e/vendor.internal.h"
#include "libc/nt/enum/status.h"
#include "libc/nt/runtime.h"
#include "libc/runtime/runtime.h"
#include "libc/sysv/consts/nr.h"
@ -30,7 +31,10 @@
* When running on bare metal, this function will reboot your computer
* by hosing the interrupt descriptors and triple faulting the system.
*
* @param exitcode is masked with 255 on unix (but not windows)
* Exit codes are narrowed to an unsigned char on most platforms. The
* exceptions would be Windows, NetBSD, and OpenBSD, which should let
* you have larger exit codes.
*
* @asyncsignalsafe
* @threadsafe
* @vforksafe
@ -79,7 +83,23 @@ wontreturn void _Exit(int exitcode) {
: "x8", "memory");
#endif
} else if (IsWindows()) {
ExitProcess(exitcode);
uint32_t waitstatus;
waitstatus = exitcode;
waitstatus <<= 8;
if (waitstatus == kNtStillActive) {
// The GetExitCodeProcess function returns a valid error code
// defined by the application only after the thread terminates.
// Therefore, an application should not use STILL_ACTIVE (259) as
// an error code (STILL_ACTIVE is a macro for STATUS_PENDING
// (minwinbase.h)). If a thread returns STILL_ACTIVE (259) as an
// error code, then applications that test for that value could
// interpret it to mean that the thread is still running, and
// continue to test for the completion of the thread after the
// thread has terminated, which could put the application into an
// infinite loop. -Quoth MSDN (see also libc/calls/wait4-nt.c)
waitstatus = 0xc9af3d51u;
}
ExitProcess(waitstatus);
}
#ifdef __x86_64__
asm("push\t$0\n\t"