From 44d4931c8801d259e232105068deeb1b7bc8a3a1 Mon Sep 17 00:00:00 2001 From: tabudz Date: Wed, 19 Feb 2025 00:44:44 +0800 Subject: [PATCH 1/2] Make sure nSelectors is not out of range nSelectors is used in a loop from 0 to nSelectors to access selectorMtf which is UChar selectorMtf[BZ_MAX_SELECTORS]; so if nSelectors is bigger than BZ_MAX_SELECTORS it'll do an invalid memory access Fixes out of bounds access discovered while fuzzying karchive --- third_party/bzip2/decompress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third_party/bzip2/decompress.c b/third_party/bzip2/decompress.c index 1fef62b8f..1ccd2d58f 100644 --- a/third_party/bzip2/decompress.c +++ b/third_party/bzip2/decompress.c @@ -287,7 +287,7 @@ Int32 BZ2_decompress ( DState* s ) GET_BITS(BZ_X_SELECTOR_1, nGroups, 3); if (nGroups < 2 || nGroups > BZ_N_GROUPS) RETURN(BZ_DATA_ERROR); GET_BITS(BZ_X_SELECTOR_2, nSelectors, 15); - if (nSelectors < 1) RETURN(BZ_DATA_ERROR); + if (nSelectors < 1 || nSelectors > BZ_MAX_SELECTORS) RETURN(BZ_DATA_ERROR); for (i = 0; i < nSelectors; i++) { j = 0; while (True) { From 323f744be8fd6a1c4d7b00fc0e2bcc0753643377 Mon Sep 17 00:00:00 2001 From: tabudz Date: Wed, 19 Feb 2025 00:51:31 +0800 Subject: [PATCH 2/2] add local change to README.cosmo --- third_party/bzip2/README.cosmo | 3 +++ 1 file changed, 3 insertions(+) diff --git a/third_party/bzip2/README.cosmo b/third_party/bzip2/README.cosmo index 1a92c1513..4c3aba4ed 100644 --- a/third_party/bzip2/README.cosmo +++ b/third_party/bzip2/README.cosmo @@ -9,3 +9,6 @@ ORIGIN Author: Mark Wielaard Date: Sat Jul 13 17:17:58 2019 +0200 Prepare for 1.0.8 release. + +local vulnerability fix: +- Fix CVE-2019-12900 \ No newline at end of file