From cde92c39444047147f7599431a542e3baa1b08fe Mon Sep 17 00:00:00 2001 From: Paul Kulchenko Date: Sun, 31 Oct 2021 16:37:57 -0700 Subject: [PATCH] Rename redbean Lua function GetComment to GetAssetComment This breaking change improves consistency with other GetAsset* functions. --- tool/net/help.txt | 8 ++++---- tool/net/redbean.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tool/net/help.txt b/tool/net/help.txt index cf276421a..6ef03ad5f 100644 --- a/tool/net/help.txt +++ b/tool/net/help.txt @@ -592,6 +592,10 @@ FUNCTIONS Turns integer like 0x01020304 into a string like 1.2.3.4. See also ParseIp for the inverse operation. + GetAssetComment(path:str) → str + Returns comment text associated with asset in the ZIP central + directory. + GetAssetMode(path:str) → int Returns UNIX-style octal mode for ZIP asset (or local file if the -D flag is used) @@ -600,10 +604,6 @@ FUNCTIONS Returns byte size of uncompressed contents of ZIP asset (or local file if the -D flag is used) - GetComment(path:str) → str - Returns comment text associated with asset in the ZIP central - directory. - GetCookie(name:str) → str Returns cookie value. diff --git a/tool/net/redbean.c b/tool/net/redbean.c index fc4e9344e..d6d6832e7 100644 --- a/tool/net/redbean.c +++ b/tool/net/redbean.c @@ -5092,7 +5092,7 @@ static int LuaIsDaemon(lua_State *L) { return 1; } -static int LuaGetComment(lua_State *L) { +static int LuaGetAssetComment(lua_State *L) { struct Asset *a; const char *path; size_t pathlen, m; @@ -5325,10 +5325,10 @@ static const luaL_Reg kLuaFuncs[] = { {"Fetch", LuaFetch}, // {"FormatHttpDateTime", LuaFormatHttpDateTime}, // {"FormatIp", LuaFormatIp}, // + {"GetAssetComment", LuaGetAssetComment}, // {"GetAssetMode", LuaGetAssetMode}, // {"GetAssetSize", LuaGetAssetSize}, // {"GetClientAddr", LuaGetClientAddr}, // - {"GetComment", LuaGetComment}, // {"GetCookie", LuaGetCookie}, // {"GetDate", LuaGetDate}, // {"GetEffectivePath", LuaGetEffectivePath}, //