mirrors/cosmopolitan
1
0
Fork 0
mirror of https://github.com/jart/cosmopolitan.git synced 2025-08-09 19:30:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Reduce redbean logging for bad descriptor (EBADF)

Browse source 
This may happen on explicitly closed client connections, so reduce the
logging level similar to other errors.
This commit is contained in:
Paul Kulchenko 2022-07-03 17:39:20 -07:00
parent 5df3e4e7a8
commit cf68b2f864
1 changed files with 13 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tool/net/redbean.c
View file

@ -2274,7 +2274,11 @@ static ssize_t Send(struct iovec *iov, int iovlen) {
errno = 0;
} else {
LockInc(&shared->c.writeerrors);
WARNF("(rsp) %s write error: %m", DescribeClient());
if (errno == EBADF) { // don't warn on close/bad fd
DEBUGF("(rsp) %s write badf", DescribeClient());
} else {
WARNF("(rsp) %s write error: %m", DescribeClient());
}
}
connectionclose = true;
}
@ -5417,7 +5421,7 @@ static const char *DescribeClose(void) {
if (killed) return "killed";
if (meltdown) return "meltdown";
if (terminated) return "terminated";
if (connectionclose) return "connectionclose";
if (connectionclose) return "connection closed";
return "destroyed";
}
@ -6320,15 +6324,19 @@ static void HandleMessages(void) {
LockInc(&shared->c.readtimeouts);
if (amtread) SendTimeout();
NotifyClose();
LogClose("readtimeout");
LogClose("read timeout");
return;
} else if (errno == ECONNRESET) {
LockInc(&shared->c.readresets);
LogClose("readreset");
LogClose("read reset");
return;
} else {
LockInc(&shared->c.readerrors);
WARNF("(clnt) %s readerror: %m", DescribeClient());
if (errno == EBADF) { // don't warn on close/bad fd
LogClose("read badf");
} else {
WARNF("(clnt) %s read error: %m", DescribeClient());
}
return;
}
if (killed || (terminated && !amtread) ||