Make improvements to locking

This change makes pthread_mutex_lock() as fast as _spinlock() by
default. Thread instability issues on NetBSD have been resolved.
Improvements made to gdtoa thread code. Crash reporting will now
synchronize between threads in a slightly better way.

libc/stdio/fflush_unlocked.c

@@ -34,10 +34,12 @@
 static pthread_mutex_t __fflush_lock_obj;
 
 void(__fflush_lock)(void) {
+  __fflush_lock_obj.attr = PTHREAD_MUTEX_RECURSIVE;
   pthread_mutex_lock(&__fflush_lock_obj);
 }
 
 void(__fflush_unlock)(void) {
+  __fflush_lock_obj.attr = PTHREAD_MUTEX_RECURSIVE;
   pthread_mutex_unlock(&__fflush_lock_obj);
 }
 

libc/stdio/flockfile.c

@@ -22,5 +22,6 @@
  * Acquires reentrant lock on stdio object, blocking if needed.
  */
 void(flockfile)(FILE *f) {
+  f->lock.attr = PTHREAD_MUTEX_RECURSIVE;
   pthread_mutex_lock(&f->lock);
 }

libc/stdio/fmemopen.c

@@ -16,6 +16,7 @@
 │ TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR             │
 │ PERFORMANCE OF THIS SOFTWARE.                                                │
 ╚─────────────────────────────────────────────────────────────────────────────*/
+#include "libc/intrin/pthread.h"
 #include "libc/mem/mem.h"
 #include "libc/stdio/stdio.h"
 #include "libc/str/str.h"

libc/stdio/funlockfile.c

@@ -22,5 +22,6 @@
  * Releases lock on stdio object.
  */
 void(funlockfile)(FILE *f) {
+  f->lock.attr = PTHREAD_MUTEX_RECURSIVE;
   pthread_mutex_unlock(&f->lock);
 }

libc/stdio/stderr-init.S

@@ -25,13 +25,13 @@
 	.init.start 400,_init_stderr
 	ezlea	__stderr,ax
 	push	$_IOLBF
-	pop	(%rax)				#→ f.fd
+	pop	(%rax)					#→ f.fd
 	push	STDERR_FILENO
 	pop	12(%rax)
 	mov	O_WRONLY,%edx
-	mov	%edx,4(%rax)			#→ f.iomode
+	mov	%edx,4(%rax)				#→ f.iomode
 	ezlea	__stderr_buf,cx
-	mov	%rcx,24(%rax)			#→ f.buf
-	movl	$BUFSIZ,32(%rax)		#→ f.size
+	mov	%rcx,0x18(%rax)				#→ f.buf
+	movl	$BUFSIZ,0x20(%rax)			#→ f.size
 	mov	%rax,stderr(%rip)
 	.init.end 400,_init_stderr,globl,hidden

libc/stdio/stdin-init.S

@@ -25,9 +25,9 @@
 	.init.start 400,_init_stdin
 	ezlea	__stdin,ax
 	mov	O_RDONLY,%edx
-	mov	%edx,4(%rax)			#→ f.iomode
+	mov	%edx,4(%rax)				#→ f.iomode
 	ezlea	__stdin_buf,cx
-	mov	%rcx,24(%rax)			#→ f.buf
-	movl	$BUFSIZ,32(%rax)		#→ f.size
+	mov	%rcx,0x18(%rax)				#→ f.buf
+	movl	$BUFSIZ,0x20(%rax)			#→ f.size
 	mov	%rax,stdin(%rip)
 	.init.end 400,_init_stdin,globl,hidden

libc/stdio/stdio.h

@@ -16,19 +16,19 @@ COSMOPOLITAN_C_START_
 ╚────────────────────────────────────────────────────────────────────────────│*/
 
 typedef struct FILE {
-  uint8_t bufmode; /* 0x00 _IOFBF, etc. (ignored if fd=-1) */
-  bool noclose;    /* 0x01 for fake dup() todo delete! */
-  uint32_t iomode; /* 0x04 O_RDONLY, etc. (ignored if fd=-1) */
-  int32_t state;   /* 0x08 0=OK, -1=EOF, >0=errno */
-  int fd;          /* 0x0c ≥0=fd, -1=closed|buffer */
-  uint32_t beg;    /* 0x10 */
-  uint32_t end;    /* 0x14 */
-  char *buf;       /* 0x18 */
-  uint32_t size;   /* 0x20 */
-  uint32_t nofree; /* 0x24 */
-  int pid;         /* 0x28 */
-  char *getln;
-  pthread_mutex_t lock;
+  uint8_t bufmode;      /* 0x00 _IOFBF, etc. (ignored if fd=-1) */
+  bool noclose;         /* 0x01 for fake dup() todo delete! */
+  uint32_t iomode;      /* 0x04 O_RDONLY, etc. (ignored if fd=-1) */
+  int32_t state;        /* 0x08 0=OK, -1=EOF, >0=errno */
+  int fd;               /* 0x0c ≥0=fd, -1=closed|buffer */
+  uint32_t beg;         /* 0x10 */
+  uint32_t end;         /* 0x14 */
+  char *buf;            /* 0x18 */
+  uint32_t size;        /* 0x20 */
+  uint32_t nofree;      /* 0x24 */
+  int pid;              /* 0x28 */
+  char *getln;          /* 0x30 */
+  pthread_mutex_t lock; /* 0x38 */
 } FILE;
 
 extern FILE *stdin;

libc/stdio/stdout-init.S

@@ -25,11 +25,11 @@
 	.init.start 400,_init_stdout
 	ezlea	__stdout,ax
 	push	STDOUT_FILENO
-	pop	12(%rax)			#→ f.fd
+	pop	0x0c(%rax)				#→ f.fd
 	mov	O_WRONLY,%edx
-	mov	%edx,4(%rax)			#→ f.iomode
+	mov	%edx,4(%rax)				#→ f.iomode
 	ezlea	__stdout_buf,cx
-	mov	%rcx,24(%rax)			#→ f.buf
-	movl	$BUFSIZ,32(%rax)		#→ f.size
+	mov	%rcx,0x18(%rax)				#→ f.buf
+	movl	$BUFSIZ,0x20(%rax)			#→ f.size
 	mov	%rax,stdout(%rip)
 	.init.end 400,_init_stdout,globl,hidden