From e3c456d23a6f991245cbe95680df8834924c9236 Mon Sep 17 00:00:00 2001 From: Michael Lenaghan Date: Thu, 10 Aug 2023 00:13:03 -0400 Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20lowercase=20the=20test=20filena?= =?UTF-8?q?me=20(#871)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This test fails if Cosmo builds from a path that contains an uppercase character. Paths with uppercase characters aren’t so common in server Linux. But they are in *desktop* Linux. Guess how I…? But I digress. The real problem is that the path is lowercased on one line, but not the next: ``` self.file_name = support.TESTFN.lower() self.file_path = FakePath(support.TESTFN) ``` Given that no other test in the suite lowercases `support.TESTFN`, I opted to remove it from the first line rather than adding it to the second. --- third_party/python/Lib/test/test_genericpath.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third_party/python/Lib/test/test_genericpath.py b/third_party/python/Lib/test/test_genericpath.py index 664a91631..d9be5d4dd 100644 --- a/third_party/python/Lib/test/test_genericpath.py +++ b/third_party/python/Lib/test/test_genericpath.py @@ -516,7 +516,7 @@ class CommonTest(GenericTest): class PathLikeTests(unittest.TestCase): def setUp(self): - self.file_name = support.TESTFN.lower() + self.file_name = support.TESTFN self.file_path = FakePath(support.TESTFN) self.addCleanup(support.unlink, self.file_name) create_file(self.file_name, b"test_genericpath.PathLikeTests")