Make improvements

- Introduce ualarm() function
- Make rename() report EISEMPTY on Windows
- Always raise EINVAL upon open(O_RDONLY|O_TRUNC)
- Add macro so ./configure will detect SOCK_CLOEXEC
- Fix O_TRUNC without O_CREAT not working on Windows
- Let fcntl(F_SETFL) change O_APPEND status on Windows
- Make sure pwrite() / pread() report ESPIPE on sockets
- Raise ESPIPE on Windows when pwrite() is used on pipe
- Properly compute O_APPEND CreateFile() flags on Windows
- Don't require O_DIRECTORY to open directories on Windows
- Fix more instances of Windows reporting EISDIR and ENOTDIR
- Normalize EFTYPE and EMLINK to ELOOP on NetBSD and FreeBSD
- Make unlink() / rmdir() work on read-only files on Windows
- Validate UTF-8 on Windows paths to fix bug with overlong NUL
- Always print signal name to stderr when crashing due to SIG_DFL
- Fix Windows bug where denormalized paths >260 chars didn't work
- Block signals on BSDs when thread exits before trashing its own stack

libc/testlib/testlib.h

@@ -12,7 +12,7 @@ COSMOPOLITAN_C_START_
  * Test cases are guaranteed by the linker to be run in order, sorted by
  * the (SUITE, NAME) tuple passed here.
  */
-#define TEST(SUITE, NAME)           \
+#define TEST(SUITE, NAME)             \
   __static_yoink("__testcase_start"); \
   __TEST_PROTOTYPE(SUITE, NAME, __TEST_ARRAY, )
 
@@ -25,7 +25,7 @@ COSMOPOLITAN_C_START_
  * temorarilly by the runtime while calling fixture functions. Fixtures
  * are also guaranteed by the linker to be run in sorted order.
  */
-#define FIXTURE(SUITE, NAME)       \
+#define FIXTURE(SUITE, NAME)         \
   __static_yoink("__fixture_start"); \
   __FIXTURE("fixture", SUITE, NAME)
 
@@ -36,7 +36,7 @@ COSMOPOLITAN_C_START_
  * Cartesian product of groups. That makes this similar to fixture, but
  * more appropriate for testing pure code (i.e. no syscalls) like math.
  */
-#define COMBO(GROUP, ENTRY)      \
+#define COMBO(GROUP, ENTRY)        \
   __static_yoink("__combo_start"); \
   __FIXTURE("combo", GROUP, ENTRY)
 
@@ -49,7 +49,7 @@ COSMOPOLITAN_C_START_
  *
  * @see EZBENCH()
  */
-#define BENCH(SUITE, NAME)       \
+#define BENCH(SUITE, NAME)         \
   __static_yoink("__bench_start"); \
   __TEST_PROTOTYPE(SUITE, NAME, __BENCH_ARRAY, optimizespeed)
 
@@ -223,11 +223,12 @@ void TearDownOnce(void);
 
 #define EXPECT_SYS(ERRNO, WANT, GOT, ...)                                  \
   do {                                                                     \
-    testlib_seterrno(0);                                                   \
+    int e = testlib_geterrno();                                            \
     __TEST_EQ(expect, __FILE__, __LINE__, __FUNCTION__, #WANT, #GOT, WANT, \
               GOT, __VA_ARGS__);                                           \
     __TEST_EQ(expect, __FILE__, __LINE__, __FUNCTION__, #ERRNO,            \
               testlib_strerror(), ERRNO, testlib_geterrno(), __VA_ARGS__); \
+    testlib_seterrno(e);                                                   \
   } while (0)
 
 #define EXPECT_FALSE(X) _TEST2("EXPECT_FALSE", false, ==, (X), #X, "", "", 0)
@@ -347,8 +348,6 @@ struct TestFixture {
 };
 
 extern char g_fixturename[256];
-extern char g_testlib_olddir[PATH_MAX];
-extern char g_testlib_tmpdir[PATH_MAX];
 extern bool g_testlib_shoulddebugbreak;     /* set by testmain */
 extern _Atomic(unsigned) g_testlib_ran;     /* set by wrappers */
 extern _Atomic(unsigned) g_testlib_failed;  /* set by wrappers */