mirror of
https://github.com/jart/cosmopolitan.git
synced 2025-05-28 00:02:28 +00:00
Make improvements
- Introduce ualarm() function - Make rename() report EISEMPTY on Windows - Always raise EINVAL upon open(O_RDONLY|O_TRUNC) - Add macro so ./configure will detect SOCK_CLOEXEC - Fix O_TRUNC without O_CREAT not working on Windows - Let fcntl(F_SETFL) change O_APPEND status on Windows - Make sure pwrite() / pread() report ESPIPE on sockets - Raise ESPIPE on Windows when pwrite() is used on pipe - Properly compute O_APPEND CreateFile() flags on Windows - Don't require O_DIRECTORY to open directories on Windows - Fix more instances of Windows reporting EISDIR and ENOTDIR - Normalize EFTYPE and EMLINK to ELOOP on NetBSD and FreeBSD - Make unlink() / rmdir() work on read-only files on Windows - Validate UTF-8 on Windows paths to fix bug with overlong NUL - Always print signal name to stderr when crashing due to SIG_DFL - Fix Windows bug where denormalized paths >260 chars didn't work - Block signals on BSDs when thread exits before trashing its own stack
This commit is contained in:
Justine Tunney
parent
ec957491ea
commit
ebf784d4f5
76 changed files with 1019 additions and 568 deletions
|
|
@ -18,14 +18,20 @@
|
|||
╚─────────────────────────────────────────────────────────────────────────────*/
|
||||
#include "libc/calls/calls.h"
|
||||
#include "libc/calls/internal.h"
|
||||
#include "libc/calls/struct/stat.h"
|
||||
#include "libc/dce.h"
|
||||
#include "libc/errno.h"
|
||||
#include "libc/macros.internal.h"
|
||||
#include "libc/mem/gc.internal.h"
|
||||
#include "libc/runtime/runtime.h"
|
||||
#include "libc/stdio/stdio.h"
|
||||
#include "libc/str/str.h"
|
||||
#include "libc/sysv/consts/o.h"
|
||||
#include "libc/testlib/testlib.h"
|
||||
#include "libc/x/x.h"
|
||||
#include "libc/x/xasprintf.h"
|
||||
|
||||
#define abs(rel) gc(xasprintf("%s/%s", gc(getcwd(0, 0)), rel))
|
||||
|
||||
char testlib_enable_tmp_setup_teardown;
|
||||
|
||||
|
|
@ -113,6 +119,7 @@ TEST(open, testOpenExistingForAppendWriteOnly_seeksToEnd) {
|
|||
char buf[16] = {0};
|
||||
ASSERT_SYS(0, 0, xbarf("hello.txt", "hell", -1));
|
||||
ASSERT_SYS(0, 3, open("hello.txt", O_WRONLY | O_APPEND));
|
||||
EXPECT_SYS(EBADF, -1, pread(3, buf, 4, 0)); // in O_WRONLY mode
|
||||
EXPECT_SYS(0, 1, write(3, "o", 1));
|
||||
EXPECT_SYS(0, 0, lseek(3, 0, SEEK_SET));
|
||||
EXPECT_SYS(0, 1, write(3, "!", 1));
|
||||
|
|
@ -123,6 +130,50 @@ TEST(open, testOpenExistingForAppendWriteOnly_seeksToEnd) {
|
|||
EXPECT_SYS(0, 0, close(3));
|
||||
}
|
||||
|
||||
TEST(open, appendRwMode_readsStartZero_writesAlwaysEof) {
|
||||
char buf[8] = {0};
|
||||
ASSERT_SYS(0, 0, xbarf("hello.txt", "hell", -1));
|
||||
ASSERT_SYS(0, 3, open("hello.txt", O_RDWR | O_APPEND));
|
||||
ASSERT_SYS(0, 2, read(3, buf, 2));
|
||||
ASSERT_SYS(0, 2, read(3, buf + 2, 2));
|
||||
EXPECT_STREQ("hell", buf);
|
||||
EXPECT_SYS(0, 2, write(3, "o!", 2));
|
||||
ASSERT_SYS(0, 6, pread(3, buf, 8, 0));
|
||||
EXPECT_STREQ("hello!", buf);
|
||||
EXPECT_SYS(0, 0, close(3));
|
||||
}
|
||||
|
||||
TEST(open, appendReadOnlyMode_appendIsIgnored) {
|
||||
char buf[8] = {0};
|
||||
ASSERT_SYS(0, 0, xbarf("hello.txt", "hell", -1));
|
||||
ASSERT_SYS(0, 3, open("hello.txt", O_RDONLY | O_APPEND));
|
||||
EXPECT_SYS(EBADF, -1, write(3, "o!", 2)); // due to O_RDONLY
|
||||
ASSERT_EQ(0, errno);
|
||||
ASSERT_SYS(0, 2, read(3, buf, 2));
|
||||
ASSERT_SYS(0, 2, read(3, buf + 2, 2));
|
||||
EXPECT_STREQ("hell", buf);
|
||||
ASSERT_SYS(0, 4, pread(3, buf, 4, 0));
|
||||
EXPECT_SYS(0, 0, close(3));
|
||||
}
|
||||
|
||||
TEST(open, truncReadWriteMode_getsTruncated) {
|
||||
char buf[8] = {0};
|
||||
ASSERT_FALSE(fileexists("hello.txt"));
|
||||
ASSERT_SYS(ENOENT, -1, open("hello.txt", O_RDWR | O_TRUNC));
|
||||
ASSERT_SYS(ENOENT, -1, open("hello.txt/there", O_RDWR | O_TRUNC));
|
||||
ASSERT_SYS(0, 0, xbarf("hello.txt", "hell", -1));
|
||||
ASSERT_SYS(ENOTDIR, -1, open("hello.txt/there", O_RDWR | O_TRUNC));
|
||||
ASSERT_SYS(0, 3, open("hello.txt", O_RDWR | O_TRUNC));
|
||||
ASSERT_SYS(0, 0, read(3, buf, 8));
|
||||
EXPECT_STREQ("", buf);
|
||||
ASSERT_SYS(0, 8, write(3, buf, 8));
|
||||
EXPECT_SYS(0, 0, close(3));
|
||||
}
|
||||
|
||||
TEST(open, truncReadOnlyMode_wontTruncate) {
|
||||
ASSERT_SYS(EINVAL, -1, open("hello.txt", O_RDONLY | O_TRUNC));
|
||||
}
|
||||
|
||||
TEST(open, testRelativePath_opensRelativeToDirFd) {
|
||||
ASSERT_SYS(0, 0, mkdir("foo", 0755));
|
||||
ASSERT_SYS(0, 3, open("foo", O_RDONLY | O_DIRECTORY));
|
||||
|
|
@ -132,6 +183,104 @@ TEST(open, testRelativePath_opensRelativeToDirFd) {
|
|||
EXPECT_SYS(0, 0, close(3));
|
||||
}
|
||||
|
||||
TEST(open, eloop) {
|
||||
ASSERT_SYS(0, 0, symlink("froot", "link"));
|
||||
ASSERT_TRUE(issymlink("link"));
|
||||
ASSERT_SYS(ELOOP, -1, open("link", O_RDONLY | O_NOFOLLOW));
|
||||
}
|
||||
|
||||
TEST(open, norm) {
|
||||
ASSERT_SYS(0, 0, mkdir("fun", 0755));
|
||||
ASSERT_SYS(0, 0, mkdir("fun/house", 0755));
|
||||
ASSERT_SYS(0, 0, touch("fun/house/norm", 0644));
|
||||
ASSERT_SYS(0, 3, open("fun//house//norm", O_RDONLY));
|
||||
ASSERT_SYS(0, 0, close(3));
|
||||
ASSERT_SYS(0, 3, open(abs("fun//house//norm"), O_RDONLY));
|
||||
ASSERT_SYS(0, 0, close(3));
|
||||
ASSERT_SYS(0, 3, open("fun//house/./norm", O_RDONLY));
|
||||
ASSERT_SYS(0, 0, close(3));
|
||||
ASSERT_SYS(0, 3, open(abs("fun//house/./norm"), O_RDONLY));
|
||||
ASSERT_SYS(0, 0, close(3));
|
||||
ASSERT_SYS(0, 3, open("fun//house/../house/norm", O_RDONLY));
|
||||
ASSERT_SYS(0, 0, close(3));
|
||||
ASSERT_SYS(0, 3, open(abs("fun//house/../house/norm"), O_RDONLY));
|
||||
ASSERT_SYS(0, 0, close(3));
|
||||
ASSERT_SYS(ENOTDIR, -1, open("fun//house//norm/", O_RDONLY));
|
||||
ASSERT_SYS(ENOTDIR, -1, open("fun//house//norm/.", O_RDONLY));
|
||||
ASSERT_SYS(ENOTDIR, -1, open("fun//house//norm/./", O_RDONLY));
|
||||
ASSERT_SYS(0, 3, open("fun//house//", O_RDONLY | O_DIRECTORY));
|
||||
ASSERT_SYS(0, 0, close(3));
|
||||
}
|
||||
|
||||
TEST(open, longNormDot) {
|
||||
#define NAME \
|
||||
"funfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfu" \
|
||||
"nfunfunfunfunfunfunnfunfunfunfunfunfunnfunfunfunfunfunfununfunfunfunfunfun"
|
||||
ASSERT_SYS(0, 0, mkdir(NAME, 0755));
|
||||
ASSERT_SYS(0, 0, mkdir(abs(NAME "/" NAME), 0755));
|
||||
ASSERT_SYS(0, 3, creat(abs(NAME "//" NAME "/./norm"), 0644));
|
||||
ASSERT_TRUE(fileexists(abs(NAME "//" NAME "/norm")));
|
||||
ASSERT_SYS(0, 0, close(3));
|
||||
}
|
||||
|
||||
TEST(open, longNormDotDot) {
|
||||
#define NAME \
|
||||
"funfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfunfu" \
|
||||
"nfunfunfunfunfunfunnfunfunfunfunfunfunnfunfunfunfunfunfununfunfunfunfunfun"
|
||||
ASSERT_SYS(0, 0, mkdir(NAME, 0755));
|
||||
ASSERT_SYS(0, 0, mkdir(abs(NAME "/" NAME), 0755));
|
||||
ASSERT_SYS(0, 0, mkdir(abs(NAME "/" NAME "/" NAME), 0755));
|
||||
ASSERT_SYS(0, 3, creat(abs(NAME "//" NAME "//" NAME "/../norm"), 0644));
|
||||
ASSERT_TRUE(fileexists(abs(NAME "//" NAME "/norm")));
|
||||
ASSERT_SYS(0, 0, close(3));
|
||||
}
|
||||
|
||||
TEST(open, creat_directory) {
|
||||
ASSERT_SYS(ENOENT, -1, open("fun", O_WRONLY | O_DIRECTORY));
|
||||
ASSERT_FALSE(fileexists("fun"));
|
||||
if (1) return; // linux 5.15.122-0-lts creates file and returns error D:
|
||||
ASSERT_SYS(ENOTDIR, -1, open("fun", O_CREAT | O_WRONLY | O_DIRECTORY, 0644));
|
||||
ASSERT_TRUE(fileexists("fun"));
|
||||
}
|
||||
|
||||
TEST(open, O_DIRECTORY_preventsOpeningRegularFiles) {
|
||||
ASSERT_SYS(0, 0, touch("file", 0644));
|
||||
ASSERT_SYS(ENOTDIR, -1, open("file", O_WRONLY | O_DIRECTORY));
|
||||
}
|
||||
|
||||
TEST(open, O_DIRECTORY_isNotARequirementToOpenDirectory) {
|
||||
ASSERT_SYS(0, 0, mkdir("dir", 0755));
|
||||
ASSERT_SYS(0, 3, open("dir", O_RDONLY));
|
||||
ASSERT_SYS(0, 0, close(3));
|
||||
}
|
||||
|
||||
TEST(open, openExistingDirectoryForWriting_raisesError) {
|
||||
ASSERT_SYS(0, 0, mkdir("dir", 0755));
|
||||
ASSERT_SYS(EISDIR, -1, open("dir", O_WRONLY));
|
||||
}
|
||||
|
||||
TEST(open, nameWithControlCode) {
|
||||
if (IsWindows()) {
|
||||
ASSERT_SYS(EINVAL, -1, touch("hi\1there", 0755));
|
||||
} else {
|
||||
ASSERT_SYS(0, 0, touch("hi\1there", 0755));
|
||||
}
|
||||
}
|
||||
|
||||
TEST(open, nameWithOverlongNul_doesntCreateTruncatedName) {
|
||||
if (IsXnu() || IsWindows()) {
|
||||
// XNU is the only one that thought to restrict this. XNU chose
|
||||
// EILSEQ which makes the most sense. Linux says it'll raise EINVAL
|
||||
// if invalid characters are detected. Not sure yet which characters
|
||||
// those are. POSIX says nothing about invalid charaters in open.
|
||||
ASSERT_SYS(EILSEQ, -1, touch("hi\300\200there", 0755));
|
||||
} else {
|
||||
ASSERT_SYS(0, 0, touch("hi\300\200there", 0755));
|
||||
ASSERT_TRUE(fileexists("hi\300\200there"));
|
||||
ASSERT_FALSE(fileexists("hi"));
|
||||
}
|
||||
}
|
||||
|
||||
int CountFds(void) {
|
||||
int i, count;
|
||||
for (count = i = 0; i < g_fds.n; ++i) {
|
||||
|
|
@ -154,3 +303,18 @@ TEST(open, lotsOfFds) {
|
|||
EXPECT_SYS(0, 0, close(i));
|
||||
}
|
||||
}
|
||||
|
||||
static int64_t GetInode(const char *path) {
|
||||
struct stat st;
|
||||
ASSERT_SYS(0, 0, stat(path, &st));
|
||||
return st.st_ino;
|
||||
}
|
||||
|
||||
TEST(open, drive) {
|
||||
if (!IsWindows()) return;
|
||||
ASSERT_NE(GetInode("/"), GetInode("."));
|
||||
ASSERT_EQ(GetInode("/"), GetInode("/c")); // sorry you have to run on c:/
|
||||
ASSERT_EQ(GetInode("/"), GetInode("/c/"));
|
||||
ASSERT_SYS(0, 3, open("/", O_RDONLY));
|
||||
ASSERT_SYS(0, 0, close(3));
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue