mirrors/cosmopolitan
1
0
Fork 0
mirror of https://github.com/jart/cosmopolitan.git synced 2025-05-23 05:42:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

[metal] Some minor fixes and tweaks (#933)

Browse source 
* [metal] Ensure DF is clear when calling C from exception handler
* [metal] Mark some internal routines and declarations as `@internal`
* [metal] Fix crash under UEFI when command line string is NULL
* [metal] Fix argc & argv[] setting, & VM page freeing, for UEFI

Part of the memory occupied by the argv[] contents was
erroneously used for page tables & then later erroneously
freed.  The symptom was that argv[0] would show up as an
empty string ("").
This commit is contained in:
tkchia 2023-11-15 07:26:59 +08:00 • committed by GitHub
parent 1c2e7c1333
commit eea601f346
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 76 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

12
libc/intrin/mman.greg.c
View file

@ -59,6 +59,7 @@ struct ReclaimedPage {
};
/**
* @internal
* Allocates new page of physical memory.
*/
texthead uint64_t __new_page(struct mman *mm) {
@ -85,6 +86,7 @@ texthead uint64_t __new_page(struct mman *mm) {
}
/**
* @internal
* Returns pointer to page table entry for page at virtual address.
* Additional page tables are allocated if needed as a side-effect.
*/
@ -106,6 +108,7 @@ textreal uint64_t *__get_virtual(struct mman *mm, uint64_t *t, int64_t vaddr,
}
/**
* @internal
* Sorts, rounds, and filters BIOS memory map.
*/
static textreal void __normalize_e820(struct mman *mm, uint64_t top) {
@ -139,6 +142,7 @@ static textreal void __normalize_e820(struct mman *mm, uint64_t top) {
}
/**
* @internal
* Identity maps an area of physical memory to its negative address.
*/
textreal uint64_t *__invert_memory_area(struct mman *mm, uint64_t *pml4t,
@ -157,6 +161,7 @@ textreal uint64_t *__invert_memory_area(struct mman *mm, uint64_t *pml4t,
}
/**
* @internal
* Increments the reference count for a page of physical memory.
*/
void __ref_page(struct mman *mm, uint64_t *pml4t, uint64_t p) {
@ -172,6 +177,7 @@ void __ref_page(struct mman *mm, uint64_t *pml4t, uint64_t p) {
}
/**
* @internal
* Increments the reference counts for an area of physical memory.
*/
void __ref_pages(struct mman *mm, uint64_t *pml4t, uint64_t ps, uint64_t size) {
@ -183,6 +189,7 @@ void __ref_pages(struct mman *mm, uint64_t *pml4t, uint64_t ps, uint64_t size) {
}
/**
* @internal
* Reclaims a page of physical memory for later use.
*/
static void __reclaim_page(struct mman *mm, uint64_t p) {
@ -193,6 +200,7 @@ static void __reclaim_page(struct mman *mm, uint64_t p) {
}
/**
* @internal
* Decrements the reference count for a page of physical memory. Frees the
* page if there are no virtual addresses (excluding the negative space)
* referring to it.
@ -211,6 +219,7 @@ void __unref_page(struct mman *mm, uint64_t *pml4t, uint64_t p) {
}
/**
* @internal
* Identity maps all usable physical memory to its negative address.
*/
static textreal void __invert_memory(struct mman *mm, uint64_t *pml4t) {
@ -224,6 +233,7 @@ static textreal void __invert_memory(struct mman *mm, uint64_t *pml4t) {
}
/**
* @internal
* Exports information about the offset of a field within a structure type,
* so that assembly language routines can use it. This macro can be invoked
* from inside a function whose code is known to be emitted.
@ -284,6 +294,7 @@ static textreal uint64_t __map_phdr(struct mman *mm, uint64_t *pml4t,
}
/**
* @internal
* Maps APE-defined ELF program headers into memory and clears BSS.
*/
textreal void __map_phdrs(struct mman *mm, uint64_t *pml4t, uint64_t b,
@ -315,6 +326,7 @@ textreal void __map_phdrs(struct mman *mm, uint64_t *pml4t, uint64_t b,
}
/**
* @internal
* Reclaims memory pages which were used at boot time but which can now be
* made available for the application.
*/