Make improvements

- Invent openatemp() API
- Invent O_UNLINK open flag
- Introduce getenv_secure() API
- Remove `git pull` from cosmocc
- Fix utimes() when path is NULL
- Fix mktemp() to never return NULL
- Fix utimensat() UTIME_OMIT on XNU
- Improve utimensat() code for RHEL5
- Turn `argv[0]` C:/ to /C/ on Windows
- Introduce tmpnam() and tmpnam_r() APIs
- Fix more const issues with internal APIs
- Permit utimes() on WIN32 in O_RDONLY mode
- Fix fdopendir() to check fd is a directory
- Fix recent crash regression in landlock make
- Fix futimens(AT_FDCWD, NULL) to return EBADF
- Use workaround so `make -j` doesn't fork bomb
- Rename dontdiscard to __wur (just like glibc)
- Fix st_size for WIN32 symlinks containing UTF-8
- Introduce stdio ext APIs needed by GNU coreutils
- Fix lstat() on WIN32 for symlinks to directories
- Move some constants from normalize.inc to limits.h
- Fix segv with memchr() and memcmp() overlapping page
- Implement POSIX fflush() behavior for reader streams
- Implement AT_SYMLINK_NOFOLLOW for utimensat() on WIN32
- Don't change read-only status of existing files on WIN32
- Correctly handle `0x[^[:xdigit:]]` case in strtol() functions

libc/calls/utimensat-sysv.c

@@ -16,39 +16,37 @@
 │ TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR             │
 │ PERFORMANCE OF THIS SOFTWARE.                                                │
 ╚─────────────────────────────────────────────────────────────────────────────*/
+#include "libc/assert.h"
 #include "libc/calls/struct/timespec.internal.h"
 #include "libc/calls/struct/timeval.internal.h"
 #include "libc/dce.h"
 #include "libc/errno.h"
 #include "libc/fmt/conv.h"
+#include "libc/runtime/zipos.internal.h"
 #include "libc/sysv/consts/at.h"
 #include "libc/time/time.h"
-#include "libc/runtime/zipos.internal.h"
 
 int sys_utimensat(int dirfd, const char *path, const struct timespec ts[2],
                   int flags) {
   int rc, olderr;
   struct timeval tv[2];
-  if (!IsXnu()) {
-    if (!path && (IsFreebsd() || IsNetbsd() || IsOpenbsd())) {
-      rc = sys_futimens(dirfd, ts);
-    } else {
-      olderr = errno;
-      rc = __sys_utimensat(dirfd, path, ts, flags);
-      // TODO(jart): How does RHEL5 do futimes()?
-      if (rc == -1 && errno == ENOSYS && path) {
-        errno = olderr;
-        if (ts) {
-          tv[0] = timespec_totimeval(ts[0]);
-          tv[1] = timespec_totimeval(ts[1]);
-          rc = sys_utimes(path, tv);
-        } else {
-          rc = sys_utimes(path, NULL);
-        }
+  unassert(!IsWindows() && !IsXnu());
+  if (!path && (IsFreebsd() || IsNetbsd() || IsOpenbsd())) {
+    rc = sys_futimens(dirfd, ts);
+  } else {
+    olderr = errno;
+    rc = __sys_utimensat(dirfd, path, ts, flags);
+    // TODO(jart): How does RHEL5 do futimes()?
+    if (rc == -1 && errno == ENOSYS && path) {
+      errno = olderr;
+      if (ts) {
+        tv[0] = timespec_totimeval(ts[0]);
+        tv[1] = timespec_totimeval(ts[1]);
+        rc = sys_utimes(path, tv);
+      } else {
+        rc = sys_utimes(path, NULL);
       }
     }
-    return rc;
-  } else {
-    return sys_utimensat_xnu(dirfd, path, ts, flags);
   }
+  return rc;
 }