Make improvements

- Invent openatemp() API
- Invent O_UNLINK open flag
- Introduce getenv_secure() API
- Remove `git pull` from cosmocc
- Fix utimes() when path is NULL
- Fix mktemp() to never return NULL
- Fix utimensat() UTIME_OMIT on XNU
- Improve utimensat() code for RHEL5
- Turn `argv[0]` C:/ to /C/ on Windows
- Introduce tmpnam() and tmpnam_r() APIs
- Fix more const issues with internal APIs
- Permit utimes() on WIN32 in O_RDONLY mode
- Fix fdopendir() to check fd is a directory
- Fix recent crash regression in landlock make
- Fix futimens(AT_FDCWD, NULL) to return EBADF
- Use workaround so `make -j` doesn't fork bomb
- Rename dontdiscard to __wur (just like glibc)
- Fix st_size for WIN32 symlinks containing UTF-8
- Introduce stdio ext APIs needed by GNU coreutils
- Fix lstat() on WIN32 for symlinks to directories
- Move some constants from normalize.inc to limits.h
- Fix segv with memchr() and memcmp() overlapping page
- Implement POSIX fflush() behavior for reader streams
- Implement AT_SYMLINK_NOFOLLOW for utimensat() on WIN32
- Don't change read-only status of existing files on WIN32
- Correctly handle `0x[^[:xdigit:]]` case in strtol() functions

libc/calls/utimensat.c

@@ -16,17 +16,10 @@
 │ TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR             │
 │ PERFORMANCE OF THIS SOFTWARE.                                                │
 ╚─────────────────────────────────────────────────────────────────────────────*/
-#include "libc/calls/asan.internal.h"
-#include "libc/calls/calls.h"
-#include "libc/calls/internal.h"
+#include "libc/calls/struct/timespec.h"
 #include "libc/calls/struct/timespec.internal.h"
-#include "libc/dce.h"
-#include "libc/intrin/asan.internal.h"
 #include "libc/intrin/describeflags.internal.h"
 #include "libc/intrin/strace.internal.h"
-#include "libc/intrin/weaken.h"
-#include "libc/runtime/zipos.internal.h"
-#include "libc/sysv/consts/at.h"
 #include "libc/sysv/errfuns.h"
 
 /**
@@ -43,9 +36,10 @@
  * @param dirfd can be `AT_FDCWD` or an open directory
  * @param path is filename whose timestamps should be modified
  * @param ts is {access, modified} timestamps, or null for current time
- * @param flags can have `AT_SYMLINK_NOFOLLOW` when `path` is specified
+ * @param flags can have `AT_SYMLINK_NOFOLLOW`
  * @return 0 on success, or -1 w/ errno
  * @raise EINVAL if `flags` had an unrecognized value
+ * @raise EINVAL on XNU or RHEL5 when any `flags` are used
  * @raise EPERM if pledge() is in play without `fattr` promise
  * @raise EACCES if unveil() is in play and `path` isn't unveiled
  * @raise EINVAL if `ts` specifies a nanosecond value that's out of range
@@ -54,23 +48,21 @@
  * @raise EBADF if `dirfd` isn't a valid fd or `AT_FDCWD`
  * @raise EFAULT if `path` or `ts` memory was invalid
  * @raise EROFS if `path` is on read-only filesystem (e.g. zipos)
- * @raise ENOSYS on bare metal or on rhel5 when `dirfd` or `flags` is used
+ * @raise ENOTSUP on XNU or RHEL5 when `dirfd` isn't `AT_FDCWD`
+ * @raise ENOSYS on bare metal
  * @asyncsignalsafe
  * @threadsafe
  */
 int utimensat(int dirfd, const char *path, const struct timespec ts[2],
               int flags) {
   int rc;
-
   if (!path) {
     rc = efault();  // linux kernel abi behavior isn't supported
   } else {
     rc = __utimens(dirfd, path, ts, flags);
   }
-
   STRACE("utimensat(%s, %#s, {%s, %s}, %#o) → %d% m", DescribeDirfd(dirfd),
          path, DescribeTimespec(0, ts), DescribeTimespec(0, ts ? ts + 1 : 0),
          flags, rc);
-
   return rc;
 }