mirror of
https://github.com/jart/cosmopolitan.git
synced 2025-02-01 20:13:31 +00:00
85f64f3851
Thanks to @autumnjolitz (in #876) the Cosmopolitan codebase is now acquainted with Apple's outstanding ulock system calls which offer something much closer to futexes than Grand Central Dispatch which wasn't quite as good, since its wait function can't be interrupted by signals (therefore necessitating a busy loop) and it also needs semaphore objects to be created and freed. Even though ulock is an internal Apple API, strictly speaking, the benefits of futexes are so great that it's worth the risk for now especially since we have the GCD implementation still as a quick escape hatch if it changes Here's why this change is important for x86 XNU users. Cosmo has a suboptimal polyfill when the operating system doesn't offer an API that let's us implement futexes properly. Sadly we had to use that on X86 XNU until now. The polyfill works using clock_nanosleep, to poll the futex in a busy loop with exponential backoff. On XNU x86 clock_nanosleep suffers from us not being able to use a fast clock gettime implementation, which had a compounding effect that's made the polyfill function even more poorly. On X86 XNU we also need to polyfill sched_yield() using select(), which made things even more troublesome. Now that we have futexes we don't have any busy loops anymore for both condition variables and thread joining so optimal performance is attained. To demonstrate, consider these benchmarks Before: $ ./lockscale_test.com -b consumed 38.8377 seconds real time and 0.087131 seconds cpu time After: $ ./lockscale_test.com -b consumed 0.007955 seconds real time and 0.011515 seconds cpu time Fixes #876
128 lines
5.9 KiB
C
128 lines
5.9 KiB
C
/*-*- mode:c;indent-tabs-mode:nil;c-basic-offset:2;tab-width:8;coding:utf-8 -*-│
|
|
│vi: set net ft=c ts=2 sts=2 sw=2 fenc=utf-8 :vi│
|
|
╞══════════════════════════════════════════════════════════════════════════════╡
|
|
│ Copyright 2022 Justine Alexandra Roberts Tunney │
|
|
│ │
|
|
│ Permission to use, copy, modify, and/or distribute this software for │
|
|
│ any purpose with or without fee is hereby granted, provided that the │
|
|
│ above copyright notice and this permission notice appear in all copies. │
|
|
│ │
|
|
│ THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL │
|
|
│ WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED │
|
|
│ WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE │
|
|
│ AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL │
|
|
│ DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR │
|
|
│ PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER │
|
|
│ TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR │
|
|
│ PERFORMANCE OF THIS SOFTWARE. │
|
|
╚─────────────────────────────────────────────────────────────────────────────*/
|
|
#include "libc/assert.h"
|
|
#include "libc/calls/cp.internal.h"
|
|
#include "libc/calls/struct/timespec.h"
|
|
#include "libc/calls/struct/timespec.internal.h"
|
|
#include "libc/errno.h"
|
|
#include "libc/fmt/itoa.h"
|
|
#include "libc/intrin/atomic.h"
|
|
#include "libc/intrin/describeflags.internal.h"
|
|
#include "libc/intrin/dll.h"
|
|
#include "libc/intrin/strace.internal.h"
|
|
#include "libc/thread/posixthread.internal.h"
|
|
#include "libc/thread/thread2.h"
|
|
#include "libc/thread/tls.h"
|
|
#include "third_party/nsync/futex.internal.h"
|
|
|
|
// TODO(jart): Use condition variable for thread waiting.
|
|
|
|
static const char *DescribeReturnValue(char buf[30], int err, void **value) {
|
|
char *p = buf;
|
|
if (!value) return "NULL";
|
|
if (err) return "[n/a]";
|
|
*p++ = '[';
|
|
p = FormatHex64(p, (uintptr_t)*value, 1);
|
|
*p++ = ']';
|
|
return buf;
|
|
}
|
|
|
|
/**
|
|
* Blocks until memory location becomes zero.
|
|
*
|
|
* This is intended to be used on the child thread id, which is updated
|
|
* by the clone() system call when a thread terminates. We need this in
|
|
* order to know when it's safe to free a thread's stack. This function
|
|
* uses futexes on Linux, FreeBSD, OpenBSD, and Windows. On other
|
|
* platforms this uses polling with exponential backoff.
|
|
*
|
|
* @return 0 on success, or errno on error
|
|
* @raise ECANCELED if calling thread was cancelled in masked mode
|
|
* @raise EBUSY if `abstime` was specified and deadline expired
|
|
* @cancellationpoint
|
|
*/
|
|
static errno_t _pthread_wait(atomic_int *ctid, struct timespec *abstime) {
|
|
int x, e, rc = 0;
|
|
unassert(ctid != &__get_tls()->tib_tid);
|
|
// "If the thread calling pthread_join() is canceled, then the target
|
|
// thread shall not be detached." ──Quoth POSIX.1-2017
|
|
if (!(rc = pthread_testcancel_np())) {
|
|
BEGIN_CANCELLATION_POINT;
|
|
while ((x = atomic_load_explicit(ctid, memory_order_acquire))) {
|
|
e = nsync_futex_wait_(ctid, x, !IsWindows() && !IsXnu(), abstime);
|
|
if (e == -ECANCELED) {
|
|
rc = ECANCELED;
|
|
break;
|
|
} else if (e == -ETIMEDOUT) {
|
|
rc = EBUSY;
|
|
break;
|
|
}
|
|
}
|
|
END_CANCELLATION_POINT;
|
|
}
|
|
return rc;
|
|
}
|
|
|
|
/**
|
|
* Waits for thread to terminate.
|
|
*
|
|
* Multiple threads joining the same thread is undefined behavior. If a
|
|
* deferred or masked cancellation happens to the calling thread either
|
|
* before or during the waiting process then the target thread will not
|
|
* be joined. Calling pthread_join() on a non-joinable thread, e.g. one
|
|
* that's been detached, is undefined behavior. If a thread attempts to
|
|
* join itself, then the behavior is undefined.
|
|
*
|
|
* @param value_ptr if non-null will receive pthread_exit() argument
|
|
* if the thread called pthread_exit(), or `PTHREAD_CANCELED` if
|
|
* pthread_cancel() destroyed the thread instead
|
|
* @param abstime specifies an absolute deadline or the timestamp of
|
|
* when we'll stop waiting; if this is null we will wait forever
|
|
* @return 0 on success, or errno on error
|
|
* @raise ECANCELED if calling thread was cancelled in masked mode
|
|
* @raise EBUSY if `abstime` deadline elapsed
|
|
* @cancellationpoint
|
|
* @returnserrno
|
|
*/
|
|
errno_t pthread_timedjoin_np(pthread_t thread, void **value_ptr,
|
|
struct timespec *abstime) {
|
|
errno_t err;
|
|
struct PosixThread *pt;
|
|
enum PosixThreadStatus status;
|
|
pt = (struct PosixThread *)thread;
|
|
status = atomic_load_explicit(&pt->status, memory_order_acquire);
|
|
// "The behavior is undefined if the value specified by the thread
|
|
// argument to pthread_join() does not refer to a joinable thread."
|
|
// ──Quoth POSIX.1-2017
|
|
unassert(status == kPosixThreadJoinable || status == kPosixThreadTerminated);
|
|
if (!(err = _pthread_wait(&pt->tib->tib_tid, abstime))) {
|
|
pthread_spin_lock(&_pthread_lock);
|
|
dll_remove(&_pthread_list, &pt->list);
|
|
pthread_spin_unlock(&_pthread_lock);
|
|
if (value_ptr) {
|
|
*value_ptr = pt->rc;
|
|
}
|
|
_pthread_free(pt, false);
|
|
_pthread_decimate();
|
|
}
|
|
STRACE("pthread_timedjoin_np(%d, %s, %s) → %s", _pthread_tid(pt),
|
|
DescribeReturnValue(alloca(30), err, value_ptr),
|
|
DescribeTimespec(err ? -1 : 0, abstime), DescribeErrno(err));
|
|
return err;
|
|
}
|