mirror of
https://github.com/jart/cosmopolitan.git
synced 2025-01-31 03:27:39 +00:00
98c5847727
This change fixes a bug where nsync waiter objects would leak. It'd mean that long-running programs like runitd would run out of file descriptors on NetBSD where waiter objects have ksem file descriptors. On other OSes this bug is mostly harmless since the worst that can happen with a futex is to leak a little bit of ram. The bug was caused because tib_nsync was sneaking back in after the finalization code had cleared it. This change refactors the thread exiting code to handle nsync teardown appropriately and in making this change I found another issue, which is that user code which is buggy, and tries to exit without joining joinable threads which haven't been detached, would result in a deadlock. That doesn't sound so bad, except the main thread is a joinable thread. So this deadlock would be triggered in ways that put libc at fault. So we now auto-join threads and libc will log a warning to --strace when that happens for any thread
20 lines
924 B
C
Executable file
20 lines
924 B
C
Executable file
#ifndef COSMOPOLITAN_THIRD_PARTY_NSYNC_MU_SEMAPHORE_INTERNAL_H_
|
|
#define COSMOPOLITAN_THIRD_PARTY_NSYNC_MU_SEMAPHORE_INTERNAL_H_
|
|
#include "third_party/nsync/mu_semaphore.h"
|
|
#include "third_party/nsync/time.h"
|
|
COSMOPOLITAN_C_START_
|
|
|
|
bool nsync_mu_semaphore_init_futex(nsync_semaphore *);
|
|
void nsync_mu_semaphore_destroy_futex(nsync_semaphore *);
|
|
errno_t nsync_mu_semaphore_p_futex(nsync_semaphore *);
|
|
errno_t nsync_mu_semaphore_p_with_deadline_futex(nsync_semaphore *, int, nsync_time);
|
|
void nsync_mu_semaphore_v_futex(nsync_semaphore *);
|
|
|
|
bool nsync_mu_semaphore_init_sem(nsync_semaphore *);
|
|
void nsync_mu_semaphore_destroy_sem(nsync_semaphore *);
|
|
errno_t nsync_mu_semaphore_p_sem(nsync_semaphore *);
|
|
errno_t nsync_mu_semaphore_p_with_deadline_sem(nsync_semaphore *, int, nsync_time);
|
|
void nsync_mu_semaphore_v_sem(nsync_semaphore *);
|
|
|
|
COSMOPOLITAN_C_END_
|
|
#endif /* COSMOPOLITAN_THIRD_PARTY_NSYNC_MU_SEMAPHORE_INTERNAL_H_ */
|