mirrors/git-validation
1
0
Fork 0
mirror of https://github.com/vbatts/git-validation.git synced 2025-06-04 11:02:27 +00:00
Code Releases Activity

*.go: linting and adding lint to the checks done

Browse source 
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
This commit is contained in:
Vincent Batts 2023-03-14 22:11:02 -04:00
parent 6f5b21b58e
commit 21d1635d10
Signed by: vbatts
GPG key ID: 10937E57733F1362
5 changed files with 51 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
validate/rules.go
View file

@ -75,7 +75,6 @@ func SanitizeFilters(filtStr string) (filters []string) {
//
// Some `includes` rules have values assigned to them.
// i.e. -run "dco,message_regexp='^JIRA-[0-9]+ [A-Z].*$'"
//
func FilterRules(rules []Rule, includes []string) []Rule {
ret := []Rule{}
@ -83,7 +82,7 @@ func FilterRules(rules []Rule, includes []string) []Rule {
for i := range includes {
if strings.Contains(includes[i], "=") {
chunks := strings.SplitN(includes[i], "=", 2)
if strings.ToLower(r.Name) == strings.ToLower(chunks[0]) {
if strings.EqualFold(r.Name, chunks[0]) {
// for these rules, the Name won't be unique per se. There may be
// multiple "regexp=" with different values. We'll need to set the
// .Value = chunk[1] and ensure r is dup'ed so they don't clobber
@ -93,7 +92,7 @@ func FilterRules(rules []Rule, includes []string) []Rule {
ret = append(ret, newR)
}
} else {
if strings.ToLower(r.Name) == strings.ToLower(includes[i]) {
if strings.EqualFold(r.Name, includes[i]) {
ret = append(ret, r)
}
}

13
validate/runner.go
View file

@ -5,6 +5,7 @@ import (
"os"
"path/filepath"
"github.com/sirupsen/logrus"
"github.com/vbatts/git-validation/git"
)
@ -29,7 +30,11 @@ func NewRunner(root string, rules []Rule, commitrange string, verbose bool) (*Ru
if err != nil {
return nil, err
}
defer os.Chdir(cwd)
defer func() {
if err := os.Chdir(cwd); err != nil {
logrus.Warnf("changing working directory to %q failed: %s", cwd, err)
}
}()
if err := os.Chdir(newroot); err != nil {
return nil, err
@ -56,7 +61,11 @@ func (r *Runner) Run() error {
if err != nil {
return err
}
defer os.Chdir(cwd)
defer func() {
if err := os.Chdir(cwd); err != nil {
logrus.Warnf("changing working directory to %q failed: %s", cwd, err)
}
}()
if err := os.Chdir(r.Root); err != nil {
return err