mirrors/git-validation
1
0
Fork 0
mirror of https://github.com/vbatts/git-validation.git synced 2024-11-23 00:25:41 +00:00
Code Releases Activity

Consider only commit IDs when listing range

Browse source 
When using `git log`, if some/all commits are gpg-signed, git will
automatically try to validate the signatures by default.  This results
in printing additional text.  This additional gpg-validation text is
then incorrectly interpreted by `git-validate` as if they were commit
IDs.  Fix the problem by using the `rev-list` sub-command which will
ONLY list the IDs.

Signed-off-by: Chris Evich <cevich@redhat.com>
This commit is contained in:
Chris Evich 2020-09-16 11:41:22 -04:00
parent 91e5ebf160
commit 3c71df2bd9
No known key found for this signature in database
GPG key ID: 03EDC70FD578067F
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
git/commits.go
View file

@ -15,7 +15,7 @@ import (
// If commitrange is a single commit, all ancestor commits up through the hash provided. // If commitrange is a single commit, all ancestor commits up through the hash provided.
// If commitrange is an empty commit range, then nil is returned. // If commitrange is an empty commit range, then nil is returned.
func Commits(commitrange string) ([]CommitEntry, error) { func Commits(commitrange string) ([]CommitEntry, error) {
cmdArgs := []string{"git", "--no-pager", "log", `--pretty=format:%H`, commitrange} cmdArgs := []string{"git", "rev-list", commitrange}
if debug() { if debug() {
logrus.Infof("[git] cmd: %q", strings.Join(cmdArgs, " ")) logrus.Infof("[git] cmd: %q", strings.Join(cmdArgs, " "))
} }