mirrors/git-validation
1
0
Fork 0
mirror of https://github.com/vbatts/git-validation.git synced 2024-12-28 08:16:31 +00:00
Code Releases Activity

git/commits: Log failed Git commands

Browse source 
Before this commit:

  $ ./git-validation -run DCO -range HEAD^^..foo
  2017/03/21 13:00:30 exit status 128

With this commit:

  $ ./git-validation -run DCO -range HEAD^^..foo
  ERRO[0000] [git] cmd: "git --no-pager log --no-merges --pretty=format:%H HEAD^^..foo"
  2017/03/21 13:16:43 exit status 128

You can get similar output with -D, but folks are unlikely to set that
in production.  With the new error logs, Travis output and similar is
more likely to contain some useful information.

Signed-off-by: W. Trevor King <wking@tremily.us>
This commit is contained in:
W. Trevor King 2017-03-21 13:17:56 -07:00
parent 9b7297d813
commit 5e1b04597c
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
git/commits.go
View file

@ -18,6 +18,7 @@ func Commits(commitrange string) ([]CommitEntry, error) {
} }
output, err := exec.Command(cmdArgs[0], cmdArgs[1:]...).Output() output, err := exec.Command(cmdArgs[0], cmdArgs[1:]...).Output()
if err != nil { if err != nil {
logrus.Errorf("mm[git] cmd: %q", strings.Join(cmdArgs, " "))
return nil, err return nil, err
} }
commitHashes := strings.Split(strings.TrimSpace(string(output)), "\n") commitHashes := strings.Split(strings.TrimSpace(string(output)), "\n")
@ -95,6 +96,7 @@ func LogCommit(commit string) (*CommitEntry, error) {
cmd.Stderr = os.Stderr cmd.Stderr = os.Stderr
out, err := cmd.Output() out, err := cmd.Output()
if err != nil { if err != nil {
logrus.Errorf("[git] cmd: %q", strings.Join(cmd.Args, " "))
return nil, err return nil, err
} }
c[v] = strings.TrimSpace(string(out)) c[v] = strings.TrimSpace(string(out))
@ -115,6 +117,7 @@ func FetchHeadCommit() (string, error) {
} }
output, err := exec.Command(cmdArgs[0], cmdArgs[1:]...).Output() output, err := exec.Command(cmdArgs[0], cmdArgs[1:]...).Output()
if err != nil { if err != nil {
logrus.Errorf("[git] cmd: %q", strings.Join(cmdArgs, " "))
return "", err return "", err
} }
return strings.TrimSpace(string(output)), nil return strings.TrimSpace(string(output)), nil
@ -128,6 +131,7 @@ func HeadCommit() (string, error) {
} }
output, err := exec.Command(cmdArgs[0], cmdArgs[1:]...).Output() output, err := exec.Command(cmdArgs[0], cmdArgs[1:]...).Output()
if err != nil { if err != nil {
logrus.Errorf("[git] cmd: %q", strings.Join(cmdArgs, " "))
return "", err return "", err
} }
return strings.TrimSpace(string(output)), nil return strings.TrimSpace(string(output)), nil