Commit Graph

16 Commits

Author SHA1 Message Date
Phil Estes c36adca155
Update travis to supported Go versions
Remove unsupported/old Golang versions from Travis run.

Signed-off-by: Phil Estes <estesp@vnet.linux.ibm.com>
2020-03-26 23:23:26 -04:00
Vincent Batts c95946fd0c
travis: drop go1.7 and go1.8 due to golang.org/x/sys
Ref: https://github.com/vbatts/git-validation/pull/43#issuecomment-530467954

golang.org/x/sys as of fde4db37ae7ad8191b03d30d27f258b5291ae4e3 uses
`math/bits`, so it does not support go1.7 and go1.8
I could set that in the go.mod, but those old versions do not support
that. I could ./vendor/ but perhaps no one is even using this tool on
these old golang versions. Choices. choices.

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2019-09-11 12:54:50 -04:00
Vincent Batts 099c80c66f
travis: version conditional golint
Since golint has changed url, and older go can't even install it, it
requires some silliness to install and only check when it's the newer
go1.11

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2018-10-31 14:14:07 -04:00
golint fixer a0a8b28611
Fix golint import path
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2018-10-26 10:09:09 -04:00
Vincent Batts 9c912afea5 Merge pull request #23 from vbatts/travis
travis: test on latest go branches
2017-04-27 14:13:27 -04:00
Vincent Batts 5a672d8f1c Merge pull request #28 from wking/golint-exit-status
.travis.yml: Add '-set_exit_status' to golint invocation
2017-04-27 14:08:32 -04:00
Vincent Batts 032c0d21e9
travis: test on latest go branches
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2017-04-27 14:05:44 -04:00
Vincent Batts 56ef622e37
travis: only run the git-validation on pull-requests
Fixes #24

https://docs.travis-ci.com/user/pull-requests/

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2017-04-27 13:59:55 -04:00
W. Trevor King b4e2a474d1 .travis.yml: Add '-set_exit_status' to golint invocation
So Travis tells us when golint finds something suspicious.

Signed-off-by: W. Trevor King <wking@tremily.us>
2017-04-27 10:20:21 -07:00
Vincent Batts 4cee76b1df Merge pull request #17 from wking/test-merges-again
Test merges again and return to using TRAVIS_COMMIT_RANGE
2017-03-21 17:58:56 -04:00
W. Trevor King 2e3c157f4b .travis.yml: Dogfood git-validation
This makes it easier to test the script and avoids leaking dangling
whitespace, etc. into the repo.

Signed-off-by: W. Trevor King <wking@tremily.us>
2017-03-21 12:27:53 -07:00
W. Trevor King cdd7165f80 main: Return to using TRAVIS_COMMIT_RANGE (with ... -> .. fix)
Master builds only have a 'git clone ...' [1] so FETCH_HEAD isn't
defined and git-validation crashes [2].  This commit partially reverts
8a12a8fc (main: default travis commit range is unreliable, 2017-03-21,
#13) to avoid that crash.  If TRAVIS_COMMIT_RANGE is unset [3],
falling back to TRAVIS_COMMIT may be fine.

The ... -> .. replacement works around travis-ci/travis-ci#4596 until
that is fixed upstream [4].  This avoids pulling in commits from the
base tip that aren't reachable from the head tip (e.g. if master has
advanced since the PR branched off, and the PR is against master).  We
only want to check commits that are in the head branch but not in the
base branch (more details on the range syntax in [5]).

Once the Travis bug does get fixed, the shell replacement will be a
no-op.  So we don't have to worry about checks breaking once the bug
gets fixed, and can periodically poll the bug and remove the
workaround at out leisure after the fix.

[1]: https://travis-ci.org/opencontainers/runc/jobs/213508696#L243
[2]: https://travis-ci.org/opencontainers/runc/jobs/213508696#L347
[3]: https://github.com/opencontainers/runc/pull/1378#issuecomment-287903471
[4]: https://github.com/travis-ci/travis-ci/issues/4596
[5]: http://git-scm.com/docs/gitrevisions#_specifying_ranges

Signed-off-by: W. Trevor King <wking@tremily.us>
2017-03-21 12:16:01 -07:00
Vincent Batts 8a12a8fc7a
main: default travis commit range is unreliable
https://github.com/opencontainers/runc/pull/1378#issuecomment-287920287
points to an alternate approach.

Reported-by: Mrunal Patel <mrunalp@gmail.com>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2017-03-21 09:41:59 -04:00
Vincent Batts e0bc736c1c
travis: bump the golang versions
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2017-01-27 09:30:21 -05:00
Vincent Batts 00bb98c063 travis: no need to get go vet
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2016-05-03 15:17:15 -04:00
Vincent Batts e3ba588c3a travis: adding checks for basic regressions
* go vet
* golint
* whether the tool builds
* tests (there are none yet)

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2016-04-05 15:28:38 -04:00