1
0
Fork 0
mirror of https://github.com/vbatts/git-validation.git synced 2024-11-26 10:05:40 +00:00
Commit graph

8 commits

Author SHA1 Message Date
W. Trevor King
b4e2a474d1 .travis.yml: Add '-set_exit_status' to golint invocation
So Travis tells us when golint finds something suspicious.

Signed-off-by: W. Trevor King <wking@tremily.us>
2017-04-27 10:20:21 -07:00
4cee76b1df Merge pull request #17 from wking/test-merges-again
Test merges again and return to using TRAVIS_COMMIT_RANGE
2017-03-21 17:58:56 -04:00
W. Trevor King
2e3c157f4b .travis.yml: Dogfood git-validation
This makes it easier to test the script and avoids leaking dangling
whitespace, etc. into the repo.

Signed-off-by: W. Trevor King <wking@tremily.us>
2017-03-21 12:27:53 -07:00
W. Trevor King
cdd7165f80 main: Return to using TRAVIS_COMMIT_RANGE (with ... -> .. fix)
Master builds only have a 'git clone ...' [1] so FETCH_HEAD isn't
defined and git-validation crashes [2].  This commit partially reverts
8a12a8fc (main: default travis commit range is unreliable, 2017-03-21,
#13) to avoid that crash.  If TRAVIS_COMMIT_RANGE is unset [3],
falling back to TRAVIS_COMMIT may be fine.

The ... -> .. replacement works around travis-ci/travis-ci#4596 until
that is fixed upstream [4].  This avoids pulling in commits from the
base tip that aren't reachable from the head tip (e.g. if master has
advanced since the PR branched off, and the PR is against master).  We
only want to check commits that are in the head branch but not in the
base branch (more details on the range syntax in [5]).

Once the Travis bug does get fixed, the shell replacement will be a
no-op.  So we don't have to worry about checks breaking once the bug
gets fixed, and can periodically poll the bug and remove the
workaround at out leisure after the fix.

[1]: https://travis-ci.org/opencontainers/runc/jobs/213508696#L243
[2]: https://travis-ci.org/opencontainers/runc/jobs/213508696#L347
[3]: https://github.com/opencontainers/runc/pull/1378#issuecomment-287903471
[4]: https://github.com/travis-ci/travis-ci/issues/4596
[5]: http://git-scm.com/docs/gitrevisions#_specifying_ranges

Signed-off-by: W. Trevor King <wking@tremily.us>
2017-03-21 12:16:01 -07:00
8a12a8fc7a
main: default travis commit range is unreliable
https://github.com/opencontainers/runc/pull/1378#issuecomment-287920287
points to an alternate approach.

Reported-by: Mrunal Patel <mrunalp@gmail.com>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2017-03-21 09:41:59 -04:00
e0bc736c1c
travis: bump the golang versions
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2017-01-27 09:30:21 -05:00
00bb98c063 travis: no need to get go vet
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2016-05-03 15:17:15 -04:00
e3ba588c3a travis: adding checks for basic regressions
* go vet
* golint
* whether the tool builds
* tests (there are none yet)

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2016-04-05 15:28:38 -04:00