mirrors/go-mtree
1
0
Fork 0
mirror of https://github.com/vbatts/go-mtree.git synced 2025-10-04 12:31:00 +00:00
Code Releases Activity

test: migrate most tests to testify

Browse source 
testify makes most bog-standard test checks much easier to read and
maintain, and is quite widely used. It wasn't really well known back
when go-mtree was first written, but the migration is fairly
straight-forward for most tests.

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
This commit is contained in:
Aleksa Sarai 2025-09-20 03:00:06 +10:00
parent f2b48a0e2f
commit 3252a4ad82
No known key found for this signature in database
GPG key ID: 2897FAD2B7E9446F
55 changed files with 22620 additions and 886 deletions
Download patch file Download diff file Expand all files Collapse all files

81
update_test.go
View file

@ -5,7 +5,6 @@ package mtree
import (
"container/heap"
"encoding/json"
"os"
"os/user"
"path/filepath"
@ -14,6 +13,8 @@ import (
"time"
"github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func init() {
@ -26,86 +27,50 @@ func TestUpdate(t *testing.T) {
dir := t.TempDir()
tmpfn := filepath.Join(dir, "tmpfile")
if err := os.WriteFile(tmpfn, content, 0666); err != nil {
t.Fatal(err)
}
require.NoError(t, os.WriteFile(tmpfn, content, 0666))
// Walk this tempdir
dh, err := Walk(dir, nil, append(DefaultKeywords, "sha1"), nil)
if err != nil {
t.Fatal(err)
}
require.NoErrorf(t, err, "walk %s", dir)
// Touch a file, so the mtime changes.
now := time.Now()
if err := os.Chtimes(tmpfn, now, now); err != nil {
t.Fatal(err)
}
if err := os.Chmod(tmpfn, os.FileMode(0600)); err != nil {
t.Fatal(err)
}
require.NoError(t, os.Chtimes(tmpfn, now, now))
require.NoError(t, os.Chmod(tmpfn, os.FileMode(0600)))
// Changing user is a little tough, but the group can be changed by a limited user to any group that the user is a member of. So just choose one that is not the current main group.
u, err := user.Current()
if err != nil {
t.Fatal(err)
}
require.NoError(t, err, "get current user")
ugroups, err := u.GroupIds()
if err != nil {
t.Fatal(err)
}
require.NoError(t, err, "get current user groups")
for _, ugroup := range ugroups {
if ugroup == u.Gid {
continue
}
gid, err := strconv.Atoi(ugroup)
if err != nil {
t.Fatal(ugroup)
}
if err := os.Lchown(tmpfn, -1, gid); err != nil {
t.Fatal(err)
}
require.NoErrorf(t, err, "parse group %q", ugroup)
require.NoError(t, os.Lchown(tmpfn, -1, gid))
}
// Check for sanity. This ought to have failures
res, err := Check(dir, dh, nil, nil)
if err != nil {
t.Fatal(err)
}
if len(res) == 0 {
t.Error("expected failures (like mtimes), but got none")
}
require.NoErrorf(t, err, "check %s", dir)
assert.NotEmpty(t, res, "should see mtime/chown/chtimes deltas from check")
//dh.WriteTo(os.Stdout)
res, err = Update(dir, dh, DefaultUpdateKeywords, nil)
if err != nil {
t.Error(err)
}
if len(res) > 0 {
// pretty this shit up
buf, err := json.MarshalIndent(res, "", " ")
if err != nil {
t.Errorf("%#v", res)
}
t.Error(string(buf))
require.NoErrorf(t, err, "update %d", err)
if !assert.Empty(t, res, "update implied check") {
pprintInodeDeltas(t, res)
}
// Now check that we're sane again
res, err = Check(dir, dh, nil, nil)
if err != nil {
t.Fatal(err)
require.NoErrorf(t, err, "update %s", dir)
if !assert.Empty(t, res, "post-update check") {
pprintInodeDeltas(t, res)
}
// should have no failures now
if len(res) > 0 {
// pretty this shit up
buf, err := json.MarshalIndent(res, "", " ")
if err != nil {
t.Errorf("%#v", res)
} else {
t.Error(string(buf))
}
}
}
func TestPathUpdateHeap(t *testing.T) {
@ -123,11 +88,7 @@ func TestPathUpdateHeap(t *testing.T) {
var p string
for h.Len() > 0 {
p = heap.Pop(h).(pathUpdate).Path
if len(p) > longest {
t.Errorf("expected next path to be shorter, but it was not %q is longer than %d", p, longest)
}
}
if p != "." {
t.Errorf("expected \".\" to be the last, but got %q", p)
assert.LessOrEqual(t, len(p), longest, "expected next path %q to be shorter", p)
}
assert.Equal(t, ".", p, ". should be the last path")
}