mirrors/go-mtree
1
0
Fork 0
mirror of https://github.com/vbatts/go-mtree.git synced 2025-07-04 06:38:30 +00:00
Code Releases Activity

keywords: safely encode symlink keywords

Browse source 
symlink(2) is a very dumb syscall, and allows you to put any damn value
you please inside a symlink. In addition, spaces are valid path
characters which causes issues with keyword parsing. So use Vis() and
Unvis() to safely store an encoded version of the path.

This also adds a cli test for this behaviour.

Signed-off-by: Aleksa Sarai <asarai@suse.de>
This commit is contained in:
Aleksa Sarai 2016-11-12 01:48:17 +11:00
parent 30ae0132eb
commit 704d91fc7c
No known key found for this signature in database
GPG key ID: 9E18AA267DDB8DB4
3 changed files with 39 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
keywords.go
View file

@ -297,7 +297,11 @@ var (
linkKeywordFunc = func(path string, info os.FileInfo, r io.Reader) (string, error) {
if sys, ok := info.Sys().(*tar.Header); ok {
if sys.Linkname != "" {
return fmt.Sprintf("link=%s", sys.Linkname), nil
linkname, err := Vis(sys.Linkname)
if err != nil {
return "", err
}
return fmt.Sprintf("link=%s", linkname), nil
}
return "", nil
}
@ -307,7 +311,11 @@ var (
if err != nil {
return "", err
}
return fmt.Sprintf("link=%s", str), nil
linkname, err := Vis(str)
if err != nil {
return "", err
}
return fmt.Sprintf("link=%s", linkname), nil
}
return "", nil
}