mirrors/go-mtree
1
0
Fork 0
mirror of https://github.com/vbatts/go-mtree.git synced 2025-10-09 22:18:24 +00:00
Code Releases Activity

govis: switch to testify tests

Browse source 
testify makes most bog-standard test checks much easier to read and
maintain, and is quite widely used. It wasn't really well known back
when govis was first written, but the migration is fairly
straight-forward for most tests.

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
This commit is contained in:
Aleksa Sarai 2025-09-20 06:08:34 +10:00
parent b0c7528ac6
commit d02f298ad4
No known key found for this signature in database
GPG key ID: 2897FAD2B7E9446F
4 changed files with 233 additions and 180 deletions
Download patch file Download diff file Expand all files Collapse all files

57
pkg/govis/vis_test.go
View file

@ -18,34 +18,37 @@
package govis
import (
"fmt"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestVisUnchanged(t *testing.T) {
for _, test := range []struct {
name string
input string
flag VisFlag
}{
{"", DefaultVisFlags},
{"helloworld", DefaultVisFlags},
{"THIS_IS_A_TEST1234", DefaultVisFlags},
{"SomeEncodingsAreCool", DefaultVisFlags},
{"spaces are totally safe", DefaultVisFlags &^ VisSpace},
{"tabs\tare\talso\tsafe!!", DefaultVisFlags &^ VisTab},
{"just\a\atrustme\r\b\b!!", DefaultVisFlags | VisSafe},
{"Empty", "", DefaultVisFlags},
{"Plain1", "helloworld", DefaultVisFlags},
{"Plain2", "THIS_IS_A_TEST1234", DefaultVisFlags},
{"Plain3", "SomeEncodingsAreCool", DefaultVisFlags},
{"Spaces", "spaces are totally safe", DefaultVisFlags &^ VisSpace},
{"Tabs", "tabs\tare\talso\tsafe!!", DefaultVisFlags &^ VisTab},
{"BasicCtrlChars", "just\a\atrustme\r\b\b!!", DefaultVisFlags | VisSafe},
} {
enc, err := Vis(test.input, test.flag)
if err != nil {
t.Errorf("unexpected error with %q: %s", test, err)
}
if enc != test.input {
t.Errorf("expected encoding of %q (flag=%q) to be unchanged, got %q", test.input, test.flag, enc)
}
t.Run(test.name, func(t *testing.T) {
enc, err := Vis(test.input, test.flag)
require.NoErrorf(t, err, "vis(%q, %s)", test.input, test.flag)
assert.Equalf(t, test.input, enc, "encoding of vis(%q, %s) should be unchanged", test.input, test.flag)
})
}
}
func TestVisFlags(t *testing.T) {
for _, test := range []struct {
for idx, test := range []struct {
input string
output string
flag VisFlag
@ -100,13 +103,11 @@ func TestVisFlags(t *testing.T) {
{"'3Ze\u050e|\u02del\u069du-Rpct4+Z5b={@_{b", `'3Ze\M-T\M^N|\M-K\M^^l\M-Z\M^]u-Rpct4+Z5b={@_{b`, VisGlob},
{"'3Ze\u050e|\u02del\u069du-Rpct4+Z5b={@_{b", `'3Ze\324\216|\313\236l\332\235u-Rpct4+Z5b={@_{b`, VisGlob | VisOctal},
} {
enc, err := Vis(test.input, test.flag)
if err != nil {
t.Errorf("unexpected error with %q: %s", test, err)
}
if enc != test.output {
t.Errorf("expected vis(%q, flag=%b) = %q, got %q", test.input, test.flag, test.output, enc)
}
t.Run(fmt.Sprintf("Test%.2d", idx), func(t *testing.T) {
enc, err := Vis(test.input, test.flag)
require.NoErrorf(t, err, "vis(%q, %s)", test.input, test.flag)
assert.Equalf(t, test.output, enc, "vis(%q, %s)", test.input, test.flag)
})
}
}
@ -116,12 +117,10 @@ func TestVisChanged(t *testing.T) {
"THIS\\IS_A_TEST1234",
"AC_Ra\u00edz_Certic\u00e1mara_S.A..pem",
} {
enc, err := Vis(test, DefaultVisFlags)
if err != nil {
t.Errorf("unexpected error with %q: %s", test, err)
}
if enc == test {
t.Errorf("expected encoding of %q to be changed", test)
}
t.Run(test, func(t *testing.T) {
enc, err := Vis(test, DefaultVisFlags)
require.NoErrorf(t, err, "vis(%q)", test)
assert.NotEqualf(t, test, enc, "encoding of %q should be different to original", test)
})
}
}