From 593474ef09a90e382897a88c48fd210b6f5e15b0 Mon Sep 17 00:00:00 2001 From: Hayden <64056131+hay-kot@users.noreply.github.com> Date: Sun, 9 Oct 2022 11:09:02 -0500 Subject: [PATCH] use switch instead of else-if --- backend/app/api/v1/v1_ctrl_auth.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/backend/app/api/v1/v1_ctrl_auth.go b/backend/app/api/v1/v1_ctrl_auth.go index 253dee2..0a4f990 100644 --- a/backend/app/api/v1/v1_ctrl_auth.go +++ b/backend/app/api/v1/v1_ctrl_auth.go @@ -36,7 +36,8 @@ func (ctrl *V1Controller) HandleAuthLogin() http.HandlerFunc { return func(w http.ResponseWriter, r *http.Request) { loginForm := &LoginForm{} - if r.Header.Get("Content-Type") == server.ContentFormUrlEncoded { + switch r.Header.Get("Content-Type") { + case server.ContentFormUrlEncoded: err := r.ParseForm() if err != nil { server.Respond(w, http.StatusBadRequest, server.Wrap(err)) @@ -46,7 +47,7 @@ func (ctrl *V1Controller) HandleAuthLogin() http.HandlerFunc { loginForm.Username = r.PostFormValue("username") loginForm.Password = r.PostFormValue("password") - } else if r.Header.Get("Content-Type") == server.ContentJSON { + case server.ContentJSON: err := server.Decode(r, loginForm) if err != nil { @@ -54,7 +55,7 @@ func (ctrl *V1Controller) HandleAuthLogin() http.HandlerFunc { server.Respond(w, http.StatusBadRequest, server.Wrap(err)) return } - } else { + default: server.Respond(w, http.StatusBadRequest, errors.New("invalid content type")) return } @@ -67,7 +68,7 @@ func (ctrl *V1Controller) HandleAuthLogin() http.HandlerFunc { newToken, err := ctrl.svc.User.Login(r.Context(), loginForm.Username, loginForm.Password) if err != nil { - server.RespondError(w, http.StatusUnauthorized, err) + server.RespondError(w, http.StatusInternalServerError, err) return }