From d10ae7872554f3d0272ad381227a46efc5169ad9 Mon Sep 17 00:00:00 2001 From: Hayden <64056131+hay-kot@users.noreply.github.com> Date: Mon, 5 Sep 2022 00:13:04 -0800 Subject: [PATCH] use atomic for test shutdown --- backend/pkgs/server/server_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/backend/pkgs/server/server_test.go b/backend/pkgs/server/server_test.go index b69b3eb..669182b 100644 --- a/backend/pkgs/server/server_test.go +++ b/backend/pkgs/server/server_test.go @@ -2,6 +2,7 @@ package server import ( "net/http" + "sync/atomic" "testing" "time" @@ -72,14 +73,14 @@ func Test_GracefulServerShutdownWithWorkers(t *testing.T) { } func Test_GracefulServerShutdownWithRequests(t *testing.T) { - isFinished := false + var isFinished atomic.Bool router := http.NewServeMux() // add long running handler func router.HandleFunc("/test", func(rw http.ResponseWriter, r *http.Request) { time.Sleep(time.Second * 3) - isFinished = true + isFinished.Store(true) }) svr := testServer(t, router) @@ -94,5 +95,5 @@ func Test_GracefulServerShutdownWithRequests(t *testing.T) { err := svr.Shutdown("test") assert.NoError(t, err) - assert.True(t, isFinished) + assert.True(t, isFinished.Load()) }