mirrors/homebox
1
0
Fork 1
mirror of https://github.com/hay-kot/homebox.git synced 2025-08-04 08:40:28 +00:00
Code Issues Projects Releases Packages Wiki Activity

improve unnecessary data fetches

Browse source
This commit is contained in:
Hayden 2023-02-05 11:26:34 -09:00
parent d9dd1e22cb
commit dd7a8099ef
No known key found for this signature in database
GPG key ID: 17CF79474E257545
3 changed files with 17 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
frontend/composables/use-api.ts
View file

@ -4,7 +4,7 @@ import { Requests } from "~~/lib/requests";
import { useAuthStore } from "~~/stores/auth"; import { useAuthStore } from "~~/stores/auth";
export type Observer = { export type Observer = {
handler: (r: Response) => void; handler: (r: Response, req?: RequestInit) => void;
}; };
export type RemoveObserver = () => void; export type RemoveObserver = () => void;

16
frontend/layouts/default.vue
View file

@ -181,11 +181,18 @@
}, },
]; ];
function isMutation(method: string | undefined) {
return method === "POST" || method === "PUT" || method === "DELETE";
}
function isSuccess(status: number) {
return status >= 200 && status < 300;
}
const labelStore = useLabelStore(); const labelStore = useLabelStore();
const reLabel = /\/api\/v1\/labels\/.*/gm; const reLabel = /\/api\/v1\/labels\/.*/gm;
const rmLabelStoreObserver = defineObserver("labelStore", { const rmLabelStoreObserver = defineObserver("labelStore", {
handler: r => { handler: (resp, req) => {
if (r.status === 201 || r.url.match(reLabel)) { if (isMutation(req?.method) && isSuccess(resp.status) && resp.url.match(reLabel)) {
labelStore.refresh(); labelStore.refresh();
} }
console.debug("labelStore handler called by observer"); console.debug("labelStore handler called by observer");
@ -195,11 +202,12 @@
const locationStore = useLocationStore(); const locationStore = useLocationStore();
const reLocation = /\/api\/v1\/locations\/.*/gm; const reLocation = /\/api\/v1\/locations\/.*/gm;
const rmLocationStoreObserver = defineObserver("locationStore", { const rmLocationStoreObserver = defineObserver("locationStore", {
handler: r => { handler: (resp, req) => {
if (r.status === 201 || r.url.match(reLocation)) { if (isMutation(req?.method) && isSuccess(resp.status) && resp.url.match(reLocation)) {
locationStore.refreshChildren(); locationStore.refreshChildren();
locationStore.refreshParents(); locationStore.refreshParents();
} }
console.debug("locationStore handler called by observer"); console.debug("locationStore handler called by observer");
}, },
}); });

9
frontend/lib/requests/requests.ts
View file

@ -5,8 +5,7 @@ export enum Method {
DELETE = "DELETE", DELETE = "DELETE",
} }
export type RequestInterceptor = (r: Response) => void; export type ResponseInterceptor = (r: Response, rq?: RequestInit) => void;
export type ResponseInterceptor = (r: Response) => void;
export interface TResponse<T> { export interface TResponse<T> {
status: number; status: number;
@ -32,8 +31,8 @@ export class Requests {
this.responseInterceptors.push(interceptor); this.responseInterceptors.push(interceptor);
} }
private callResponseInterceptors(response: Response) { private callResponseInterceptors(response: Response, request?: RequestInit) {
this.responseInterceptors.forEach(i => i(response)); this.responseInterceptors.forEach(i => i(response, request));
} }
private url(rest: string): string { private url(rest: string): string {
@ -90,7 +89,7 @@ export class Requests {
} }
const response = await fetch(this.url(rargs.url), payload); const response = await fetch(this.url(rargs.url), payload);
this.callResponseInterceptors(response); this.callResponseInterceptors(response, payload);
const data: T = await (async () => { const data: T = await (async () => {
if (response.status === 204) { if (response.status === 204) {