2019-05-27 06:55:06 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
Copyright (c) 1998 - 2002 Frodo Looijaard <frodol@dds.nl>,
|
|
|
|
Philip Edelbrock <phil@netroedge.com>, and Mark D. Studebaker
|
|
|
|
<mdsxyz123@yahoo.com>
|
2014-11-12 09:20:40 +00:00
|
|
|
Copyright (C) 2007 - 2014 Jean Delvare <jdelvare@suse.de>
|
2010-10-31 20:06:59 +00:00
|
|
|
Copyright (C) 2010 Intel Corporation,
|
|
|
|
David Woodhouse <dwmw2@infradead.org>
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
2014-07-17 13:03:24 +00:00
|
|
|
* Supports the following Intel I/O Controller Hubs (ICH):
|
|
|
|
*
|
|
|
|
* I/O Block I2C
|
|
|
|
* region SMBus Block proc. block
|
|
|
|
* Chip name PCI ID size PEC buffer call read
|
|
|
|
* ---------------------------------------------------------------------------
|
|
|
|
* 82801AA (ICH) 0x2413 16 no no no no
|
|
|
|
* 82801AB (ICH0) 0x2423 16 no no no no
|
|
|
|
* 82801BA (ICH2) 0x2443 16 no no no no
|
|
|
|
* 82801CA (ICH3) 0x2483 32 soft no no no
|
|
|
|
* 82801DB (ICH4) 0x24c3 32 hard yes no no
|
|
|
|
* 82801E (ICH5) 0x24d3 32 hard yes yes yes
|
|
|
|
* 6300ESB 0x25a4 32 hard yes yes yes
|
|
|
|
* 82801F (ICH6) 0x266a 32 hard yes yes yes
|
|
|
|
* 6310ESB/6320ESB 0x269b 32 hard yes yes yes
|
|
|
|
* 82801G (ICH7) 0x27da 32 hard yes yes yes
|
|
|
|
* 82801H (ICH8) 0x283e 32 hard yes yes yes
|
|
|
|
* 82801I (ICH9) 0x2930 32 hard yes yes yes
|
|
|
|
* EP80579 (Tolapai) 0x5032 32 hard yes yes yes
|
|
|
|
* ICH10 0x3a30 32 hard yes yes yes
|
|
|
|
* ICH10 0x3a60 32 hard yes yes yes
|
|
|
|
* 5/3400 Series (PCH) 0x3b30 32 hard yes yes yes
|
|
|
|
* 6 Series (PCH) 0x1c22 32 hard yes yes yes
|
|
|
|
* Patsburg (PCH) 0x1d22 32 hard yes yes yes
|
|
|
|
* Patsburg (PCH) IDF 0x1d70 32 hard yes yes yes
|
|
|
|
* Patsburg (PCH) IDF 0x1d71 32 hard yes yes yes
|
|
|
|
* Patsburg (PCH) IDF 0x1d72 32 hard yes yes yes
|
|
|
|
* DH89xxCC (PCH) 0x2330 32 hard yes yes yes
|
|
|
|
* Panther Point (PCH) 0x1e22 32 hard yes yes yes
|
|
|
|
* Lynx Point (PCH) 0x8c22 32 hard yes yes yes
|
|
|
|
* Lynx Point-LP (PCH) 0x9c22 32 hard yes yes yes
|
|
|
|
* Avoton (SOC) 0x1f3c 32 hard yes yes yes
|
|
|
|
* Wellsburg (PCH) 0x8d22 32 hard yes yes yes
|
|
|
|
* Wellsburg (PCH) MS 0x8d7d 32 hard yes yes yes
|
|
|
|
* Wellsburg (PCH) MS 0x8d7e 32 hard yes yes yes
|
|
|
|
* Wellsburg (PCH) MS 0x8d7f 32 hard yes yes yes
|
|
|
|
* Coleto Creek (PCH) 0x23b0 32 hard yes yes yes
|
2014-07-17 13:04:41 +00:00
|
|
|
* Wildcat Point (PCH) 0x8ca2 32 hard yes yes yes
|
2014-07-17 13:03:24 +00:00
|
|
|
* Wildcat Point-LP (PCH) 0x9ca2 32 hard yes yes yes
|
|
|
|
* BayTrail (SOC) 0x0f12 32 hard yes yes yes
|
2018-02-16 09:24:29 +00:00
|
|
|
* Braswell (SOC) 0x2292 32 hard yes yes yes
|
2014-10-13 22:20:24 +00:00
|
|
|
* Sunrise Point-H (PCH) 0xa123 32 hard yes yes yes
|
2014-11-05 21:30:03 +00:00
|
|
|
* Sunrise Point-LP (PCH) 0x9d23 32 hard yes yes yes
|
2015-10-13 12:41:39 +00:00
|
|
|
* DNV (SOC) 0x19df 32 hard yes yes yes
|
2020-06-18 13:42:39 +00:00
|
|
|
* Emmitsburg (PCH) 0x1bc9 32 hard yes yes yes
|
2015-10-22 14:16:58 +00:00
|
|
|
* Broxton (SOC) 0x5ad4 32 hard yes yes yes
|
2015-11-05 19:40:25 +00:00
|
|
|
* Lewisburg (PCH) 0xa1a3 32 hard yes yes yes
|
|
|
|
* Lewisburg Supersku (PCH) 0xa223 32 hard yes yes yes
|
2016-09-23 08:56:01 +00:00
|
|
|
* Kaby Lake PCH-H (PCH) 0xa2a3 32 hard yes yes yes
|
2017-02-01 16:20:59 +00:00
|
|
|
* Gemini Lake (SOC) 0x31d4 32 hard yes yes yes
|
2017-05-18 08:23:06 +00:00
|
|
|
* Cannon Lake-H (PCH) 0xa323 32 hard yes yes yes
|
|
|
|
* Cannon Lake-LP (PCH) 0x9da3 32 hard yes yes yes
|
2017-09-21 13:23:16 +00:00
|
|
|
* Cedar Fork (PCH) 0x18df 32 hard yes yes yes
|
2018-06-28 13:08:24 +00:00
|
|
|
* Ice Lake-LP (PCH) 0x34a3 32 hard yes yes yes
|
2021-10-01 17:21:54 +00:00
|
|
|
* Ice Lake-N (PCH) 0x38a3 32 hard yes yes yes
|
2019-03-15 10:56:49 +00:00
|
|
|
* Comet Lake (PCH) 0x02a3 32 hard yes yes yes
|
2019-10-24 10:57:26 +00:00
|
|
|
* Comet Lake-H (PCH) 0x06a3 32 hard yes yes yes
|
2019-06-20 10:51:26 +00:00
|
|
|
* Elkhart Lake (PCH) 0x4b23 32 hard yes yes yes
|
2019-07-01 13:15:34 +00:00
|
|
|
* Tiger Lake-LP (PCH) 0xa0a3 32 hard yes yes yes
|
2020-06-18 13:42:40 +00:00
|
|
|
* Tiger Lake-H (PCH) 0x43a3 32 hard yes yes yes
|
2019-11-20 15:19:32 +00:00
|
|
|
* Jasper Lake (SOC) 0x4da3 32 hard yes yes yes
|
2020-01-16 07:46:51 +00:00
|
|
|
* Comet Lake-V (PCH) 0xa3a3 32 hard yes yes yes
|
2020-09-24 13:52:17 +00:00
|
|
|
* Alder Lake-S (PCH) 0x7aa3 32 hard yes yes yes
|
2021-01-14 14:38:11 +00:00
|
|
|
* Alder Lake-P (PCH) 0x51a3 32 hard yes yes yes
|
2021-04-12 13:41:12 +00:00
|
|
|
* Alder Lake-M (PCH) 0x54a3 32 hard yes yes yes
|
2014-07-17 13:03:24 +00:00
|
|
|
*
|
|
|
|
* Features supported by this driver:
|
|
|
|
* Software PEC no
|
|
|
|
* Hardware PEC yes
|
|
|
|
* Block buffer yes
|
2019-06-18 17:06:50 +00:00
|
|
|
* Block process call transaction yes
|
2014-07-17 13:03:24 +00:00
|
|
|
* I2C block read transaction yes (doesn't use the block buffer)
|
|
|
|
* Slave mode no
|
2016-06-24 14:39:49 +00:00
|
|
|
* SMBus Host Notify yes
|
2014-07-17 13:03:24 +00:00
|
|
|
* Interrupt processing yes
|
|
|
|
*
|
2019-07-26 12:51:16 +00:00
|
|
|
* See the file Documentation/i2c/busses/i2c-i801.rst for details.
|
2014-07-17 13:03:24 +00:00
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2021-05-25 20:04:23 +00:00
|
|
|
#define DRV_NAME "i801_smbus"
|
|
|
|
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
#include <linux/interrupt.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/pci.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/stddef.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/ioport.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/i2c.h>
|
2016-06-24 14:39:49 +00:00
|
|
|
#include <linux/i2c-smbus.h>
|
2008-07-14 20:38:33 +00:00
|
|
|
#include <linux/acpi.h>
|
2009-01-07 13:29:17 +00:00
|
|
|
#include <linux/io.h>
|
2009-03-30 19:46:44 +00:00
|
|
|
#include <linux/dmi.h>
|
2011-01-10 21:11:22 +00:00
|
|
|
#include <linux/slab.h>
|
2019-06-21 11:36:24 +00:00
|
|
|
#include <linux/string.h>
|
2021-05-21 22:02:43 +00:00
|
|
|
#include <linux/completion.h>
|
2012-10-05 20:23:53 +00:00
|
|
|
#include <linux/err.h>
|
2015-08-06 12:46:25 +00:00
|
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <linux/platform_data/itco_wdt.h>
|
2016-03-10 12:12:22 +00:00
|
|
|
#include <linux/pm_runtime.h>
|
2021-08-06 21:13:29 +00:00
|
|
|
#include <linux/mutex.h>
|
2012-10-05 20:23:53 +00:00
|
|
|
|
2016-07-21 16:11:01 +00:00
|
|
|
#if IS_ENABLED(CONFIG_I2C_MUX_GPIO) && defined CONFIG_DMI
|
2019-06-18 10:58:33 +00:00
|
|
|
#include <linux/gpio/machine.h>
|
2018-04-19 20:00:08 +00:00
|
|
|
#include <linux/platform_data/i2c-mux-gpio.h>
|
2012-10-05 20:23:53 +00:00
|
|
|
#endif
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* I801 SMBus address offsets */
|
2010-10-31 20:06:59 +00:00
|
|
|
#define SMBHSTSTS(p) (0 + (p)->smba)
|
|
|
|
#define SMBHSTCNT(p) (2 + (p)->smba)
|
|
|
|
#define SMBHSTCMD(p) (3 + (p)->smba)
|
|
|
|
#define SMBHSTADD(p) (4 + (p)->smba)
|
|
|
|
#define SMBHSTDAT0(p) (5 + (p)->smba)
|
|
|
|
#define SMBHSTDAT1(p) (6 + (p)->smba)
|
|
|
|
#define SMBBLKDAT(p) (7 + (p)->smba)
|
|
|
|
#define SMBPEC(p) (8 + (p)->smba) /* ICH3 and later */
|
|
|
|
#define SMBAUXSTS(p) (12 + (p)->smba) /* ICH4 and later */
|
|
|
|
#define SMBAUXCTL(p) (13 + (p)->smba) /* ICH4 and later */
|
2016-06-24 14:39:49 +00:00
|
|
|
#define SMBSLVSTS(p) (16 + (p)->smba) /* ICH3 and later */
|
|
|
|
#define SMBSLVCMD(p) (17 + (p)->smba) /* ICH3 and later */
|
|
|
|
#define SMBNTFDADD(p) (20 + (p)->smba) /* ICH3 and later */
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* PCI Address Constants */
|
2006-06-12 19:53:02 +00:00
|
|
|
#define SMBBAR 4
|
2005-04-16 22:20:36 +00:00
|
|
|
#define SMBHSTCFG 0x040
|
2015-08-06 12:46:25 +00:00
|
|
|
#define TCOBASE 0x050
|
|
|
|
#define TCOCTL 0x054
|
|
|
|
|
|
|
|
#define SBREG_BAR 0x10
|
|
|
|
#define SBREG_SMBCTRL 0xc6000c
|
2018-09-03 08:24:57 +00:00
|
|
|
#define SBREG_SMBCTRL_DNV 0xcf000c
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* Host configuration bits for SMBHSTCFG */
|
2016-10-13 12:10:37 +00:00
|
|
|
#define SMBHSTCFG_HST_EN BIT(0)
|
|
|
|
#define SMBHSTCFG_SMB_SMI_EN BIT(1)
|
|
|
|
#define SMBHSTCFG_I2C_EN BIT(2)
|
|
|
|
#define SMBHSTCFG_SPD_WD BIT(4)
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-08-06 12:46:25 +00:00
|
|
|
/* TCO configuration bits for TCOCTL */
|
2016-10-13 12:10:37 +00:00
|
|
|
#define TCOCTL_EN BIT(8)
|
2015-08-06 12:46:25 +00:00
|
|
|
|
2016-07-01 20:42:15 +00:00
|
|
|
/* Auxiliary status register bits, ICH4+ only */
|
2016-10-13 12:10:37 +00:00
|
|
|
#define SMBAUXSTS_CRCE BIT(0)
|
|
|
|
#define SMBAUXSTS_STCO BIT(1)
|
2016-07-01 20:42:15 +00:00
|
|
|
|
2011-03-31 01:57:33 +00:00
|
|
|
/* Auxiliary control register bits, ICH4+ only */
|
2016-10-13 12:10:37 +00:00
|
|
|
#define SMBAUXCTL_CRC BIT(0)
|
|
|
|
#define SMBAUXCTL_E32B BIT(1)
|
2007-07-12 12:12:31 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* I801 command constants */
|
|
|
|
#define I801_QUICK 0x00
|
|
|
|
#define I801_BYTE 0x04
|
|
|
|
#define I801_BYTE_DATA 0x08
|
|
|
|
#define I801_WORD_DATA 0x0C
|
2008-01-27 17:14:49 +00:00
|
|
|
#define I801_PROC_CALL 0x10 /* unimplemented */
|
2005-04-16 22:20:36 +00:00
|
|
|
#define I801_BLOCK_DATA 0x14
|
2008-01-27 17:14:50 +00:00
|
|
|
#define I801_I2C_BLOCK_DATA 0x18 /* ICH5 and later */
|
2019-06-18 17:06:50 +00:00
|
|
|
#define I801_BLOCK_PROC_CALL 0x1C
|
2012-07-24 12:13:58 +00:00
|
|
|
|
|
|
|
/* I801 Host Control register bits */
|
2016-10-13 12:10:37 +00:00
|
|
|
#define SMBHSTCNT_INTREN BIT(0)
|
|
|
|
#define SMBHSTCNT_KILL BIT(1)
|
|
|
|
#define SMBHSTCNT_LAST_BYTE BIT(5)
|
|
|
|
#define SMBHSTCNT_START BIT(6)
|
|
|
|
#define SMBHSTCNT_PEC_EN BIT(7) /* ICH3 and later */
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-07-12 12:12:31 +00:00
|
|
|
/* I801 Hosts Status register bits */
|
2016-10-13 12:10:37 +00:00
|
|
|
#define SMBHSTSTS_BYTE_DONE BIT(7)
|
|
|
|
#define SMBHSTSTS_INUSE_STS BIT(6)
|
|
|
|
#define SMBHSTSTS_SMBALERT_STS BIT(5)
|
|
|
|
#define SMBHSTSTS_FAILED BIT(4)
|
|
|
|
#define SMBHSTSTS_BUS_ERR BIT(3)
|
|
|
|
#define SMBHSTSTS_DEV_ERR BIT(2)
|
|
|
|
#define SMBHSTSTS_INTR BIT(1)
|
|
|
|
#define SMBHSTSTS_HOST_BUSY BIT(0)
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2016-10-13 12:10:36 +00:00
|
|
|
/* Host Notify Status register bits */
|
2016-10-13 12:10:37 +00:00
|
|
|
#define SMBSLVSTS_HST_NTFY_STS BIT(0)
|
2016-06-24 14:39:49 +00:00
|
|
|
|
2016-10-13 12:10:36 +00:00
|
|
|
/* Host Notify Command register bits */
|
2021-11-17 09:45:09 +00:00
|
|
|
#define SMBSLVCMD_SMBALERT_DISABLE BIT(2)
|
2016-10-13 12:10:37 +00:00
|
|
|
#define SMBSLVCMD_HST_NTFY_INTREN BIT(0)
|
2016-06-24 14:39:49 +00:00
|
|
|
|
2012-07-24 12:13:58 +00:00
|
|
|
#define STATUS_ERROR_FLAGS (SMBHSTSTS_FAILED | SMBHSTSTS_BUS_ERR | \
|
|
|
|
SMBHSTSTS_DEV_ERR)
|
|
|
|
|
|
|
|
#define STATUS_FLAGS (SMBHSTSTS_BYTE_DONE | SMBHSTSTS_INTR | \
|
|
|
|
STATUS_ERROR_FLAGS)
|
2008-07-14 20:38:33 +00:00
|
|
|
|
2011-05-01 16:18:49 +00:00
|
|
|
/* Older devices have their ID defined in <linux/pci_ids.h> */
|
2019-07-01 13:15:33 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_COMETLAKE_SMBUS 0x02a3
|
2019-10-24 10:57:26 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_COMETLAKE_H_SMBUS 0x06a3
|
2014-07-17 13:03:24 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_BAYTRAIL_SMBUS 0x0f12
|
2017-09-21 13:23:16 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_CDF_SMBUS 0x18df
|
2016-03-09 12:14:17 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_DNV_SMBUS 0x19df
|
2020-06-18 13:42:39 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_EBG_SMBUS 0x1bc9
|
2014-07-17 13:03:24 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_COUGARPOINT_SMBUS 0x1c22
|
|
|
|
#define PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS 0x1d22
|
2010-10-31 20:07:00 +00:00
|
|
|
/* Patsburg also has three 'Integrated Device Function' SMBus controllers */
|
2014-07-17 13:03:24 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS_IDF0 0x1d70
|
|
|
|
#define PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS_IDF1 0x1d71
|
|
|
|
#define PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS_IDF2 0x1d72
|
|
|
|
#define PCI_DEVICE_ID_INTEL_PANTHERPOINT_SMBUS 0x1e22
|
|
|
|
#define PCI_DEVICE_ID_INTEL_AVOTON_SMBUS 0x1f3c
|
2016-03-09 12:14:17 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_BRASWELL_SMBUS 0x2292
|
2014-07-17 13:03:24 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_DH89XXCC_SMBUS 0x2330
|
|
|
|
#define PCI_DEVICE_ID_INTEL_COLETOCREEK_SMBUS 0x23b0
|
2017-02-01 16:20:59 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_GEMINILAKE_SMBUS 0x31d4
|
2018-06-28 13:08:24 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_ICELAKE_LP_SMBUS 0x34a3
|
2021-10-01 17:21:54 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_ICELAKE_N_SMBUS 0x38a3
|
2014-07-17 13:03:24 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_5_3400_SERIES_SMBUS 0x3b30
|
2020-06-18 13:42:40 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS 0x43a3
|
2019-07-01 13:15:33 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS 0x4b23
|
2019-11-20 15:19:32 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS 0x4da3
|
2021-01-14 14:38:11 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS 0x51a3
|
2021-04-12 13:41:12 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_M_SMBUS 0x54a3
|
2016-03-09 12:14:17 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS 0x5ad4
|
2020-09-24 13:52:17 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS 0x7aa3
|
2014-07-17 13:03:24 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_LYNXPOINT_SMBUS 0x8c22
|
2014-07-17 13:04:41 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_WILDCATPOINT_SMBUS 0x8ca2
|
2014-07-17 13:03:24 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS 0x8d22
|
|
|
|
#define PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS_MS0 0x8d7d
|
|
|
|
#define PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS_MS1 0x8d7e
|
|
|
|
#define PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS_MS2 0x8d7f
|
|
|
|
#define PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_SMBUS 0x9c22
|
2013-11-04 17:29:48 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP_SMBUS 0x9ca2
|
2014-11-05 21:30:03 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS 0x9d23
|
2017-05-18 08:23:06 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_CANNONLAKE_LP_SMBUS 0x9da3
|
2019-07-01 13:15:34 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS 0xa0a3
|
2016-03-09 12:14:17 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS 0xa123
|
2015-11-05 19:40:25 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_LEWISBURG_SMBUS 0xa1a3
|
|
|
|
#define PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS 0xa223
|
2016-09-23 08:56:01 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_KABYLAKE_PCH_H_SMBUS 0xa2a3
|
2017-05-18 08:23:06 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_CANNONLAKE_H_SMBUS 0xa323
|
2020-01-16 07:46:51 +00:00
|
|
|
#define PCI_DEVICE_ID_INTEL_COMETLAKE_V_SMBUS 0xa3a3
|
2010-10-31 20:07:00 +00:00
|
|
|
|
2012-10-05 20:23:53 +00:00
|
|
|
struct i801_mux_config {
|
|
|
|
char *gpio_chip;
|
|
|
|
unsigned values[3];
|
|
|
|
int n_values;
|
|
|
|
unsigned classes[3];
|
|
|
|
unsigned gpios[2]; /* Relative to gpio_chip->base */
|
|
|
|
int n_gpios;
|
|
|
|
};
|
|
|
|
|
2010-10-31 20:06:59 +00:00
|
|
|
struct i801_priv {
|
|
|
|
struct i2c_adapter adapter;
|
|
|
|
unsigned long smba;
|
|
|
|
unsigned char original_hstcfg;
|
2021-11-09 15:02:57 +00:00
|
|
|
unsigned char original_hstcnt;
|
2016-10-13 12:10:35 +00:00
|
|
|
unsigned char original_slvcmd;
|
2010-10-31 20:06:59 +00:00
|
|
|
struct pci_dev *pci_dev;
|
|
|
|
unsigned int features;
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
|
|
|
|
/* isr processing */
|
2021-05-21 22:02:43 +00:00
|
|
|
struct completion done;
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
u8 status;
|
2012-07-24 12:13:59 +00:00
|
|
|
|
|
|
|
/* Command state used by isr for byte-by-byte block transactions */
|
|
|
|
u8 cmd;
|
|
|
|
bool is_read;
|
|
|
|
int count;
|
|
|
|
int len;
|
|
|
|
u8 *data;
|
2012-10-05 20:23:53 +00:00
|
|
|
|
2016-07-21 16:11:01 +00:00
|
|
|
#if IS_ENABLED(CONFIG_I2C_MUX_GPIO) && defined CONFIG_DMI
|
2012-10-05 20:23:53 +00:00
|
|
|
const struct i801_mux_config *mux_drvdata;
|
|
|
|
struct platform_device *mux_pdev;
|
2019-06-18 10:58:33 +00:00
|
|
|
struct gpiod_lookup_table *lookup;
|
2012-10-05 20:23:53 +00:00
|
|
|
#endif
|
2015-08-06 12:46:25 +00:00
|
|
|
struct platform_device *tco_pdev;
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If set to true the host controller registers are reserved for
|
|
|
|
* ACPI AML use. Protected by acpi_lock.
|
|
|
|
*/
|
|
|
|
bool acpi_reserved;
|
|
|
|
struct mutex acpi_lock;
|
2010-10-31 20:06:59 +00:00
|
|
|
};
|
|
|
|
|
2016-10-13 12:10:38 +00:00
|
|
|
#define FEATURE_SMBUS_PEC BIT(0)
|
|
|
|
#define FEATURE_BLOCK_BUFFER BIT(1)
|
|
|
|
#define FEATURE_BLOCK_PROC BIT(2)
|
|
|
|
#define FEATURE_I2C_BLOCK_READ BIT(3)
|
|
|
|
#define FEATURE_IRQ BIT(4)
|
|
|
|
#define FEATURE_HOST_NOTIFY BIT(5)
|
2011-05-24 18:58:49 +00:00
|
|
|
/* Not really a feature, but it's convenient to handle it as such */
|
2016-10-13 12:10:38 +00:00
|
|
|
#define FEATURE_IDF BIT(15)
|
2019-08-31 14:24:02 +00:00
|
|
|
#define FEATURE_TCO_SPT BIT(16)
|
|
|
|
#define FEATURE_TCO_CNL BIT(17)
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-05-21 16:40:54 +00:00
|
|
|
static const char *i801_feature_names[] = {
|
|
|
|
"SMBus PEC",
|
|
|
|
"Block buffer",
|
|
|
|
"Block process call",
|
|
|
|
"I2C block read",
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
"Interrupt",
|
2016-06-24 14:39:49 +00:00
|
|
|
"SMBus Host Notify",
|
2010-05-21 16:40:54 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static unsigned int disable_features;
|
|
|
|
module_param(disable_features, uint, S_IRUGO | S_IWUSR);
|
2013-05-15 02:44:10 +00:00
|
|
|
MODULE_PARM_DESC(disable_features, "Disable selected driver features:\n"
|
|
|
|
"\t\t 0x01 disable SMBus PEC\n"
|
|
|
|
"\t\t 0x02 disable the block buffer\n"
|
|
|
|
"\t\t 0x08 disable the I2C block read functionality\n"
|
2016-06-24 14:39:49 +00:00
|
|
|
"\t\t 0x10 don't use interrupts\n"
|
|
|
|
"\t\t 0x20 disable SMBus Host Notify ");
|
2010-05-21 16:40:54 +00:00
|
|
|
|
2008-07-14 20:38:33 +00:00
|
|
|
/* Make sure the SMBus host is ready to start transmitting.
|
|
|
|
Return 0 if it is, -EBUSY if it is not. */
|
2010-10-31 20:06:59 +00:00
|
|
|
static int i801_check_pre(struct i801_priv *priv)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-14 20:38:32 +00:00
|
|
|
int status;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-10-31 20:06:59 +00:00
|
|
|
status = inb_p(SMBHSTSTS(priv));
|
2008-07-14 20:38:33 +00:00
|
|
|
if (status & SMBHSTSTS_HOST_BUSY) {
|
2010-10-31 20:06:59 +00:00
|
|
|
dev_err(&priv->pci_dev->dev, "SMBus is busy, can't use it!\n");
|
2008-07-14 20:38:33 +00:00
|
|
|
return -EBUSY;
|
|
|
|
}
|
|
|
|
|
|
|
|
status &= STATUS_FLAGS;
|
|
|
|
if (status) {
|
2010-10-31 20:06:59 +00:00
|
|
|
dev_dbg(&priv->pci_dev->dev, "Clearing status flags (%02x)\n",
|
2008-07-14 20:38:32 +00:00
|
|
|
status);
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(status, SMBHSTSTS(priv));
|
|
|
|
status = inb_p(SMBHSTSTS(priv)) & STATUS_FLAGS;
|
2008-07-14 20:38:33 +00:00
|
|
|
if (status) {
|
2010-10-31 20:06:59 +00:00
|
|
|
dev_err(&priv->pci_dev->dev,
|
2008-07-14 20:38:33 +00:00
|
|
|
"Failed clearing status flags (%02x)\n",
|
|
|
|
status);
|
2008-07-14 20:38:25 +00:00
|
|
|
return -EBUSY;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-07-01 20:42:15 +00:00
|
|
|
/*
|
|
|
|
* Clear CRC status if needed.
|
|
|
|
* During normal operation, i801_check_post() takes care
|
|
|
|
* of it after every operation. We do it here only in case
|
|
|
|
* the hardware was already in this state when the driver
|
|
|
|
* started.
|
|
|
|
*/
|
|
|
|
if (priv->features & FEATURE_SMBUS_PEC) {
|
|
|
|
status = inb_p(SMBAUXSTS(priv)) & SMBAUXSTS_CRCE;
|
|
|
|
if (status) {
|
|
|
|
dev_dbg(&priv->pci_dev->dev,
|
|
|
|
"Clearing aux status flags (%02x)\n", status);
|
|
|
|
outb_p(status, SMBAUXSTS(priv));
|
|
|
|
status = inb_p(SMBAUXSTS(priv)) & SMBAUXSTS_CRCE;
|
|
|
|
if (status) {
|
|
|
|
dev_err(&priv->pci_dev->dev,
|
|
|
|
"Failed clearing aux status flags (%02x)\n",
|
|
|
|
status);
|
|
|
|
return -EBUSY;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-07-14 20:38:33 +00:00
|
|
|
return 0;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-07-24 12:13:58 +00:00
|
|
|
/*
|
|
|
|
* Convert the status register to an error code, and clear it.
|
|
|
|
* Note that status only contains the bits we want to clear, not the
|
|
|
|
* actual register value.
|
|
|
|
*/
|
|
|
|
static int i801_check_post(struct i801_priv *priv, int status)
|
2008-07-14 20:38:33 +00:00
|
|
|
{
|
|
|
|
int result = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
/*
|
|
|
|
* If the SMBus is still busy, we give up
|
|
|
|
* Note: This timeout condition only happens when using polling
|
|
|
|
* transactions. For interrupt operation, NAK/timeout is indicated by
|
|
|
|
* DEV_ERR.
|
|
|
|
*/
|
2012-07-24 12:13:58 +00:00
|
|
|
if (unlikely(status < 0)) {
|
2010-10-31 20:06:59 +00:00
|
|
|
dev_err(&priv->pci_dev->dev, "Transaction timeout\n");
|
2007-07-12 12:12:31 +00:00
|
|
|
/* try to stop the current command */
|
2010-10-31 20:06:59 +00:00
|
|
|
dev_dbg(&priv->pci_dev->dev, "Terminating the current operation\n");
|
2021-05-25 15:03:36 +00:00
|
|
|
outb_p(SMBHSTCNT_KILL, SMBHSTCNT(priv));
|
2012-03-26 19:47:19 +00:00
|
|
|
usleep_range(1000, 2000);
|
2021-05-25 15:03:36 +00:00
|
|
|
outb_p(0, SMBHSTCNT(priv));
|
2008-07-14 20:38:33 +00:00
|
|
|
|
|
|
|
/* Check if it worked */
|
2010-10-31 20:06:59 +00:00
|
|
|
status = inb_p(SMBHSTSTS(priv));
|
2008-07-14 20:38:33 +00:00
|
|
|
if ((status & SMBHSTSTS_HOST_BUSY) ||
|
|
|
|
!(status & SMBHSTSTS_FAILED))
|
2010-10-31 20:06:59 +00:00
|
|
|
dev_err(&priv->pci_dev->dev,
|
2008-07-14 20:38:33 +00:00
|
|
|
"Failed terminating the transaction\n");
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(STATUS_FLAGS, SMBHSTSTS(priv));
|
2008-07-14 20:38:33 +00:00
|
|
|
return -ETIMEDOUT;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-07-14 20:38:32 +00:00
|
|
|
if (status & SMBHSTSTS_FAILED) {
|
2008-07-14 20:38:25 +00:00
|
|
|
result = -EIO;
|
2010-10-31 20:06:59 +00:00
|
|
|
dev_err(&priv->pci_dev->dev, "Transaction failed\n");
|
2008-07-14 20:38:33 +00:00
|
|
|
}
|
|
|
|
if (status & SMBHSTSTS_DEV_ERR) {
|
2016-07-01 20:42:15 +00:00
|
|
|
/*
|
|
|
|
* This may be a PEC error, check and clear it.
|
|
|
|
*
|
|
|
|
* AUXSTS is handled differently from HSTSTS.
|
|
|
|
* For HSTSTS, i801_isr() or i801_wait_intr()
|
|
|
|
* has already cleared the error bits in hardware,
|
|
|
|
* and we are passed a copy of the original value
|
|
|
|
* in "status".
|
|
|
|
* For AUXSTS, the hardware register is left
|
|
|
|
* for us to handle here.
|
|
|
|
* This is asymmetric, slightly iffy, but safe,
|
|
|
|
* since all this code is serialized and the CRCE
|
|
|
|
* bit is harmless as long as it's cleared before
|
|
|
|
* the next operation.
|
|
|
|
*/
|
|
|
|
if ((priv->features & FEATURE_SMBUS_PEC) &&
|
|
|
|
(inb_p(SMBAUXSTS(priv)) & SMBAUXSTS_CRCE)) {
|
|
|
|
outb_p(SMBAUXSTS_CRCE, SMBAUXSTS(priv));
|
|
|
|
result = -EBADMSG;
|
|
|
|
dev_dbg(&priv->pci_dev->dev, "PEC error\n");
|
|
|
|
} else {
|
|
|
|
result = -ENXIO;
|
|
|
|
dev_dbg(&priv->pci_dev->dev, "No response\n");
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-07-14 20:38:32 +00:00
|
|
|
if (status & SMBHSTSTS_BUS_ERR) {
|
2008-07-14 20:38:32 +00:00
|
|
|
result = -EAGAIN;
|
2010-10-31 20:06:59 +00:00
|
|
|
dev_dbg(&priv->pci_dev->dev, "Lost arbitration\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2012-07-24 12:13:58 +00:00
|
|
|
/* Clear status flags except BYTE_DONE, to be cleared by caller */
|
|
|
|
outb_p(status, SMBHSTSTS(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2012-07-24 12:13:58 +00:00
|
|
|
/* Wait for BUSY being cleared and either INTR or an error flag being set */
|
|
|
|
static int i801_wait_intr(struct i801_priv *priv)
|
2008-07-14 20:38:33 +00:00
|
|
|
{
|
2021-05-25 19:59:05 +00:00
|
|
|
unsigned long timeout = jiffies + priv->adapter.timeout;
|
|
|
|
int status, busy;
|
2008-07-14 20:38:33 +00:00
|
|
|
|
|
|
|
do {
|
2012-03-26 19:47:19 +00:00
|
|
|
usleep_range(250, 500);
|
2010-10-31 20:06:59 +00:00
|
|
|
status = inb_p(SMBHSTSTS(priv));
|
2021-05-25 19:59:05 +00:00
|
|
|
busy = status & SMBHSTSTS_HOST_BUSY;
|
|
|
|
status &= STATUS_ERROR_FLAGS | SMBHSTSTS_INTR;
|
|
|
|
if (!busy && status)
|
|
|
|
return status;
|
|
|
|
} while (time_is_after_eq_jiffies(timeout));
|
2008-07-14 20:38:33 +00:00
|
|
|
|
2021-05-25 19:59:05 +00:00
|
|
|
return -ETIMEDOUT;
|
2008-07-14 20:38:33 +00:00
|
|
|
}
|
|
|
|
|
2012-07-24 12:13:58 +00:00
|
|
|
/* Wait for either BYTE_DONE or an error flag being set */
|
|
|
|
static int i801_wait_byte_done(struct i801_priv *priv)
|
2007-07-12 12:12:31 +00:00
|
|
|
{
|
2021-05-25 19:59:05 +00:00
|
|
|
unsigned long timeout = jiffies + priv->adapter.timeout;
|
2008-07-14 20:38:32 +00:00
|
|
|
int status;
|
2007-07-12 12:12:31 +00:00
|
|
|
|
|
|
|
do {
|
2012-03-26 19:47:19 +00:00
|
|
|
usleep_range(250, 500);
|
2010-10-31 20:06:59 +00:00
|
|
|
status = inb_p(SMBHSTSTS(priv));
|
2021-05-25 19:59:05 +00:00
|
|
|
if (status & (STATUS_ERROR_FLAGS | SMBHSTSTS_BYTE_DONE))
|
|
|
|
return status & STATUS_ERROR_FLAGS;
|
|
|
|
} while (time_is_after_eq_jiffies(timeout));
|
2012-07-24 12:13:58 +00:00
|
|
|
|
2021-05-25 19:59:05 +00:00
|
|
|
return -ETIMEDOUT;
|
2012-07-24 12:13:58 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int i801_transaction(struct i801_priv *priv, int xact)
|
|
|
|
{
|
|
|
|
int status;
|
2021-05-21 22:02:43 +00:00
|
|
|
unsigned long result;
|
2014-11-12 09:20:40 +00:00
|
|
|
const struct i2c_adapter *adap = &priv->adapter;
|
2007-07-12 12:12:31 +00:00
|
|
|
|
2021-05-21 22:02:43 +00:00
|
|
|
status = i801_check_pre(priv);
|
|
|
|
if (status < 0)
|
|
|
|
return status;
|
2009-05-05 06:39:24 +00:00
|
|
|
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
if (priv->features & FEATURE_IRQ) {
|
2021-05-21 22:02:43 +00:00
|
|
|
reinit_completion(&priv->done);
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
outb_p(xact | SMBHSTCNT_INTREN | SMBHSTCNT_START,
|
|
|
|
SMBHSTCNT(priv));
|
2021-05-21 22:02:43 +00:00
|
|
|
result = wait_for_completion_timeout(&priv->done, adap->timeout);
|
|
|
|
return i801_check_post(priv, result ? priv->status : -ETIMEDOUT);
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
}
|
|
|
|
|
2012-07-24 12:13:58 +00:00
|
|
|
/* the current contents of SMBHSTCNT can be overwritten, since PEC,
|
|
|
|
* SMBSCMD are passed in xact */
|
|
|
|
outb_p(xact | SMBHSTCNT_START, SMBHSTCNT(priv));
|
|
|
|
|
|
|
|
status = i801_wait_intr(priv);
|
|
|
|
return i801_check_post(priv, status);
|
2007-07-12 12:12:31 +00:00
|
|
|
}
|
|
|
|
|
2010-10-31 20:06:59 +00:00
|
|
|
static int i801_block_transaction_by_block(struct i801_priv *priv,
|
|
|
|
union i2c_smbus_data *data,
|
2021-07-27 20:25:25 +00:00
|
|
|
char read_write, int command)
|
2007-07-12 12:12:31 +00:00
|
|
|
{
|
2021-07-27 20:25:25 +00:00
|
|
|
int i, len, status, xact;
|
2019-06-18 17:06:50 +00:00
|
|
|
|
|
|
|
switch (command) {
|
|
|
|
case I2C_SMBUS_BLOCK_PROC_CALL:
|
2021-07-27 20:25:25 +00:00
|
|
|
xact = I801_BLOCK_PROC_CALL;
|
2019-06-18 17:06:50 +00:00
|
|
|
break;
|
|
|
|
case I2C_SMBUS_BLOCK_DATA:
|
2021-07-27 20:25:25 +00:00
|
|
|
xact = I801_BLOCK_DATA;
|
2019-06-18 17:06:50 +00:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return -EOPNOTSUPP;
|
|
|
|
}
|
2007-07-12 12:12:31 +00:00
|
|
|
|
2010-10-31 20:06:59 +00:00
|
|
|
inb_p(SMBHSTCNT(priv)); /* reset the data buffer index */
|
2007-07-12 12:12:31 +00:00
|
|
|
|
|
|
|
/* Use 32-byte buffer to process this transaction */
|
|
|
|
if (read_write == I2C_SMBUS_WRITE) {
|
|
|
|
len = data->block[0];
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(len, SMBHSTDAT0(priv));
|
2007-07-12 12:12:31 +00:00
|
|
|
for (i = 0; i < len; i++)
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(data->block[i+1], SMBBLKDAT(priv));
|
2007-07-12 12:12:31 +00:00
|
|
|
}
|
|
|
|
|
2019-06-18 17:06:50 +00:00
|
|
|
status = i801_transaction(priv, xact);
|
2008-07-14 20:38:25 +00:00
|
|
|
if (status)
|
|
|
|
return status;
|
2007-07-12 12:12:31 +00:00
|
|
|
|
2019-06-18 17:06:50 +00:00
|
|
|
if (read_write == I2C_SMBUS_READ ||
|
|
|
|
command == I2C_SMBUS_BLOCK_PROC_CALL) {
|
2010-10-31 20:06:59 +00:00
|
|
|
len = inb_p(SMBHSTDAT0(priv));
|
2007-07-12 12:12:31 +00:00
|
|
|
if (len < 1 || len > I2C_SMBUS_BLOCK_MAX)
|
2008-07-14 20:38:25 +00:00
|
|
|
return -EPROTO;
|
2007-07-12 12:12:31 +00:00
|
|
|
|
|
|
|
data->block[0] = len;
|
|
|
|
for (i = 0; i < len; i++)
|
2010-10-31 20:06:59 +00:00
|
|
|
data->block[i + 1] = inb_p(SMBBLKDAT(priv));
|
2007-07-12 12:12:31 +00:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-07-24 12:13:59 +00:00
|
|
|
static void i801_isr_byte_done(struct i801_priv *priv)
|
|
|
|
{
|
|
|
|
if (priv->is_read) {
|
|
|
|
/* For SMBus block reads, length is received with first byte */
|
|
|
|
if (((priv->cmd & 0x1c) == I801_BLOCK_DATA) &&
|
|
|
|
(priv->count == 0)) {
|
|
|
|
priv->len = inb_p(SMBHSTDAT0(priv));
|
|
|
|
if (priv->len < 1 || priv->len > I2C_SMBUS_BLOCK_MAX) {
|
|
|
|
dev_err(&priv->pci_dev->dev,
|
|
|
|
"Illegal SMBus block read size %d\n",
|
|
|
|
priv->len);
|
|
|
|
/* FIXME: Recover */
|
|
|
|
priv->len = I2C_SMBUS_BLOCK_MAX;
|
|
|
|
}
|
|
|
|
priv->data[-1] = priv->len;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Read next byte */
|
|
|
|
if (priv->count < priv->len)
|
|
|
|
priv->data[priv->count++] = inb(SMBBLKDAT(priv));
|
|
|
|
else
|
|
|
|
dev_dbg(&priv->pci_dev->dev,
|
|
|
|
"Discarding extra byte on block read\n");
|
|
|
|
|
|
|
|
/* Set LAST_BYTE for last byte of read transaction */
|
|
|
|
if (priv->count == priv->len - 1)
|
|
|
|
outb_p(priv->cmd | SMBHSTCNT_LAST_BYTE,
|
|
|
|
SMBHSTCNT(priv));
|
|
|
|
} else if (priv->count < priv->len - 1) {
|
|
|
|
/* Write next byte, except for IRQ after last byte */
|
|
|
|
outb_p(priv->data[++priv->count], SMBBLKDAT(priv));
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Clear BYTE_DONE to continue with next byte */
|
|
|
|
outb_p(SMBHSTSTS_BYTE_DONE, SMBHSTSTS(priv));
|
|
|
|
}
|
|
|
|
|
2016-06-24 14:39:49 +00:00
|
|
|
static irqreturn_t i801_host_notify_isr(struct i801_priv *priv)
|
|
|
|
{
|
|
|
|
unsigned short addr;
|
|
|
|
|
|
|
|
addr = inb_p(SMBNTFDADD(priv)) >> 1;
|
|
|
|
|
2016-10-13 12:10:39 +00:00
|
|
|
/*
|
|
|
|
* With the tested platforms, reading SMBNTFDDAT (22 + (p)->smba)
|
2016-10-13 12:10:40 +00:00
|
|
|
* always returns 0. Our current implementation doesn't provide
|
|
|
|
* data, so we just ignore it.
|
2016-10-13 12:10:39 +00:00
|
|
|
*/
|
2016-10-13 12:10:40 +00:00
|
|
|
i2c_handle_smbus_host_notify(&priv->adapter, addr);
|
2016-06-24 14:39:49 +00:00
|
|
|
|
|
|
|
/* clear Host Notify bit and return */
|
|
|
|
outb_p(SMBSLVSTS_HST_NTFY_STS, SMBSLVSTS(priv));
|
|
|
|
return IRQ_HANDLED;
|
|
|
|
}
|
|
|
|
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
/*
|
2016-06-24 14:39:49 +00:00
|
|
|
* There are three kinds of interrupts:
|
2012-07-24 12:13:59 +00:00
|
|
|
*
|
|
|
|
* 1) i801 signals transaction completion with one of these interrupts:
|
|
|
|
* INTR - Success
|
|
|
|
* DEV_ERR - Invalid command, NAK or communication timeout
|
|
|
|
* BUS_ERR - SMI# transaction collision
|
|
|
|
* FAILED - transaction was canceled due to a KILL request
|
2021-05-21 22:02:43 +00:00
|
|
|
* When any of these occur, update ->status and signal completion.
|
2012-07-24 12:13:59 +00:00
|
|
|
* ->status must be cleared before kicking off the next transaction.
|
|
|
|
*
|
|
|
|
* 2) For byte-by-byte (I2C read/write) transactions, one BYTE_DONE interrupt
|
|
|
|
* occurs for each byte of a byte-by-byte to prepare the next byte.
|
2016-06-24 14:39:49 +00:00
|
|
|
*
|
|
|
|
* 3) Host Notify interrupts
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
*/
|
|
|
|
static irqreturn_t i801_isr(int irq, void *dev_id)
|
|
|
|
{
|
|
|
|
struct i801_priv *priv = dev_id;
|
|
|
|
u16 pcists;
|
|
|
|
u8 status;
|
|
|
|
|
|
|
|
/* Confirm this is our interrupt */
|
2021-05-22 21:46:20 +00:00
|
|
|
pci_read_config_word(priv->pci_dev, PCI_STATUS, &pcists);
|
|
|
|
if (!(pcists & PCI_STATUS_INTERRUPT))
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
return IRQ_NONE;
|
|
|
|
|
2016-06-24 14:39:49 +00:00
|
|
|
if (priv->features & FEATURE_HOST_NOTIFY) {
|
|
|
|
status = inb_p(SMBSLVSTS(priv));
|
|
|
|
if (status & SMBSLVSTS_HST_NTFY_STS)
|
|
|
|
return i801_host_notify_isr(priv);
|
|
|
|
}
|
|
|
|
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
status = inb_p(SMBHSTSTS(priv));
|
2012-07-24 12:13:59 +00:00
|
|
|
if (status & SMBHSTSTS_BYTE_DONE)
|
|
|
|
i801_isr_byte_done(priv);
|
|
|
|
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
/*
|
2021-11-17 09:45:09 +00:00
|
|
|
* Clear remaining IRQ sources: Completion of last command, errors
|
|
|
|
* and the SMB_ALERT signal. SMB_ALERT status is set after signal
|
|
|
|
* assertion independently of the interrupt generation being blocked
|
|
|
|
* or not so clear it always when the status is set.
|
|
|
|
*/
|
|
|
|
status &= SMBHSTSTS_INTR | STATUS_ERROR_FLAGS | SMBHSTSTS_SMBALERT_STS;
|
|
|
|
if (status)
|
|
|
|
outb_p(status, SMBHSTSTS(priv));
|
|
|
|
status &= ~SMBHSTSTS_SMBALERT_STS; /* SMB_ALERT not reported */
|
|
|
|
/*
|
|
|
|
* Report transaction result.
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
* ->status must be cleared before the next transaction is started.
|
|
|
|
*/
|
|
|
|
if (status) {
|
2016-05-25 07:37:02 +00:00
|
|
|
priv->status = status;
|
2021-05-21 22:02:43 +00:00
|
|
|
complete(&priv->done);
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return IRQ_HANDLED;
|
|
|
|
}
|
|
|
|
|
2012-07-24 12:13:57 +00:00
|
|
|
/*
|
|
|
|
* For "byte-by-byte" block transactions:
|
|
|
|
* I2C write uses cmd=I801_BLOCK_DATA, I2C_EN=1
|
|
|
|
* I2C read uses cmd=I801_I2C_BLOCK_DATA
|
|
|
|
*/
|
2010-10-31 20:06:59 +00:00
|
|
|
static int i801_block_transaction_byte_by_byte(struct i801_priv *priv,
|
|
|
|
union i2c_smbus_data *data,
|
2021-07-27 20:25:25 +00:00
|
|
|
char read_write, int command)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
int i, len;
|
|
|
|
int smbcmd;
|
2008-07-14 20:38:32 +00:00
|
|
|
int status;
|
2021-05-21 22:02:43 +00:00
|
|
|
unsigned long result;
|
2014-11-12 09:20:40 +00:00
|
|
|
const struct i2c_adapter *adap = &priv->adapter;
|
2008-07-14 20:38:33 +00:00
|
|
|
|
2019-06-18 17:06:50 +00:00
|
|
|
if (command == I2C_SMBUS_BLOCK_PROC_CALL)
|
|
|
|
return -EOPNOTSUPP;
|
|
|
|
|
2021-05-21 22:02:43 +00:00
|
|
|
status = i801_check_pre(priv);
|
|
|
|
if (status < 0)
|
|
|
|
return status;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-07-12 12:12:31 +00:00
|
|
|
len = data->block[0];
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (read_write == I2C_SMBUS_WRITE) {
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(len, SMBHSTDAT0(priv));
|
|
|
|
outb_p(data->block[1], SMBBLKDAT(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2012-07-24 12:13:57 +00:00
|
|
|
if (command == I2C_SMBUS_I2C_BLOCK_DATA &&
|
|
|
|
read_write == I2C_SMBUS_READ)
|
|
|
|
smbcmd = I801_I2C_BLOCK_DATA;
|
|
|
|
else
|
|
|
|
smbcmd = I801_BLOCK_DATA;
|
|
|
|
|
2012-07-24 12:13:59 +00:00
|
|
|
if (priv->features & FEATURE_IRQ) {
|
|
|
|
priv->is_read = (read_write == I2C_SMBUS_READ);
|
|
|
|
if (len == 1 && priv->is_read)
|
|
|
|
smbcmd |= SMBHSTCNT_LAST_BYTE;
|
|
|
|
priv->cmd = smbcmd | SMBHSTCNT_INTREN;
|
|
|
|
priv->len = len;
|
|
|
|
priv->count = 0;
|
|
|
|
priv->data = &data->block[1];
|
|
|
|
|
2021-05-21 22:02:43 +00:00
|
|
|
reinit_completion(&priv->done);
|
2012-07-24 12:13:59 +00:00
|
|
|
outb_p(priv->cmd | SMBHSTCNT_START, SMBHSTCNT(priv));
|
2021-05-21 22:02:43 +00:00
|
|
|
result = wait_for_completion_timeout(&priv->done, adap->timeout);
|
|
|
|
return i801_check_post(priv, result ? priv->status : -ETIMEDOUT);
|
2012-07-24 12:13:59 +00:00
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
for (i = 1; i <= len; i++) {
|
2012-07-24 12:13:57 +00:00
|
|
|
if (i == len && read_write == I2C_SMBUS_READ)
|
2012-07-24 12:13:58 +00:00
|
|
|
smbcmd |= SMBHSTCNT_LAST_BYTE;
|
2012-07-24 12:13:58 +00:00
|
|
|
outb_p(smbcmd, SMBHSTCNT(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (i == 1)
|
2012-07-24 12:13:58 +00:00
|
|
|
outb_p(inb(SMBHSTCNT(priv)) | SMBHSTCNT_START,
|
2010-10-31 20:06:59 +00:00
|
|
|
SMBHSTCNT(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-07-24 12:13:58 +00:00
|
|
|
status = i801_wait_byte_done(priv);
|
|
|
|
if (status)
|
|
|
|
goto exit;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-27 17:14:50 +00:00
|
|
|
if (i == 1 && read_write == I2C_SMBUS_READ
|
|
|
|
&& command != I2C_SMBUS_I2C_BLOCK_DATA) {
|
2010-10-31 20:06:59 +00:00
|
|
|
len = inb_p(SMBHSTDAT0(priv));
|
2008-07-14 20:38:33 +00:00
|
|
|
if (len < 1 || len > I2C_SMBUS_BLOCK_MAX) {
|
2010-10-31 20:06:59 +00:00
|
|
|
dev_err(&priv->pci_dev->dev,
|
2008-07-14 20:38:33 +00:00
|
|
|
"Illegal SMBus block read size %d\n",
|
|
|
|
len);
|
|
|
|
/* Recover */
|
2010-10-31 20:06:59 +00:00
|
|
|
while (inb_p(SMBHSTSTS(priv)) &
|
|
|
|
SMBHSTSTS_HOST_BUSY)
|
|
|
|
outb_p(SMBHSTSTS_BYTE_DONE,
|
|
|
|
SMBHSTSTS(priv));
|
|
|
|
outb_p(SMBHSTSTS_INTR, SMBHSTSTS(priv));
|
2008-07-14 20:38:25 +00:00
|
|
|
return -EPROTO;
|
2008-07-14 20:38:33 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
data->block[0] = len;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Retrieve/store value in SMBBLKDAT */
|
|
|
|
if (read_write == I2C_SMBUS_READ)
|
2010-10-31 20:06:59 +00:00
|
|
|
data->block[i] = inb_p(SMBBLKDAT(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
if (read_write == I2C_SMBUS_WRITE && i+1 <= len)
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(data->block[i+1], SMBBLKDAT(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-14 20:38:33 +00:00
|
|
|
/* signals SMBBLKDAT ready */
|
2012-07-24 12:13:58 +00:00
|
|
|
outb_p(SMBHSTSTS_BYTE_DONE, SMBHSTSTS(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-07-14 20:38:33 +00:00
|
|
|
|
2012-07-24 12:13:58 +00:00
|
|
|
status = i801_wait_intr(priv);
|
|
|
|
exit:
|
|
|
|
return i801_check_post(priv, status);
|
2007-07-12 12:12:31 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-10-31 20:06:59 +00:00
|
|
|
static int i801_set_block_buffer_mode(struct i801_priv *priv)
|
2007-07-12 12:12:31 +00:00
|
|
|
{
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(inb_p(SMBAUXCTL(priv)) | SMBAUXCTL_E32B, SMBAUXCTL(priv));
|
|
|
|
if ((inb_p(SMBAUXCTL(priv)) & SMBAUXCTL_E32B) == 0)
|
2008-07-14 20:38:25 +00:00
|
|
|
return -EIO;
|
2007-07-12 12:12:31 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Block transaction function */
|
2021-07-27 20:25:25 +00:00
|
|
|
static int i801_block_transaction(struct i801_priv *priv, union i2c_smbus_data *data,
|
|
|
|
char read_write, int command)
|
2007-07-12 12:12:31 +00:00
|
|
|
{
|
|
|
|
int result = 0;
|
|
|
|
unsigned char hostc;
|
|
|
|
|
|
|
|
if (command == I2C_SMBUS_I2C_BLOCK_DATA) {
|
|
|
|
if (read_write == I2C_SMBUS_WRITE) {
|
|
|
|
/* set I2C_EN bit in configuration register */
|
2010-10-31 20:06:59 +00:00
|
|
|
pci_read_config_byte(priv->pci_dev, SMBHSTCFG, &hostc);
|
|
|
|
pci_write_config_byte(priv->pci_dev, SMBHSTCFG,
|
2007-07-12 12:12:31 +00:00
|
|
|
hostc | SMBHSTCFG_I2C_EN);
|
2010-10-31 20:06:59 +00:00
|
|
|
} else if (!(priv->features & FEATURE_I2C_BLOCK_READ)) {
|
|
|
|
dev_err(&priv->pci_dev->dev,
|
2008-01-27 17:14:50 +00:00
|
|
|
"I2C block read is unsupported!\n");
|
2008-07-14 20:38:25 +00:00
|
|
|
return -EOPNOTSUPP;
|
2007-07-12 12:12:31 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-01-27 17:14:50 +00:00
|
|
|
if (read_write == I2C_SMBUS_WRITE
|
|
|
|
|| command == I2C_SMBUS_I2C_BLOCK_DATA) {
|
2007-07-12 12:12:31 +00:00
|
|
|
if (data->block[0] < 1)
|
|
|
|
data->block[0] = 1;
|
|
|
|
if (data->block[0] > I2C_SMBUS_BLOCK_MAX)
|
|
|
|
data->block[0] = I2C_SMBUS_BLOCK_MAX;
|
|
|
|
} else {
|
2008-01-27 17:14:50 +00:00
|
|
|
data->block[0] = 32; /* max for SMBus block reads */
|
2007-07-12 12:12:31 +00:00
|
|
|
}
|
|
|
|
|
2010-03-13 19:56:53 +00:00
|
|
|
/* Experience has shown that the block buffer can only be used for
|
|
|
|
SMBus (not I2C) block transactions, even though the datasheet
|
|
|
|
doesn't mention this limitation. */
|
2010-10-31 20:06:59 +00:00
|
|
|
if ((priv->features & FEATURE_BLOCK_BUFFER)
|
2010-03-13 19:56:53 +00:00
|
|
|
&& command != I2C_SMBUS_I2C_BLOCK_DATA
|
2010-10-31 20:06:59 +00:00
|
|
|
&& i801_set_block_buffer_mode(priv) == 0)
|
|
|
|
result = i801_block_transaction_by_block(priv, data,
|
2019-06-18 17:06:50 +00:00
|
|
|
read_write,
|
2021-07-27 20:25:25 +00:00
|
|
|
command);
|
2007-07-12 12:12:31 +00:00
|
|
|
else
|
2010-10-31 20:06:59 +00:00
|
|
|
result = i801_block_transaction_byte_by_byte(priv, data,
|
|
|
|
read_write,
|
2021-07-27 20:25:25 +00:00
|
|
|
command);
|
2007-07-12 12:12:31 +00:00
|
|
|
|
2008-01-27 17:14:50 +00:00
|
|
|
if (command == I2C_SMBUS_I2C_BLOCK_DATA
|
|
|
|
&& read_write == I2C_SMBUS_WRITE) {
|
2005-04-16 22:20:36 +00:00
|
|
|
/* restore saved configuration register value */
|
2010-10-31 20:06:59 +00:00
|
|
|
pci_write_config_byte(priv->pci_dev, SMBHSTCFG, hostc);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2008-07-14 20:38:25 +00:00
|
|
|
/* Return negative errno on error. */
|
2010-05-21 16:40:55 +00:00
|
|
|
static s32 i801_access(struct i2c_adapter *adap, u16 addr,
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned short flags, char read_write, u8 command,
|
2010-05-21 16:40:55 +00:00
|
|
|
int size, union i2c_smbus_data *data)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2005-10-26 19:34:42 +00:00
|
|
|
int hwpec;
|
2005-04-16 22:20:36 +00:00
|
|
|
int block = 0;
|
2016-03-10 12:12:22 +00:00
|
|
|
int ret = 0, xact = 0;
|
2010-10-31 20:06:59 +00:00
|
|
|
struct i801_priv *priv = i2c_get_adapdata(adap);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
mutex_lock(&priv->acpi_lock);
|
|
|
|
if (priv->acpi_reserved) {
|
|
|
|
mutex_unlock(&priv->acpi_lock);
|
|
|
|
return -EBUSY;
|
|
|
|
}
|
|
|
|
|
2016-03-10 12:12:22 +00:00
|
|
|
pm_runtime_get_sync(&priv->pci_dev->dev);
|
|
|
|
|
2010-10-31 20:06:59 +00:00
|
|
|
hwpec = (priv->features & FEATURE_SMBUS_PEC) && (flags & I2C_CLIENT_PEC)
|
2005-10-26 19:34:42 +00:00
|
|
|
&& size != I2C_SMBUS_QUICK
|
|
|
|
&& size != I2C_SMBUS_I2C_BLOCK_DATA;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
switch (size) {
|
|
|
|
case I2C_SMBUS_QUICK:
|
|
|
|
outb_p(((addr & 0x7f) << 1) | (read_write & 0x01),
|
2010-10-31 20:06:59 +00:00
|
|
|
SMBHSTADD(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
xact = I801_QUICK;
|
|
|
|
break;
|
|
|
|
case I2C_SMBUS_BYTE:
|
|
|
|
outb_p(((addr & 0x7f) << 1) | (read_write & 0x01),
|
2010-10-31 20:06:59 +00:00
|
|
|
SMBHSTADD(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
if (read_write == I2C_SMBUS_WRITE)
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(command, SMBHSTCMD(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
xact = I801_BYTE;
|
|
|
|
break;
|
|
|
|
case I2C_SMBUS_BYTE_DATA:
|
|
|
|
outb_p(((addr & 0x7f) << 1) | (read_write & 0x01),
|
2010-10-31 20:06:59 +00:00
|
|
|
SMBHSTADD(priv));
|
|
|
|
outb_p(command, SMBHSTCMD(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
if (read_write == I2C_SMBUS_WRITE)
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(data->byte, SMBHSTDAT0(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
xact = I801_BYTE_DATA;
|
|
|
|
break;
|
|
|
|
case I2C_SMBUS_WORD_DATA:
|
|
|
|
outb_p(((addr & 0x7f) << 1) | (read_write & 0x01),
|
2010-10-31 20:06:59 +00:00
|
|
|
SMBHSTADD(priv));
|
|
|
|
outb_p(command, SMBHSTCMD(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
if (read_write == I2C_SMBUS_WRITE) {
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(data->word & 0xff, SMBHSTDAT0(priv));
|
|
|
|
outb_p((data->word & 0xff00) >> 8, SMBHSTDAT1(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
xact = I801_WORD_DATA;
|
|
|
|
break;
|
|
|
|
case I2C_SMBUS_BLOCK_DATA:
|
|
|
|
outb_p(((addr & 0x7f) << 1) | (read_write & 0x01),
|
2010-10-31 20:06:59 +00:00
|
|
|
SMBHSTADD(priv));
|
|
|
|
outb_p(command, SMBHSTCMD(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
block = 1;
|
|
|
|
break;
|
2008-01-27 17:14:50 +00:00
|
|
|
case I2C_SMBUS_I2C_BLOCK_DATA:
|
2016-10-11 11:13:27 +00:00
|
|
|
/*
|
|
|
|
* NB: page 240 of ICH5 datasheet shows that the R/#W
|
|
|
|
* bit should be cleared here, even when reading.
|
|
|
|
* However if SPD Write Disable is set (Lynx Point and later),
|
|
|
|
* the read will fail if we don't set the R/#W bit.
|
|
|
|
*/
|
|
|
|
outb_p(((addr & 0x7f) << 1) |
|
|
|
|
((priv->original_hstcfg & SMBHSTCFG_SPD_WD) ?
|
|
|
|
(read_write & 0x01) : 0),
|
|
|
|
SMBHSTADD(priv));
|
2008-01-27 17:14:50 +00:00
|
|
|
if (read_write == I2C_SMBUS_READ) {
|
|
|
|
/* NB: page 240 of ICH5 datasheet also shows
|
|
|
|
* that DATA1 is the cmd field when reading */
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(command, SMBHSTDAT1(priv));
|
2008-01-27 17:14:50 +00:00
|
|
|
} else
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(command, SMBHSTCMD(priv));
|
2008-01-27 17:14:50 +00:00
|
|
|
block = 1;
|
|
|
|
break;
|
2019-06-18 17:06:50 +00:00
|
|
|
case I2C_SMBUS_BLOCK_PROC_CALL:
|
|
|
|
/*
|
|
|
|
* Bit 0 of the slave address register always indicate a write
|
|
|
|
* command.
|
|
|
|
*/
|
|
|
|
outb_p((addr & 0x7f) << 1, SMBHSTADD(priv));
|
|
|
|
outb_p(command, SMBHSTCMD(priv));
|
|
|
|
block = 1;
|
|
|
|
break;
|
2005-04-16 22:20:36 +00:00
|
|
|
default:
|
2010-10-31 20:06:59 +00:00
|
|
|
dev_err(&priv->pci_dev->dev, "Unsupported transaction %d\n",
|
|
|
|
size);
|
2016-03-10 12:12:22 +00:00
|
|
|
ret = -EOPNOTSUPP;
|
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2007-07-12 12:12:31 +00:00
|
|
|
if (hwpec) /* enable/disable hardware PEC */
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(inb_p(SMBAUXCTL(priv)) | SMBAUXCTL_CRC, SMBAUXCTL(priv));
|
2007-07-12 12:12:31 +00:00
|
|
|
else
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(inb_p(SMBAUXCTL(priv)) & (~SMBAUXCTL_CRC),
|
|
|
|
SMBAUXCTL(priv));
|
2005-10-26 19:34:42 +00:00
|
|
|
|
2010-05-21 16:40:55 +00:00
|
|
|
if (block)
|
2021-07-27 20:25:25 +00:00
|
|
|
ret = i801_block_transaction(priv, data, read_write, size);
|
2007-07-12 12:12:31 +00:00
|
|
|
else
|
2012-07-24 12:13:58 +00:00
|
|
|
ret = i801_transaction(priv, xact);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-04-20 09:43:18 +00:00
|
|
|
/* Some BIOSes don't like it when PEC is enabled at reboot or resume
|
2007-07-12 12:12:31 +00:00
|
|
|
time, so we forcibly disable it after every transaction. Turn off
|
|
|
|
E32B for the same reason. */
|
2008-01-27 17:14:50 +00:00
|
|
|
if (hwpec || block)
|
2010-10-31 20:06:59 +00:00
|
|
|
outb_p(inb_p(SMBAUXCTL(priv)) &
|
|
|
|
~(SMBAUXCTL_CRC | SMBAUXCTL_E32B), SMBAUXCTL(priv));
|
2006-04-20 09:43:18 +00:00
|
|
|
|
2010-05-21 16:40:55 +00:00
|
|
|
if (block)
|
2016-03-10 12:12:22 +00:00
|
|
|
goto out;
|
2010-05-21 16:40:55 +00:00
|
|
|
if (ret)
|
2016-03-10 12:12:22 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
if ((read_write == I2C_SMBUS_WRITE) || (xact == I801_QUICK))
|
2016-03-10 12:12:22 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
switch (xact & 0x7f) {
|
|
|
|
case I801_BYTE: /* Result put in SMBHSTDAT0 */
|
|
|
|
case I801_BYTE_DATA:
|
2010-10-31 20:06:59 +00:00
|
|
|
data->byte = inb_p(SMBHSTDAT0(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case I801_WORD_DATA:
|
2010-10-31 20:06:59 +00:00
|
|
|
data->word = inb_p(SMBHSTDAT0(priv)) +
|
|
|
|
(inb_p(SMBHSTDAT1(priv)) << 8);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
2016-03-10 12:12:22 +00:00
|
|
|
|
|
|
|
out:
|
2021-06-06 13:55:55 +00:00
|
|
|
/* Unlock the SMBus device for use by BIOS/ACPI */
|
|
|
|
outb_p(SMBHSTSTS_INUSE_STS, SMBHSTSTS(priv));
|
|
|
|
|
2016-03-10 12:12:22 +00:00
|
|
|
pm_runtime_mark_last_busy(&priv->pci_dev->dev);
|
|
|
|
pm_runtime_put_autosuspend(&priv->pci_dev->dev);
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
mutex_unlock(&priv->acpi_lock);
|
2016-03-10 12:12:22 +00:00
|
|
|
return ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static u32 i801_func(struct i2c_adapter *adapter)
|
|
|
|
{
|
2010-10-31 20:06:59 +00:00
|
|
|
struct i801_priv *priv = i2c_get_adapdata(adapter);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
return I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE |
|
2008-01-27 17:14:50 +00:00
|
|
|
I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA |
|
|
|
|
I2C_FUNC_SMBUS_BLOCK_DATA | I2C_FUNC_SMBUS_WRITE_I2C_BLOCK |
|
2010-10-31 20:06:59 +00:00
|
|
|
((priv->features & FEATURE_SMBUS_PEC) ? I2C_FUNC_SMBUS_PEC : 0) |
|
2019-06-18 17:06:50 +00:00
|
|
|
((priv->features & FEATURE_BLOCK_PROC) ?
|
|
|
|
I2C_FUNC_SMBUS_BLOCK_PROC_CALL : 0) |
|
2010-10-31 20:06:59 +00:00
|
|
|
((priv->features & FEATURE_I2C_BLOCK_READ) ?
|
2016-06-24 14:39:49 +00:00
|
|
|
I2C_FUNC_SMBUS_READ_I2C_BLOCK : 0) |
|
|
|
|
((priv->features & FEATURE_HOST_NOTIFY) ?
|
|
|
|
I2C_FUNC_SMBUS_HOST_NOTIFY : 0);
|
|
|
|
}
|
|
|
|
|
2016-10-13 12:10:40 +00:00
|
|
|
static void i801_enable_host_notify(struct i2c_adapter *adapter)
|
2016-06-24 14:39:49 +00:00
|
|
|
{
|
|
|
|
struct i801_priv *priv = i2c_get_adapdata(adapter);
|
|
|
|
|
|
|
|
if (!(priv->features & FEATURE_HOST_NOTIFY))
|
2016-10-13 12:10:40 +00:00
|
|
|
return;
|
2016-06-24 14:39:49 +00:00
|
|
|
|
2021-11-17 09:45:09 +00:00
|
|
|
/*
|
|
|
|
* Enable host notify interrupt and block the generation of interrupt
|
|
|
|
* from the SMB_ALERT signal because the driver does not support
|
|
|
|
* SMBus Alert.
|
|
|
|
*/
|
|
|
|
outb_p(SMBSLVCMD_HST_NTFY_INTREN | SMBSLVCMD_SMBALERT_DISABLE |
|
|
|
|
priv->original_slvcmd, SMBSLVCMD(priv));
|
2016-10-13 12:10:35 +00:00
|
|
|
|
2016-06-24 14:39:49 +00:00
|
|
|
/* clear Host Notify bit to allow a new notification */
|
|
|
|
outb_p(SMBSLVSTS_HST_NTFY_STS, SMBSLVSTS(priv));
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2016-10-13 12:10:35 +00:00
|
|
|
static void i801_disable_host_notify(struct i801_priv *priv)
|
|
|
|
{
|
|
|
|
if (!(priv->features & FEATURE_HOST_NOTIFY))
|
|
|
|
return;
|
|
|
|
|
|
|
|
outb_p(priv->original_slvcmd, SMBSLVCMD(priv));
|
|
|
|
}
|
|
|
|
|
2006-09-03 20:39:46 +00:00
|
|
|
static const struct i2c_algorithm smbus_algorithm = {
|
2005-04-16 22:20:36 +00:00
|
|
|
.smbus_xfer = i801_access,
|
|
|
|
.functionality = i801_func,
|
|
|
|
};
|
|
|
|
|
2013-12-02 23:11:20 +00:00
|
|
|
static const struct pci_device_id i801_ids[] = {
|
2005-04-16 22:20:36 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801AA_3) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801AB_3) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_2) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801CA_3) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801DB_3) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801EB_3) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB_4) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH6_16) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_17) },
|
2005-04-16 22:24:45 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_17) },
|
2006-01-09 18:58:08 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_5) },
|
2006-11-22 23:19:12 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_6) },
|
2010-10-04 20:27:14 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_EP80579_1) },
|
2008-02-24 19:03:42 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_4) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_5) },
|
2010-10-04 20:27:14 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5_3400_SERIES_SMBUS) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COUGARPOINT_SMBUS) },
|
2010-10-31 20:06:59 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS) },
|
2010-10-31 20:07:00 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS_IDF0) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS_IDF1) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS_IDF2) },
|
2011-03-20 13:50:53 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DH89XXCC_SMBUS) },
|
2011-05-24 18:58:49 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_PANTHERPOINT_SMBUS) },
|
2012-03-26 19:47:19 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LYNXPOINT_SMBUS) },
|
2012-09-10 08:14:02 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_SMBUS) },
|
2013-01-30 15:25:32 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMBUS) },
|
2013-02-14 09:15:33 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS_MS0) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS_MS1) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS_MS2) },
|
2013-06-19 23:59:57 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COLETOCREEK_SMBUS) },
|
2017-02-01 16:20:59 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_GEMINILAKE_SMBUS) },
|
2014-07-17 13:04:41 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_WILDCATPOINT_SMBUS) },
|
2013-11-04 17:29:48 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP_SMBUS) },
|
2014-02-28 16:03:56 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BAYTRAIL_SMBUS) },
|
2014-08-19 14:37:28 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BRASWELL_SMBUS) },
|
2014-10-13 22:20:24 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS) },
|
2014-11-05 21:30:03 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS) },
|
2017-09-21 13:23:16 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CDF_SMBUS) },
|
2015-10-13 12:41:39 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMBUS) },
|
2020-06-18 13:42:39 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_EBG_SMBUS) },
|
2015-10-22 14:16:58 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BROXTON_SMBUS) },
|
2015-11-05 19:40:25 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LEWISBURG_SMBUS) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS) },
|
2016-09-23 08:56:01 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_KABYLAKE_PCH_H_SMBUS) },
|
2017-05-18 08:23:06 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CANNONLAKE_H_SMBUS) },
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CANNONLAKE_LP_SMBUS) },
|
2018-06-28 13:08:24 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICELAKE_LP_SMBUS) },
|
2021-10-01 17:21:54 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICELAKE_N_SMBUS) },
|
2019-03-15 10:56:49 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COMETLAKE_SMBUS) },
|
2019-10-24 10:57:26 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COMETLAKE_H_SMBUS) },
|
2020-01-16 07:46:51 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COMETLAKE_V_SMBUS) },
|
2019-06-20 10:51:26 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS) },
|
2019-07-01 13:15:34 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS) },
|
2020-06-18 13:42:40 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS) },
|
2019-11-20 15:19:32 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS) },
|
2020-09-24 13:52:17 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS) },
|
2021-01-14 14:38:11 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS) },
|
2021-04-12 13:41:12 +00:00
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_M_SMBUS) },
|
2005-04-16 22:20:36 +00:00
|
|
|
{ 0, }
|
|
|
|
};
|
|
|
|
|
2010-05-21 16:40:55 +00:00
|
|
|
MODULE_DEVICE_TABLE(pci, i801_ids);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2011-05-24 18:58:49 +00:00
|
|
|
#if defined CONFIG_X86 && defined CONFIG_DMI
|
2009-01-07 13:29:17 +00:00
|
|
|
static unsigned char apanel_addr;
|
|
|
|
|
|
|
|
/* Scan the system ROM for the signature "FJKEYINF" */
|
|
|
|
static __init const void __iomem *bios_signature(const void __iomem *bios)
|
|
|
|
{
|
|
|
|
ssize_t offset;
|
|
|
|
const unsigned char signature[] = "FJKEYINF";
|
|
|
|
|
|
|
|
for (offset = 0; offset < 0x10000; offset += 0x10) {
|
|
|
|
if (check_signature(bios + offset, signature,
|
|
|
|
sizeof(signature)-1))
|
|
|
|
return bios + offset;
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __init input_apanel_init(void)
|
|
|
|
{
|
|
|
|
void __iomem *bios;
|
|
|
|
const void __iomem *p;
|
|
|
|
|
|
|
|
bios = ioremap(0xF0000, 0x10000); /* Can't fail */
|
|
|
|
p = bios_signature(bios);
|
|
|
|
if (p) {
|
|
|
|
/* just use the first address */
|
|
|
|
apanel_addr = readb(p + 8 + 3) >> 1;
|
|
|
|
}
|
|
|
|
iounmap(bios);
|
|
|
|
}
|
|
|
|
|
2009-03-30 19:46:44 +00:00
|
|
|
struct dmi_onboard_device_info {
|
|
|
|
const char *name;
|
|
|
|
u8 type;
|
|
|
|
unsigned short i2c_addr;
|
|
|
|
const char *i2c_type;
|
|
|
|
};
|
|
|
|
|
2012-11-27 20:59:38 +00:00
|
|
|
static const struct dmi_onboard_device_info dmi_devices[] = {
|
2009-03-30 19:46:44 +00:00
|
|
|
{ "Syleus", DMI_DEV_TYPE_OTHER, 0x73, "fscsyl" },
|
|
|
|
{ "Hermes", DMI_DEV_TYPE_OTHER, 0x73, "fscher" },
|
|
|
|
{ "Hades", DMI_DEV_TYPE_OTHER, 0x73, "fschds" },
|
|
|
|
};
|
|
|
|
|
2012-11-27 20:59:38 +00:00
|
|
|
static void dmi_check_onboard_device(u8 type, const char *name,
|
|
|
|
struct i2c_adapter *adap)
|
2009-03-30 19:46:44 +00:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
struct i2c_board_info info;
|
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(dmi_devices); i++) {
|
|
|
|
/* & ~0x80, ignore enabled/disabled bit */
|
|
|
|
if ((type & ~0x80) != dmi_devices[i].type)
|
|
|
|
continue;
|
2010-07-09 14:22:51 +00:00
|
|
|
if (strcasecmp(name, dmi_devices[i].name))
|
2009-03-30 19:46:44 +00:00
|
|
|
continue;
|
|
|
|
|
|
|
|
memset(&info, 0, sizeof(struct i2c_board_info));
|
|
|
|
info.addr = dmi_devices[i].i2c_addr;
|
|
|
|
strlcpy(info.type, dmi_devices[i].i2c_type, I2C_NAME_SIZE);
|
2020-01-07 17:47:36 +00:00
|
|
|
i2c_new_client_device(adap, &info);
|
2009-03-30 19:46:44 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* We use our own function to check for onboard devices instead of
|
|
|
|
dmi_find_device() as some buggy BIOS's have the devices we are interested
|
|
|
|
in marked as disabled */
|
2012-11-27 20:59:38 +00:00
|
|
|
static void dmi_check_onboard_devices(const struct dmi_header *dm, void *adap)
|
2009-03-30 19:46:44 +00:00
|
|
|
{
|
|
|
|
int i, count;
|
|
|
|
|
|
|
|
if (dm->type != 10)
|
|
|
|
return;
|
|
|
|
|
|
|
|
count = (dm->length - sizeof(struct dmi_header)) / 2;
|
|
|
|
for (i = 0; i < count; i++) {
|
|
|
|
const u8 *d = (char *)(dm + 1) + (i * 2);
|
|
|
|
const char *name = ((char *) dm) + dm->length;
|
|
|
|
u8 type = d[0];
|
|
|
|
u8 s = d[1];
|
|
|
|
|
|
|
|
if (!s)
|
|
|
|
continue;
|
|
|
|
s--;
|
|
|
|
while (s > 0 && name[0]) {
|
|
|
|
name += strlen(name) + 1;
|
|
|
|
s--;
|
|
|
|
}
|
|
|
|
if (name[0] == 0) /* Bogus string reference */
|
|
|
|
continue;
|
|
|
|
|
|
|
|
dmi_check_onboard_device(type, name, adap);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-06 18:18:45 +00:00
|
|
|
/* NOTE: Keep this list in sync with drivers/platform/x86/dell-smo8800.c */
|
|
|
|
static const char *const acpi_smo8800_ids[] = {
|
|
|
|
"SMO8800",
|
|
|
|
"SMO8801",
|
|
|
|
"SMO8810",
|
|
|
|
"SMO8811",
|
|
|
|
"SMO8820",
|
|
|
|
"SMO8821",
|
|
|
|
"SMO8830",
|
|
|
|
"SMO8831",
|
|
|
|
};
|
|
|
|
|
|
|
|
static acpi_status check_acpi_smo88xx_device(acpi_handle obj_handle,
|
|
|
|
u32 nesting_level,
|
|
|
|
void *context,
|
|
|
|
void **return_value)
|
|
|
|
{
|
|
|
|
struct acpi_device_info *info;
|
|
|
|
acpi_status status;
|
|
|
|
char *hid;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
status = acpi_get_object_info(obj_handle, &info);
|
2019-08-16 13:17:05 +00:00
|
|
|
if (ACPI_FAILURE(status))
|
2019-06-06 18:18:45 +00:00
|
|
|
return AE_OK;
|
|
|
|
|
2019-08-16 13:17:05 +00:00
|
|
|
if (!(info->valid & ACPI_VALID_HID))
|
|
|
|
goto smo88xx_not_found;
|
|
|
|
|
2019-06-06 18:18:45 +00:00
|
|
|
hid = info->hardware_id.string;
|
|
|
|
if (!hid)
|
2019-08-16 13:17:05 +00:00
|
|
|
goto smo88xx_not_found;
|
2019-06-06 18:18:45 +00:00
|
|
|
|
2019-06-21 11:36:24 +00:00
|
|
|
i = match_string(acpi_smo8800_ids, ARRAY_SIZE(acpi_smo8800_ids), hid);
|
|
|
|
if (i < 0)
|
2019-08-16 13:17:05 +00:00
|
|
|
goto smo88xx_not_found;
|
|
|
|
|
|
|
|
kfree(info);
|
2019-06-06 18:18:45 +00:00
|
|
|
|
2021-08-06 21:15:15 +00:00
|
|
|
*return_value = NULL;
|
2019-06-21 11:36:24 +00:00
|
|
|
return AE_CTRL_TERMINATE;
|
2019-08-16 13:17:05 +00:00
|
|
|
|
|
|
|
smo88xx_not_found:
|
|
|
|
kfree(info);
|
|
|
|
return AE_OK;
|
2019-06-06 18:18:45 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static bool is_dell_system_with_lis3lv02d(void)
|
|
|
|
{
|
2021-08-06 21:15:15 +00:00
|
|
|
void *err = ERR_PTR(-ENOENT);
|
2019-06-06 18:18:45 +00:00
|
|
|
|
2021-08-06 21:15:15 +00:00
|
|
|
if (!dmi_match(DMI_SYS_VENDOR, "Dell Inc."))
|
2019-06-06 18:18:45 +00:00
|
|
|
return false;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Check that ACPI device SMO88xx is present and is functioning.
|
|
|
|
* Function acpi_get_devices() already filters all ACPI devices
|
|
|
|
* which are not present or are not functioning.
|
|
|
|
* ACPI device SMO88xx represents our ST microelectronics lis3lv02d
|
|
|
|
* accelerometer but unfortunately ACPI does not provide any other
|
|
|
|
* information (like I2C address).
|
|
|
|
*/
|
2021-08-06 21:15:15 +00:00
|
|
|
acpi_get_devices(NULL, check_acpi_smo88xx_device, NULL, &err);
|
2019-06-06 18:18:45 +00:00
|
|
|
|
2021-08-06 21:15:15 +00:00
|
|
|
return !IS_ERR(err);
|
2019-06-06 18:18:45 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Accelerometer's I2C address is not specified in DMI nor ACPI,
|
|
|
|
* so it is needed to define mapping table based on DMI product names.
|
|
|
|
*/
|
|
|
|
static const struct {
|
|
|
|
const char *dmi_product_name;
|
|
|
|
unsigned short i2c_addr;
|
|
|
|
} dell_lis3lv02d_devices[] = {
|
|
|
|
/*
|
|
|
|
* Dell platform team told us that these Latitude devices have
|
|
|
|
* ST microelectronics accelerometer at I2C address 0x29.
|
|
|
|
*/
|
|
|
|
{ "Latitude E5250", 0x29 },
|
|
|
|
{ "Latitude E5450", 0x29 },
|
|
|
|
{ "Latitude E5550", 0x29 },
|
|
|
|
{ "Latitude E6440", 0x29 },
|
|
|
|
{ "Latitude E6440 ATG", 0x29 },
|
|
|
|
{ "Latitude E6540", 0x29 },
|
|
|
|
/*
|
|
|
|
* Additional individual entries were added after verification.
|
|
|
|
*/
|
2020-09-02 04:51:37 +00:00
|
|
|
{ "Latitude 5480", 0x29 },
|
2019-06-06 18:18:45 +00:00
|
|
|
{ "Vostro V131", 0x1d },
|
|
|
|
};
|
|
|
|
|
|
|
|
static void register_dell_lis3lv02d_i2c_device(struct i801_priv *priv)
|
|
|
|
{
|
|
|
|
struct i2c_board_info info;
|
|
|
|
const char *dmi_product_name;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
dmi_product_name = dmi_get_system_info(DMI_PRODUCT_NAME);
|
|
|
|
for (i = 0; i < ARRAY_SIZE(dell_lis3lv02d_devices); ++i) {
|
|
|
|
if (strcmp(dmi_product_name,
|
|
|
|
dell_lis3lv02d_devices[i].dmi_product_name) == 0)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (i == ARRAY_SIZE(dell_lis3lv02d_devices)) {
|
|
|
|
dev_warn(&priv->pci_dev->dev,
|
|
|
|
"Accelerometer lis3lv02d is present on SMBus but its"
|
|
|
|
" address is unknown, skipping registration\n");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
memset(&info, 0, sizeof(struct i2c_board_info));
|
|
|
|
info.addr = dell_lis3lv02d_devices[i].i2c_addr;
|
|
|
|
strlcpy(info.type, "lis3lv02d", I2C_NAME_SIZE);
|
2020-01-07 17:47:36 +00:00
|
|
|
i2c_new_client_device(&priv->adapter, &info);
|
2019-06-06 18:18:45 +00:00
|
|
|
}
|
|
|
|
|
2011-05-24 18:58:49 +00:00
|
|
|
/* Register optional slaves */
|
2012-11-27 20:59:38 +00:00
|
|
|
static void i801_probe_optional_slaves(struct i801_priv *priv)
|
2011-05-24 18:58:49 +00:00
|
|
|
{
|
|
|
|
/* Only register slaves on main SMBus channel */
|
|
|
|
if (priv->features & FEATURE_IDF)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (apanel_addr) {
|
2021-05-25 20:01:31 +00:00
|
|
|
struct i2c_board_info info = {
|
|
|
|
.addr = apanel_addr,
|
|
|
|
.type = "fujitsu_apanel",
|
|
|
|
};
|
2011-05-24 18:58:49 +00:00
|
|
|
|
2020-01-07 17:47:36 +00:00
|
|
|
i2c_new_client_device(&priv->adapter, &info);
|
2011-05-24 18:58:49 +00:00
|
|
|
}
|
2011-05-24 18:58:49 +00:00
|
|
|
|
2011-05-24 18:58:49 +00:00
|
|
|
if (dmi_name_in_vendors("FUJITSU"))
|
|
|
|
dmi_walk(dmi_check_onboard_devices, &priv->adapter);
|
2019-06-06 18:18:45 +00:00
|
|
|
|
|
|
|
if (is_dell_system_with_lis3lv02d())
|
|
|
|
register_dell_lis3lv02d_i2c_device(priv);
|
2020-03-16 10:24:48 +00:00
|
|
|
|
|
|
|
/* Instantiate SPD EEPROMs unless the SMBus is multiplexed */
|
|
|
|
#if IS_ENABLED(CONFIG_I2C_MUX_GPIO)
|
|
|
|
if (!priv->mux_drvdata)
|
|
|
|
#endif
|
|
|
|
i2c_register_spd(&priv->adapter);
|
2011-05-24 18:58:49 +00:00
|
|
|
}
|
2011-05-24 18:58:49 +00:00
|
|
|
#else
|
|
|
|
static void __init input_apanel_init(void) {}
|
2012-11-27 20:59:38 +00:00
|
|
|
static void i801_probe_optional_slaves(struct i801_priv *priv) {}
|
2011-05-24 18:58:49 +00:00
|
|
|
#endif /* CONFIG_X86 && CONFIG_DMI */
|
2011-05-24 18:58:49 +00:00
|
|
|
|
2016-07-21 16:11:01 +00:00
|
|
|
#if IS_ENABLED(CONFIG_I2C_MUX_GPIO) && defined CONFIG_DMI
|
2012-10-05 20:23:53 +00:00
|
|
|
static struct i801_mux_config i801_mux_config_asus_z8_d12 = {
|
|
|
|
.gpio_chip = "gpio_ich",
|
|
|
|
.values = { 0x02, 0x03 },
|
|
|
|
.n_values = 2,
|
|
|
|
.classes = { I2C_CLASS_SPD, I2C_CLASS_SPD },
|
|
|
|
.gpios = { 52, 53 },
|
|
|
|
.n_gpios = 2,
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct i801_mux_config i801_mux_config_asus_z8_d18 = {
|
|
|
|
.gpio_chip = "gpio_ich",
|
|
|
|
.values = { 0x02, 0x03, 0x01 },
|
|
|
|
.n_values = 3,
|
|
|
|
.classes = { I2C_CLASS_SPD, I2C_CLASS_SPD, I2C_CLASS_SPD },
|
|
|
|
.gpios = { 52, 53 },
|
|
|
|
.n_gpios = 2,
|
|
|
|
};
|
|
|
|
|
2012-11-27 20:59:38 +00:00
|
|
|
static const struct dmi_system_id mux_dmi_table[] = {
|
2012-10-05 20:23:53 +00:00
|
|
|
{
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
|
|
|
|
DMI_MATCH(DMI_BOARD_NAME, "Z8NA-D6(C)"),
|
|
|
|
},
|
|
|
|
.driver_data = &i801_mux_config_asus_z8_d12,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
|
|
|
|
DMI_MATCH(DMI_BOARD_NAME, "Z8P(N)E-D12(X)"),
|
|
|
|
},
|
|
|
|
.driver_data = &i801_mux_config_asus_z8_d12,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
|
|
|
|
DMI_MATCH(DMI_BOARD_NAME, "Z8NH-D12"),
|
|
|
|
},
|
|
|
|
.driver_data = &i801_mux_config_asus_z8_d12,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
|
|
|
|
DMI_MATCH(DMI_BOARD_NAME, "Z8PH-D12/IFB"),
|
|
|
|
},
|
|
|
|
.driver_data = &i801_mux_config_asus_z8_d12,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
|
|
|
|
DMI_MATCH(DMI_BOARD_NAME, "Z8NR-D12"),
|
|
|
|
},
|
|
|
|
.driver_data = &i801_mux_config_asus_z8_d12,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
|
|
|
|
DMI_MATCH(DMI_BOARD_NAME, "Z8P(N)H-D12"),
|
|
|
|
},
|
|
|
|
.driver_data = &i801_mux_config_asus_z8_d12,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
|
|
|
|
DMI_MATCH(DMI_BOARD_NAME, "Z8PG-D18"),
|
|
|
|
},
|
|
|
|
.driver_data = &i801_mux_config_asus_z8_d18,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
|
|
|
|
DMI_MATCH(DMI_BOARD_NAME, "Z8PE-D18"),
|
|
|
|
},
|
|
|
|
.driver_data = &i801_mux_config_asus_z8_d18,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.matches = {
|
|
|
|
DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
|
|
|
|
DMI_MATCH(DMI_BOARD_NAME, "Z8PS-D12"),
|
|
|
|
},
|
|
|
|
.driver_data = &i801_mux_config_asus_z8_d12,
|
|
|
|
},
|
|
|
|
{ }
|
|
|
|
};
|
|
|
|
|
|
|
|
/* Setup multiplexing if needed */
|
2021-08-06 21:17:10 +00:00
|
|
|
static void i801_add_mux(struct i801_priv *priv)
|
2012-10-05 20:23:53 +00:00
|
|
|
{
|
|
|
|
struct device *dev = &priv->adapter.dev;
|
|
|
|
const struct i801_mux_config *mux_config;
|
|
|
|
struct i2c_mux_gpio_platform_data gpio_data;
|
2019-06-18 10:58:33 +00:00
|
|
|
struct gpiod_lookup_table *lookup;
|
2020-12-28 20:06:18 +00:00
|
|
|
int i;
|
2012-10-05 20:23:53 +00:00
|
|
|
|
|
|
|
if (!priv->mux_drvdata)
|
2021-08-06 21:17:10 +00:00
|
|
|
return;
|
2012-10-05 20:23:53 +00:00
|
|
|
mux_config = priv->mux_drvdata;
|
|
|
|
|
|
|
|
/* Prepare the platform data */
|
|
|
|
memset(&gpio_data, 0, sizeof(struct i2c_mux_gpio_platform_data));
|
|
|
|
gpio_data.parent = priv->adapter.nr;
|
|
|
|
gpio_data.values = mux_config->values;
|
|
|
|
gpio_data.n_values = mux_config->n_values;
|
|
|
|
gpio_data.classes = mux_config->classes;
|
|
|
|
gpio_data.idle = I2C_MUX_GPIO_NO_IDLE;
|
|
|
|
|
2019-06-18 10:58:33 +00:00
|
|
|
/* Register GPIO descriptor lookup table */
|
|
|
|
lookup = devm_kzalloc(dev,
|
2020-12-21 13:42:25 +00:00
|
|
|
struct_size(lookup, table, mux_config->n_gpios + 1),
|
2019-06-18 10:58:33 +00:00
|
|
|
GFP_KERNEL);
|
|
|
|
if (!lookup)
|
2021-08-06 21:17:10 +00:00
|
|
|
return;
|
2019-06-18 10:58:33 +00:00
|
|
|
lookup->dev_id = "i2c-mux-gpio";
|
2021-08-06 21:17:10 +00:00
|
|
|
for (i = 0; i < mux_config->n_gpios; i++)
|
|
|
|
lookup->table[i] = GPIO_LOOKUP(mux_config->gpio_chip,
|
|
|
|
mux_config->gpios[i], "mux", 0);
|
2019-06-18 10:58:33 +00:00
|
|
|
gpiod_add_lookup_table(lookup);
|
|
|
|
priv->lookup = lookup;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Register the mux device, we use PLATFORM_DEVID_NONE here
|
|
|
|
* because since we are referring to the GPIO chip by name we are
|
|
|
|
* anyways in deep trouble if there is more than one of these
|
|
|
|
* devices, and there should likely only be one platform controller
|
|
|
|
* hub.
|
|
|
|
*/
|
2012-10-05 20:23:53 +00:00
|
|
|
priv->mux_pdev = platform_device_register_data(dev, "i2c-mux-gpio",
|
2019-06-18 10:58:33 +00:00
|
|
|
PLATFORM_DEVID_NONE, &gpio_data,
|
2012-10-05 20:23:53 +00:00
|
|
|
sizeof(struct i2c_mux_gpio_platform_data));
|
|
|
|
if (IS_ERR(priv->mux_pdev)) {
|
2019-06-18 10:58:33 +00:00
|
|
|
gpiod_remove_lookup_table(lookup);
|
2012-10-05 20:23:53 +00:00
|
|
|
dev_err(dev, "Failed to register i2c-mux-gpio device\n");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-11-27 20:59:38 +00:00
|
|
|
static void i801_del_mux(struct i801_priv *priv)
|
2012-10-05 20:23:53 +00:00
|
|
|
{
|
2020-12-28 20:06:18 +00:00
|
|
|
platform_device_unregister(priv->mux_pdev);
|
2020-12-28 20:06:17 +00:00
|
|
|
gpiod_remove_lookup_table(priv->lookup);
|
2012-10-05 20:23:53 +00:00
|
|
|
}
|
|
|
|
|
2012-11-27 20:59:38 +00:00
|
|
|
static unsigned int i801_get_adapter_class(struct i801_priv *priv)
|
2012-10-05 20:23:53 +00:00
|
|
|
{
|
|
|
|
const struct dmi_system_id *id;
|
|
|
|
const struct i801_mux_config *mux_config;
|
|
|
|
unsigned int class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
id = dmi_first_match(mux_dmi_table);
|
|
|
|
if (id) {
|
2012-10-28 20:37:01 +00:00
|
|
|
/* Remove branch classes from trunk */
|
2012-10-05 20:23:53 +00:00
|
|
|
mux_config = id->driver_data;
|
|
|
|
for (i = 0; i < mux_config->n_values; i++)
|
|
|
|
class &= ~mux_config->classes[i];
|
|
|
|
|
|
|
|
/* Remember for later */
|
|
|
|
priv->mux_drvdata = mux_config;
|
|
|
|
}
|
|
|
|
|
|
|
|
return class;
|
|
|
|
}
|
|
|
|
#else
|
2021-08-06 21:17:10 +00:00
|
|
|
static inline void i801_add_mux(struct i801_priv *priv) { }
|
2012-10-05 20:23:53 +00:00
|
|
|
static inline void i801_del_mux(struct i801_priv *priv) { }
|
|
|
|
|
|
|
|
static inline unsigned int i801_get_adapter_class(struct i801_priv *priv)
|
|
|
|
{
|
|
|
|
return I2C_CLASS_HWMON | I2C_CLASS_SPD;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2019-08-31 14:24:02 +00:00
|
|
|
static const struct itco_wdt_platform_data spt_tco_platform_data = {
|
2015-08-06 12:46:25 +00:00
|
|
|
.name = "Intel PCH",
|
|
|
|
.version = 4,
|
|
|
|
};
|
|
|
|
|
2019-08-31 14:24:02 +00:00
|
|
|
static struct platform_device *
|
|
|
|
i801_add_tco_spt(struct i801_priv *priv, struct pci_dev *pci_dev,
|
|
|
|
struct resource *tco_res)
|
2015-08-06 12:46:25 +00:00
|
|
|
{
|
2019-08-31 14:24:02 +00:00
|
|
|
struct resource *res;
|
2015-08-06 12:46:25 +00:00
|
|
|
unsigned int devfn;
|
|
|
|
u64 base64_addr;
|
2019-08-31 14:24:02 +00:00
|
|
|
u32 base_addr;
|
2017-08-14 16:04:50 +00:00
|
|
|
u8 hidden;
|
2015-08-06 12:46:25 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We must access the NO_REBOOT bit over the Primary to Sideband
|
|
|
|
* bridge (P2SB). The BIOS prevents the P2SB device from being
|
|
|
|
* enumerated by the PCI subsystem, so we need to unhide/hide it
|
|
|
|
* to lookup the P2SB BAR.
|
|
|
|
*/
|
2021-09-05 15:59:42 +00:00
|
|
|
pci_lock_rescan_remove();
|
2015-08-06 12:46:25 +00:00
|
|
|
|
|
|
|
devfn = PCI_DEVFN(PCI_SLOT(pci_dev->devfn), 1);
|
|
|
|
|
2017-08-14 16:04:50 +00:00
|
|
|
/* Unhide the P2SB device, if it is hidden */
|
|
|
|
pci_bus_read_config_byte(pci_dev->bus, devfn, 0xe1, &hidden);
|
|
|
|
if (hidden)
|
|
|
|
pci_bus_write_config_byte(pci_dev->bus, devfn, 0xe1, 0x0);
|
2015-08-06 12:46:25 +00:00
|
|
|
|
|
|
|
pci_bus_read_config_dword(pci_dev->bus, devfn, SBREG_BAR, &base_addr);
|
|
|
|
base64_addr = base_addr & 0xfffffff0;
|
|
|
|
|
|
|
|
pci_bus_read_config_dword(pci_dev->bus, devfn, SBREG_BAR + 0x4, &base_addr);
|
|
|
|
base64_addr |= (u64)base_addr << 32;
|
|
|
|
|
2017-08-14 16:04:50 +00:00
|
|
|
/* Hide the P2SB device, if it was hidden before */
|
|
|
|
if (hidden)
|
|
|
|
pci_bus_write_config_byte(pci_dev->bus, devfn, 0xe1, hidden);
|
2021-09-05 15:59:42 +00:00
|
|
|
pci_unlock_rescan_remove();
|
2015-08-06 12:46:25 +00:00
|
|
|
|
2020-02-26 13:21:22 +00:00
|
|
|
res = &tco_res[1];
|
2018-09-03 08:24:57 +00:00
|
|
|
if (pci_dev->device == PCI_DEVICE_ID_INTEL_DNV_SMBUS)
|
|
|
|
res->start = (resource_size_t)base64_addr + SBREG_SMBCTRL_DNV;
|
|
|
|
else
|
|
|
|
res->start = (resource_size_t)base64_addr + SBREG_SMBCTRL;
|
|
|
|
|
2015-08-06 12:46:25 +00:00
|
|
|
res->end = res->start + 3;
|
|
|
|
res->flags = IORESOURCE_MEM;
|
|
|
|
|
2019-08-31 14:24:02 +00:00
|
|
|
return platform_device_register_resndata(&pci_dev->dev, "iTCO_wdt", -1,
|
2020-02-26 13:21:22 +00:00
|
|
|
tco_res, 2, &spt_tco_platform_data,
|
2019-08-31 14:24:02 +00:00
|
|
|
sizeof(spt_tco_platform_data));
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct itco_wdt_platform_data cnl_tco_platform_data = {
|
|
|
|
.name = "Intel PCH",
|
|
|
|
.version = 6,
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct platform_device *
|
|
|
|
i801_add_tco_cnl(struct i801_priv *priv, struct pci_dev *pci_dev,
|
|
|
|
struct resource *tco_res)
|
|
|
|
{
|
2020-02-26 13:21:22 +00:00
|
|
|
return platform_device_register_resndata(&pci_dev->dev,
|
|
|
|
"iTCO_wdt", -1, tco_res, 1, &cnl_tco_platform_data,
|
|
|
|
sizeof(cnl_tco_platform_data));
|
2019-08-31 14:24:02 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void i801_add_tco(struct i801_priv *priv)
|
|
|
|
{
|
|
|
|
struct pci_dev *pci_dev = priv->pci_dev;
|
2020-02-26 13:21:22 +00:00
|
|
|
struct resource tco_res[2], *res;
|
|
|
|
u32 tco_base, tco_ctl;
|
2019-08-31 14:24:02 +00:00
|
|
|
|
|
|
|
/* If we have ACPI based watchdog use that instead */
|
|
|
|
if (acpi_has_watchdog())
|
2015-08-06 12:46:25 +00:00
|
|
|
return;
|
|
|
|
|
2019-08-31 14:24:02 +00:00
|
|
|
if (!(priv->features & (FEATURE_TCO_SPT | FEATURE_TCO_CNL)))
|
2015-08-06 12:46:25 +00:00
|
|
|
return;
|
|
|
|
|
2019-08-31 14:24:02 +00:00
|
|
|
pci_read_config_dword(pci_dev, TCOBASE, &tco_base);
|
|
|
|
pci_read_config_dword(pci_dev, TCOCTL, &tco_ctl);
|
|
|
|
if (!(tco_ctl & TCOCTL_EN))
|
|
|
|
return;
|
|
|
|
|
|
|
|
memset(tco_res, 0, sizeof(tco_res));
|
|
|
|
/*
|
2020-02-26 13:21:22 +00:00
|
|
|
* Always populate the main iTCO IO resource here. The second entry
|
|
|
|
* for NO_REBOOT MMIO is filled by the SPT specific function.
|
2019-08-31 14:24:02 +00:00
|
|
|
*/
|
2020-02-26 13:21:22 +00:00
|
|
|
res = &tco_res[0];
|
|
|
|
res->start = tco_base & ~1;
|
|
|
|
res->end = res->start + 32 - 1;
|
2019-08-31 14:24:02 +00:00
|
|
|
res->flags = IORESOURCE_IO;
|
|
|
|
|
|
|
|
if (priv->features & FEATURE_TCO_CNL)
|
|
|
|
priv->tco_pdev = i801_add_tco_cnl(priv, pci_dev, tco_res);
|
|
|
|
else
|
|
|
|
priv->tco_pdev = i801_add_tco_spt(priv, pci_dev, tco_res);
|
|
|
|
|
|
|
|
if (IS_ERR(priv->tco_pdev))
|
|
|
|
dev_warn(&pci_dev->dev, "failed to create iTCO device\n");
|
2015-08-06 12:46:25 +00:00
|
|
|
}
|
|
|
|
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
#ifdef CONFIG_ACPI
|
i2c: i801: Allow ACPI AML access I/O ports not reserved for SMBus
Commit 7ae81952cda ("i2c: i801: Allow ACPI SystemIO OpRegion to conflict
with PCI BAR") made it possible for AML code to access SMBus I/O ports
by installing custom SystemIO OpRegion handler and blocking i80i driver
access upon first AML read/write to this OpRegion.
However, while ThinkPad T560 does have SystemIO OpRegion declared under
the SMBus device, it does not access any of the SMBus registers:
Device (SMBU)
{
...
OperationRegion (SMBP, PCI_Config, 0x50, 0x04)
Field (SMBP, DWordAcc, NoLock, Preserve)
{
, 5,
TCOB, 11,
Offset (0x04)
}
Name (TCBV, 0x00)
Method (TCBS, 0, NotSerialized)
{
If ((TCBV == 0x00))
{
TCBV = (\_SB.PCI0.SMBU.TCOB << 0x05)
}
Return (TCBV) /* \_SB_.PCI0.SMBU.TCBV */
}
OperationRegion (TCBA, SystemIO, TCBS (), 0x10)
Field (TCBA, ByteAcc, NoLock, Preserve)
{
Offset (0x04),
, 9,
CPSC, 1
}
}
Problem with the current approach is that it blocks all I/O port access
and because this system has touchpad connected to the SMBus controller
after first AML access (happens during suspend/resume cycle) the
touchpad fails to work anymore.
Fix this so that we allow ACPI AML I/O port access if it does not touch
the region reserved for the SMBus.
Fixes: 7ae81952cda ("i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=200737
Reported-by: Yussuf Khalil <dev@pp3345.net>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2018-08-30 08:50:13 +00:00
|
|
|
static bool i801_acpi_is_smbus_ioport(const struct i801_priv *priv,
|
|
|
|
acpi_physical_address address)
|
|
|
|
{
|
|
|
|
return address >= priv->smba &&
|
|
|
|
address <= pci_resource_end(priv->pci_dev, SMBBAR);
|
|
|
|
}
|
|
|
|
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
static acpi_status
|
|
|
|
i801_acpi_io_handler(u32 function, acpi_physical_address address, u32 bits,
|
|
|
|
u64 *value, void *handler_context, void *region_context)
|
|
|
|
{
|
|
|
|
struct i801_priv *priv = handler_context;
|
|
|
|
struct pci_dev *pdev = priv->pci_dev;
|
|
|
|
acpi_status status;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Once BIOS AML code touches the OpRegion we warn and inhibit any
|
|
|
|
* further access from the driver itself. This device is now owned
|
|
|
|
* by the system firmware.
|
|
|
|
*/
|
|
|
|
mutex_lock(&priv->acpi_lock);
|
|
|
|
|
i2c: i801: Allow ACPI AML access I/O ports not reserved for SMBus
Commit 7ae81952cda ("i2c: i801: Allow ACPI SystemIO OpRegion to conflict
with PCI BAR") made it possible for AML code to access SMBus I/O ports
by installing custom SystemIO OpRegion handler and blocking i80i driver
access upon first AML read/write to this OpRegion.
However, while ThinkPad T560 does have SystemIO OpRegion declared under
the SMBus device, it does not access any of the SMBus registers:
Device (SMBU)
{
...
OperationRegion (SMBP, PCI_Config, 0x50, 0x04)
Field (SMBP, DWordAcc, NoLock, Preserve)
{
, 5,
TCOB, 11,
Offset (0x04)
}
Name (TCBV, 0x00)
Method (TCBS, 0, NotSerialized)
{
If ((TCBV == 0x00))
{
TCBV = (\_SB.PCI0.SMBU.TCOB << 0x05)
}
Return (TCBV) /* \_SB_.PCI0.SMBU.TCBV */
}
OperationRegion (TCBA, SystemIO, TCBS (), 0x10)
Field (TCBA, ByteAcc, NoLock, Preserve)
{
Offset (0x04),
, 9,
CPSC, 1
}
}
Problem with the current approach is that it blocks all I/O port access
and because this system has touchpad connected to the SMBus controller
after first AML access (happens during suspend/resume cycle) the
touchpad fails to work anymore.
Fix this so that we allow ACPI AML I/O port access if it does not touch
the region reserved for the SMBus.
Fixes: 7ae81952cda ("i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=200737
Reported-by: Yussuf Khalil <dev@pp3345.net>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2018-08-30 08:50:13 +00:00
|
|
|
if (!priv->acpi_reserved && i801_acpi_is_smbus_ioport(priv, address)) {
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
priv->acpi_reserved = true;
|
|
|
|
|
|
|
|
dev_warn(&pdev->dev, "BIOS is accessing SMBus registers\n");
|
|
|
|
dev_warn(&pdev->dev, "Driver SMBus register access inhibited\n");
|
|
|
|
|
|
|
|
/*
|
|
|
|
* BIOS is accessing the host controller so prevent it from
|
|
|
|
* suspending automatically from now on.
|
|
|
|
*/
|
2021-09-07 20:33:02 +00:00
|
|
|
pm_runtime_get_sync(&pdev->dev);
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if ((function & ACPI_IO_MASK) == ACPI_READ)
|
|
|
|
status = acpi_os_read_port(address, (u32 *)value, bits);
|
|
|
|
else
|
|
|
|
status = acpi_os_write_port(address, (u32)*value, bits);
|
|
|
|
|
|
|
|
mutex_unlock(&priv->acpi_lock);
|
|
|
|
|
|
|
|
return status;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int i801_acpi_probe(struct i801_priv *priv)
|
|
|
|
{
|
2021-08-06 21:16:33 +00:00
|
|
|
acpi_handle ah = ACPI_HANDLE(&priv->pci_dev->dev);
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
acpi_status status;
|
|
|
|
|
2021-08-06 21:16:33 +00:00
|
|
|
status = acpi_install_address_space_handler(ah, ACPI_ADR_SPACE_SYSTEM_IO,
|
|
|
|
i801_acpi_io_handler, NULL, priv);
|
|
|
|
if (ACPI_SUCCESS(status))
|
|
|
|
return 0;
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
|
|
|
|
return acpi_check_resource_conflict(&priv->pci_dev->resource[SMBBAR]);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void i801_acpi_remove(struct i801_priv *priv)
|
|
|
|
{
|
2021-08-06 21:16:33 +00:00
|
|
|
acpi_handle ah = ACPI_HANDLE(&priv->pci_dev->dev);
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
|
2021-08-06 21:16:33 +00:00
|
|
|
acpi_remove_address_space_handler(ah, ACPI_ADR_SPACE_SYSTEM_IO, i801_acpi_io_handler);
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
}
|
|
|
|
#else
|
|
|
|
static inline int i801_acpi_probe(struct i801_priv *priv) { return 0; }
|
|
|
|
static inline void i801_acpi_remove(struct i801_priv *priv) { }
|
|
|
|
#endif
|
|
|
|
|
2021-05-25 20:07:17 +00:00
|
|
|
static void i801_setup_hstcfg(struct i801_priv *priv)
|
2020-09-01 13:22:21 +00:00
|
|
|
{
|
|
|
|
unsigned char hstcfg = priv->original_hstcfg;
|
|
|
|
|
|
|
|
hstcfg &= ~SMBHSTCFG_I2C_EN; /* SMBus timing */
|
|
|
|
hstcfg |= SMBHSTCFG_HST_EN;
|
|
|
|
pci_write_config_byte(priv->pci_dev, SMBHSTCFG, hstcfg);
|
|
|
|
}
|
|
|
|
|
2012-11-27 20:59:38 +00:00
|
|
|
static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2010-05-21 16:40:54 +00:00
|
|
|
int err, i;
|
2010-10-31 20:06:59 +00:00
|
|
|
struct i801_priv *priv;
|
|
|
|
|
2015-02-13 13:52:23 +00:00
|
|
|
priv = devm_kzalloc(&dev->dev, sizeof(*priv), GFP_KERNEL);
|
2010-10-31 20:06:59 +00:00
|
|
|
if (!priv)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
i2c_set_adapdata(&priv->adapter, priv);
|
|
|
|
priv->adapter.owner = THIS_MODULE;
|
2012-10-05 20:23:53 +00:00
|
|
|
priv->adapter.class = i801_get_adapter_class(priv);
|
2010-10-31 20:06:59 +00:00
|
|
|
priv->adapter.algo = &smbus_algorithm;
|
2015-10-23 19:27:07 +00:00
|
|
|
priv->adapter.dev.parent = &dev->dev;
|
|
|
|
ACPI_COMPANION_SET(&priv->adapter.dev, ACPI_COMPANION(&dev->dev));
|
|
|
|
priv->adapter.retries = 3;
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
mutex_init(&priv->acpi_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-10-31 20:06:59 +00:00
|
|
|
priv->pci_dev = dev;
|
2006-12-10 20:21:33 +00:00
|
|
|
switch (dev->device) {
|
2015-08-06 12:46:25 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS:
|
|
|
|
case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS:
|
2016-02-18 02:21:21 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_LEWISBURG_SMBUS:
|
|
|
|
case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS:
|
2015-10-13 12:41:39 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
|
2016-09-23 08:56:01 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_KABYLAKE_PCH_H_SMBUS:
|
2020-01-16 07:46:51 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_COMETLAKE_V_SMBUS:
|
2019-09-27 11:09:11 +00:00
|
|
|
priv->features |= FEATURE_BLOCK_PROC;
|
2019-08-31 14:24:02 +00:00
|
|
|
priv->features |= FEATURE_I2C_BLOCK_READ;
|
|
|
|
priv->features |= FEATURE_IRQ;
|
|
|
|
priv->features |= FEATURE_SMBUS_PEC;
|
|
|
|
priv->features |= FEATURE_BLOCK_BUFFER;
|
|
|
|
priv->features |= FEATURE_TCO_SPT;
|
|
|
|
priv->features |= FEATURE_HOST_NOTIFY;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case PCI_DEVICE_ID_INTEL_CANNONLAKE_H_SMBUS:
|
|
|
|
case PCI_DEVICE_ID_INTEL_CANNONLAKE_LP_SMBUS:
|
|
|
|
case PCI_DEVICE_ID_INTEL_CDF_SMBUS:
|
2018-06-28 13:08:24 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_ICELAKE_LP_SMBUS:
|
2021-10-01 17:21:54 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_ICELAKE_N_SMBUS:
|
2019-03-15 10:56:49 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_COMETLAKE_SMBUS:
|
2019-10-24 10:57:26 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_COMETLAKE_H_SMBUS:
|
2019-06-20 10:51:26 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS:
|
2019-07-01 13:15:34 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS:
|
2020-06-18 13:42:40 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS:
|
2019-11-20 15:19:32 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS:
|
2020-06-18 13:42:39 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_EBG_SMBUS:
|
2020-09-24 13:52:17 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS:
|
2021-01-14 14:38:11 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS:
|
2021-04-12 13:41:12 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_ALDER_LAKE_M_SMBUS:
|
2019-06-18 17:06:50 +00:00
|
|
|
priv->features |= FEATURE_BLOCK_PROC;
|
2015-08-06 12:46:25 +00:00
|
|
|
priv->features |= FEATURE_I2C_BLOCK_READ;
|
|
|
|
priv->features |= FEATURE_IRQ;
|
|
|
|
priv->features |= FEATURE_SMBUS_PEC;
|
|
|
|
priv->features |= FEATURE_BLOCK_BUFFER;
|
2019-08-31 14:24:02 +00:00
|
|
|
priv->features |= FEATURE_TCO_CNL;
|
2016-06-24 14:39:49 +00:00
|
|
|
priv->features |= FEATURE_HOST_NOTIFY;
|
2015-08-06 12:46:25 +00:00
|
|
|
break;
|
|
|
|
|
2011-05-24 18:58:49 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS_IDF0:
|
|
|
|
case PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS_IDF1:
|
|
|
|
case PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS_IDF2:
|
2013-02-14 09:15:33 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS_MS0:
|
|
|
|
case PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS_MS1:
|
|
|
|
case PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS_MS2:
|
2011-05-24 18:58:49 +00:00
|
|
|
priv->features |= FEATURE_IDF;
|
2020-07-21 23:05:10 +00:00
|
|
|
fallthrough;
|
2010-05-21 16:40:55 +00:00
|
|
|
default:
|
2019-06-18 17:06:50 +00:00
|
|
|
priv->features |= FEATURE_BLOCK_PROC;
|
2010-10-31 20:06:59 +00:00
|
|
|
priv->features |= FEATURE_I2C_BLOCK_READ;
|
2012-12-16 20:11:55 +00:00
|
|
|
priv->features |= FEATURE_IRQ;
|
2020-07-21 23:05:10 +00:00
|
|
|
fallthrough;
|
2008-01-27 17:14:50 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_82801DB_3:
|
2010-10-31 20:06:59 +00:00
|
|
|
priv->features |= FEATURE_SMBUS_PEC;
|
|
|
|
priv->features |= FEATURE_BLOCK_BUFFER;
|
2020-07-21 23:05:10 +00:00
|
|
|
fallthrough;
|
2010-05-21 16:40:55 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_82801CA_3:
|
2016-06-24 14:39:49 +00:00
|
|
|
priv->features |= FEATURE_HOST_NOTIFY;
|
2020-07-21 23:05:10 +00:00
|
|
|
fallthrough;
|
2010-05-21 16:40:55 +00:00
|
|
|
case PCI_DEVICE_ID_INTEL_82801BA_2:
|
|
|
|
case PCI_DEVICE_ID_INTEL_82801AB_3:
|
|
|
|
case PCI_DEVICE_ID_INTEL_82801AA_3:
|
2006-12-10 20:21:33 +00:00
|
|
|
break;
|
|
|
|
}
|
2006-06-12 19:53:41 +00:00
|
|
|
|
2010-05-21 16:40:54 +00:00
|
|
|
/* Disable features on user request */
|
|
|
|
for (i = 0; i < ARRAY_SIZE(i801_feature_names); i++) {
|
2010-10-31 20:06:59 +00:00
|
|
|
if (priv->features & disable_features & (1 << i))
|
2010-05-21 16:40:54 +00:00
|
|
|
dev_notice(&dev->dev, "%s disabled by user\n",
|
|
|
|
i801_feature_names[i]);
|
|
|
|
}
|
2010-10-31 20:06:59 +00:00
|
|
|
priv->features &= ~disable_features;
|
2010-05-21 16:40:54 +00:00
|
|
|
|
2015-02-13 13:52:25 +00:00
|
|
|
err = pcim_enable_device(dev);
|
2006-06-12 19:53:41 +00:00
|
|
|
if (err) {
|
|
|
|
dev_err(&dev->dev, "Failed to enable SMBus PCI device (%d)\n",
|
|
|
|
err);
|
2015-02-13 13:52:25 +00:00
|
|
|
return err;
|
2006-06-12 19:53:41 +00:00
|
|
|
}
|
2015-02-13 13:52:25 +00:00
|
|
|
pcim_pin_device(dev);
|
2006-06-12 19:53:41 +00:00
|
|
|
|
|
|
|
/* Determine the address of the SMBus area */
|
2010-10-31 20:06:59 +00:00
|
|
|
priv->smba = pci_resource_start(dev, SMBBAR);
|
|
|
|
if (!priv->smba) {
|
2015-02-13 13:52:21 +00:00
|
|
|
dev_err(&dev->dev,
|
|
|
|
"SMBus base address uninitialized, upgrade BIOS\n");
|
2015-02-13 13:52:25 +00:00
|
|
|
return -ENODEV;
|
2006-06-12 19:53:41 +00:00
|
|
|
}
|
|
|
|
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
if (i801_acpi_probe(priv))
|
2015-02-13 13:52:25 +00:00
|
|
|
return -ENODEV;
|
2008-07-14 20:38:33 +00:00
|
|
|
|
2021-05-25 20:04:23 +00:00
|
|
|
err = pcim_iomap_regions(dev, 1 << SMBBAR, DRV_NAME);
|
2006-06-12 19:53:41 +00:00
|
|
|
if (err) {
|
2015-02-13 13:52:21 +00:00
|
|
|
dev_err(&dev->dev,
|
|
|
|
"Failed to request SMBus region 0x%lx-0x%Lx\n",
|
|
|
|
priv->smba,
|
2006-06-30 08:56:20 +00:00
|
|
|
(unsigned long long)pci_resource_end(dev, SMBBAR));
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
i801_acpi_remove(priv);
|
2015-02-13 13:52:25 +00:00
|
|
|
return err;
|
2006-06-12 19:53:41 +00:00
|
|
|
}
|
|
|
|
|
2020-09-01 13:22:21 +00:00
|
|
|
pci_read_config_byte(priv->pci_dev, SMBHSTCFG, &priv->original_hstcfg);
|
2021-05-25 20:07:17 +00:00
|
|
|
i801_setup_hstcfg(priv);
|
2020-09-01 13:22:21 +00:00
|
|
|
if (!(priv->original_hstcfg & SMBHSTCFG_HST_EN))
|
2006-06-12 19:53:41 +00:00
|
|
|
dev_info(&dev->dev, "Enabling SMBus device\n");
|
|
|
|
|
2021-05-25 20:07:17 +00:00
|
|
|
if (priv->original_hstcfg & SMBHSTCFG_SMB_SMI_EN) {
|
2006-06-12 19:53:41 +00:00
|
|
|
dev_dbg(&dev->dev, "SMBus using interrupt SMI#\n");
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
/* Disable SMBus interrupt feature if SMBus using SMI# */
|
|
|
|
priv->features &= ~FEATURE_IRQ;
|
|
|
|
}
|
2021-05-25 20:07:17 +00:00
|
|
|
if (priv->original_hstcfg & SMBHSTCFG_SPD_WD)
|
2016-10-11 11:13:27 +00:00
|
|
|
dev_info(&dev->dev, "SPD Write Disable is set\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-27 17:14:50 +00:00
|
|
|
/* Clear special mode bits */
|
2010-10-31 20:06:59 +00:00
|
|
|
if (priv->features & (FEATURE_SMBUS_PEC | FEATURE_BLOCK_BUFFER))
|
|
|
|
outb_p(inb_p(SMBAUXCTL(priv)) &
|
|
|
|
~(SMBAUXCTL_CRC | SMBAUXCTL_E32B), SMBAUXCTL(priv));
|
2008-01-27 17:14:50 +00:00
|
|
|
|
2021-11-09 15:02:57 +00:00
|
|
|
/* Remember original Interrupt and Host Notify settings */
|
|
|
|
priv->original_hstcnt = inb_p(SMBHSTCNT(priv)) & ~SMBHSTCNT_KILL;
|
2018-04-11 16:03:31 +00:00
|
|
|
if (priv->features & FEATURE_HOST_NOTIFY)
|
|
|
|
priv->original_slvcmd = inb_p(SMBSLVCMD(priv));
|
|
|
|
|
2014-11-12 09:20:40 +00:00
|
|
|
/* Default timeout in interrupt mode: 200 ms */
|
|
|
|
priv->adapter.timeout = HZ / 5;
|
|
|
|
|
2017-11-22 11:28:17 +00:00
|
|
|
if (dev->irq == IRQ_NOTCONNECTED)
|
|
|
|
priv->features &= ~FEATURE_IRQ;
|
|
|
|
|
2014-11-12 09:25:37 +00:00
|
|
|
if (priv->features & FEATURE_IRQ) {
|
2021-08-06 21:15:51 +00:00
|
|
|
u16 pcists;
|
2014-11-12 09:25:37 +00:00
|
|
|
|
|
|
|
/* Complain if an interrupt is already pending */
|
2021-05-22 21:46:20 +00:00
|
|
|
pci_read_config_word(priv->pci_dev, PCI_STATUS, &pcists);
|
|
|
|
if (pcists & PCI_STATUS_INTERRUPT)
|
2014-11-12 09:25:37 +00:00
|
|
|
dev_warn(&dev->dev, "An interrupt is pending!\n");
|
|
|
|
}
|
|
|
|
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
if (priv->features & FEATURE_IRQ) {
|
2021-05-21 22:02:43 +00:00
|
|
|
init_completion(&priv->done);
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
|
2015-02-13 13:52:23 +00:00
|
|
|
err = devm_request_irq(&dev->dev, dev->irq, i801_isr,
|
2021-05-25 20:04:23 +00:00
|
|
|
IRQF_SHARED, DRV_NAME, priv);
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
if (err) {
|
|
|
|
dev_err(&dev->dev, "Failed to allocate irq %d: %d\n",
|
|
|
|
dev->irq, err);
|
2014-11-12 09:24:07 +00:00
|
|
|
priv->features &= ~FEATURE_IRQ;
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
}
|
|
|
|
}
|
2014-11-12 09:24:07 +00:00
|
|
|
dev_info(&dev->dev, "SMBus using %s\n",
|
|
|
|
priv->features & FEATURE_IRQ ? "PCI interrupt" : "polling");
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
|
2015-08-06 12:46:25 +00:00
|
|
|
i801_add_tco(priv);
|
|
|
|
|
2010-10-31 20:06:59 +00:00
|
|
|
snprintf(priv->adapter.name, sizeof(priv->adapter.name),
|
|
|
|
"SMBus I801 adapter at %04lx", priv->smba);
|
|
|
|
err = i2c_add_adapter(&priv->adapter);
|
2006-06-12 19:53:41 +00:00
|
|
|
if (err) {
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
i801_acpi_remove(priv);
|
2015-02-13 13:52:25 +00:00
|
|
|
return err;
|
2006-06-12 19:53:41 +00:00
|
|
|
}
|
2009-01-07 13:29:17 +00:00
|
|
|
|
2016-10-13 12:10:40 +00:00
|
|
|
i801_enable_host_notify(&priv->adapter);
|
2016-06-24 14:39:49 +00:00
|
|
|
|
2011-05-24 18:58:49 +00:00
|
|
|
i801_probe_optional_slaves(priv);
|
2012-10-05 20:23:53 +00:00
|
|
|
/* We ignore errors - multiplexing is optional */
|
|
|
|
i801_add_mux(priv);
|
2009-01-07 13:29:17 +00:00
|
|
|
|
2010-10-31 20:06:59 +00:00
|
|
|
pci_set_drvdata(dev, priv);
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
|
2020-09-10 09:57:08 +00:00
|
|
|
dev_pm_set_driver_flags(&dev->dev, DPM_FLAG_NO_DIRECT_COMPLETE);
|
2016-03-10 12:12:22 +00:00
|
|
|
pm_runtime_set_autosuspend_delay(&dev->dev, 1000);
|
|
|
|
pm_runtime_use_autosuspend(&dev->dev);
|
|
|
|
pm_runtime_put_autosuspend(&dev->dev);
|
|
|
|
pm_runtime_allow(&dev->dev);
|
|
|
|
|
2006-06-27 16:40:54 +00:00
|
|
|
return 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2012-11-27 20:59:38 +00:00
|
|
|
static void i801_remove(struct pci_dev *dev)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2010-10-31 20:06:59 +00:00
|
|
|
struct i801_priv *priv = pci_get_drvdata(dev);
|
|
|
|
|
2021-11-09 15:02:57 +00:00
|
|
|
outb_p(priv->original_hstcnt, SMBHSTCNT(priv));
|
2016-10-13 12:10:35 +00:00
|
|
|
i801_disable_host_notify(priv);
|
2012-10-05 20:23:53 +00:00
|
|
|
i801_del_mux(priv);
|
2010-10-31 20:06:59 +00:00
|
|
|
i2c_del_adapter(&priv->adapter);
|
i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Many Intel systems the BIOS declares a SystemIO OpRegion below the SMBus
PCI device as can be seen in ACPI DSDT table from Lenovo Yoga 900:
Device (SBUS)
{
OperationRegion (SMBI, SystemIO, (SBAR << 0x05), 0x10)
Field (SMBI, ByteAcc, NoLock, Preserve)
{
HSTS, 8,
Offset (0x02),
HCON, 8,
HCOM, 8,
TXSA, 8,
DAT0, 8,
DAT1, 8,
HBDR, 8,
PECR, 8,
RXSA, 8,
SDAT, 16
}
There are also bunch of AML methods that that the BIOS can use to access
these fields. Most of the systems in question AML methods accessing the
SMBI OpRegion are never used.
Now, because of this SMBI OpRegion many systems fail to load the SMBus
driver with an error looking like one below:
ACPI Warning: SystemIO range 0x0000000000003040-0x000000000000305F
conflicts with OpRegion 0x0000000000003040-0x000000000000304F
(\_SB.PCI0.SBUS.SMBI) (20160108/utaddress-255)
ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver
The reason is that this SMBI OpRegion conflicts with the PCI BAR used by
the SMBus driver.
It turns out that we can install a custom SystemIO address space handler
for the SMBus device to intercept all accesses through that OpRegion. This
allows us to share the PCI BAR with the AML code if it for some reason is
using it. We do not expect that this OpRegion handler will ever be called
but if it is we print a warning and prevent all access from the SMBus
driver itself.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=110041
Reported-by: Andy Lutomirski <luto@kernel.org>
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@vger.kernel.org
2016-06-09 13:56:28 +00:00
|
|
|
i801_acpi_remove(priv);
|
2010-10-31 20:06:59 +00:00
|
|
|
pci_write_config_byte(dev, SMBHSTCFG, priv->original_hstcfg);
|
i2c-i801: Enable IRQ for SMBus transactions
Add a new 'feature' to i2c-i801 to enable using PCI interrupts.
When the feature is enabled, then an isr is installed for the device's
PCI IRQ.
An I2C/SMBus transaction is always terminated by one of the following
interrupt sources: FAILED, BUS_ERR, DEV_ERR, or on success: INTR.
When the isr fires for one of these cases, it sets the ->status variable
and wakes up the waitq. The waitq then saves off the status code, and
clears ->status (in preparation for some future transaction).
The SMBus controller generates an INTR irq at the end of each
transaction where INTREN was set in the HST_CNT register.
No locking is needed around accesses to priv->status since all writes to
it are serialized: it is only ever set once in the isr at the end of a
transaction, and cleared while no interrupts can occur. In addition, the
I2C adapter lock guarantees that entire I2C transactions for a single
adapter are always serialized.
For this patch, the INTREN bit is set only for SMBus block, byte and word
transactions, but not for I2C reads or writes. The use of the DS
(BYTE_DONE) interrupt with byte-by-byte I2C transactions is implemented in
a subsequent patch.
The interrupt feature has only been enabled for COUGARPOINT hardware.
In addition, it is disabled if SMBus is using the SMI# interrupt.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2012-07-24 12:13:58 +00:00
|
|
|
|
2015-08-06 12:46:25 +00:00
|
|
|
platform_device_unregister(priv->tco_pdev);
|
|
|
|
|
2021-09-07 20:33:02 +00:00
|
|
|
/* if acpi_reserved is set then usage_count is incremented already */
|
|
|
|
if (!priv->acpi_reserved)
|
|
|
|
pm_runtime_get_noresume(&dev->dev);
|
|
|
|
|
2006-06-27 16:40:54 +00:00
|
|
|
/*
|
|
|
|
* do not call pci_disable_device(dev) since it can cause hard hangs on
|
|
|
|
* some systems during power-off (eg. Fujitsu-Siemens Lifebook E8010)
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2018-04-11 16:05:34 +00:00
|
|
|
static void i801_shutdown(struct pci_dev *dev)
|
|
|
|
{
|
|
|
|
struct i801_priv *priv = pci_get_drvdata(dev);
|
|
|
|
|
|
|
|
/* Restore config registers to avoid hard hang on some systems */
|
2021-11-09 15:02:57 +00:00
|
|
|
outb_p(priv->original_hstcnt, SMBHSTCNT(priv));
|
2018-04-11 16:05:34 +00:00
|
|
|
i801_disable_host_notify(priv);
|
|
|
|
pci_write_config_byte(dev, SMBHSTCFG, priv->original_hstcfg);
|
|
|
|
}
|
|
|
|
|
2018-05-14 09:33:26 +00:00
|
|
|
#ifdef CONFIG_PM_SLEEP
|
2016-03-10 12:12:21 +00:00
|
|
|
static int i801_suspend(struct device *dev)
|
2007-03-22 18:49:01 +00:00
|
|
|
{
|
2020-09-01 13:28:37 +00:00
|
|
|
struct i801_priv *priv = dev_get_drvdata(dev);
|
2010-10-31 20:06:59 +00:00
|
|
|
|
2021-11-09 15:02:57 +00:00
|
|
|
outb_p(priv->original_hstcnt, SMBHSTCNT(priv));
|
2020-09-01 13:28:37 +00:00
|
|
|
pci_write_config_byte(priv->pci_dev, SMBHSTCFG, priv->original_hstcfg);
|
2007-03-22 18:49:01 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-03-10 12:12:21 +00:00
|
|
|
static int i801_resume(struct device *dev)
|
2007-03-22 18:49:01 +00:00
|
|
|
{
|
2019-07-23 11:11:10 +00:00
|
|
|
struct i801_priv *priv = dev_get_drvdata(dev);
|
2016-06-24 14:39:49 +00:00
|
|
|
|
2020-09-01 13:22:21 +00:00
|
|
|
i801_setup_hstcfg(priv);
|
2016-10-13 12:10:40 +00:00
|
|
|
i801_enable_host_notify(&priv->adapter);
|
2016-06-24 14:39:49 +00:00
|
|
|
|
2015-02-13 13:52:24 +00:00
|
|
|
return 0;
|
2007-03-22 18:49:01 +00:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2018-04-25 09:53:40 +00:00
|
|
|
static SIMPLE_DEV_PM_OPS(i801_pm_ops, i801_suspend, i801_resume);
|
2016-03-10 12:12:21 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
static struct pci_driver i801_driver = {
|
2021-05-25 20:04:23 +00:00
|
|
|
.name = DRV_NAME,
|
2005-04-16 22:20:36 +00:00
|
|
|
.id_table = i801_ids,
|
|
|
|
.probe = i801_probe,
|
2012-11-27 20:59:38 +00:00
|
|
|
.remove = i801_remove,
|
2018-04-11 16:05:34 +00:00
|
|
|
.shutdown = i801_shutdown,
|
2016-03-10 12:12:21 +00:00
|
|
|
.driver = {
|
|
|
|
.pm = &i801_pm_ops,
|
|
|
|
},
|
2005-04-16 22:20:36 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static int __init i2c_i801_init(void)
|
|
|
|
{
|
2011-05-24 18:58:49 +00:00
|
|
|
if (dmi_name_in_vendors("FUJITSU"))
|
|
|
|
input_apanel_init();
|
2005-04-16 22:20:36 +00:00
|
|
|
return pci_register_driver(&i801_driver);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __exit i2c_i801_exit(void)
|
|
|
|
{
|
|
|
|
pci_unregister_driver(&i801_driver);
|
|
|
|
}
|
|
|
|
|
2020-06-11 11:05:34 +00:00
|
|
|
MODULE_AUTHOR("Mark D. Studebaker <mdsxyz123@yahoo.com>");
|
|
|
|
MODULE_AUTHOR("Jean Delvare <jdelvare@suse.de>");
|
2005-04-16 22:20:36 +00:00
|
|
|
MODULE_DESCRIPTION("I801 SMBus driver");
|
|
|
|
MODULE_LICENSE("GPL");
|
|
|
|
|
|
|
|
module_init(i2c_i801_init);
|
|
|
|
module_exit(i2c_i801_exit);
|