2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* drivers/cpufreq/cpufreq_stats.c
|
|
|
|
*
|
|
|
|
* Copyright (C) 2003-2004 Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>.
|
2009-01-18 06:49:04 +00:00
|
|
|
* (C) 2004 Zou Nan hai <nanhai.zou@intel.com>.
|
2005-04-16 22:20:36 +00:00
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
|
|
* published by the Free Software Foundation.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/kernel.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/slab.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/cpu.h>
|
|
|
|
#include <linux/sysfs.h>
|
|
|
|
#include <linux/cpufreq.h>
|
2011-05-27 17:23:32 +00:00
|
|
|
#include <linux/module.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/jiffies.h>
|
|
|
|
#include <linux/percpu.h>
|
|
|
|
#include <linux/kobject.h>
|
|
|
|
#include <linux/spinlock.h>
|
2005-10-30 22:59:54 +00:00
|
|
|
#include <linux/notifier.h>
|
2005-05-25 21:46:50 +00:00
|
|
|
#include <asm/cputime.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
static spinlock_t cpufreq_stats_lock;
|
|
|
|
|
|
|
|
struct cpufreq_stats {
|
|
|
|
unsigned int cpu;
|
|
|
|
unsigned int total_trans;
|
2013-06-19 08:49:33 +00:00
|
|
|
unsigned long long last_time;
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned int max_state;
|
|
|
|
unsigned int state_num;
|
|
|
|
unsigned int last_index;
|
2012-10-25 22:51:21 +00:00
|
|
|
u64 *time_in_state;
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned int *freq_table;
|
|
|
|
#ifdef CONFIG_CPU_FREQ_STAT_DETAILS
|
|
|
|
unsigned int *trans_table;
|
|
|
|
#endif
|
|
|
|
};
|
|
|
|
|
2008-03-25 22:06:53 +00:00
|
|
|
static DEFINE_PER_CPU(struct cpufreq_stats *, cpufreq_stats_table);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
struct cpufreq_stats_attribute {
|
|
|
|
struct attribute attr;
|
|
|
|
ssize_t(*show) (struct cpufreq_stats *, char *);
|
|
|
|
};
|
|
|
|
|
2009-01-18 06:49:04 +00:00
|
|
|
static int cpufreq_stats_update(unsigned int cpu)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct cpufreq_stats *stat;
|
2005-05-25 21:46:50 +00:00
|
|
|
unsigned long long cur_time;
|
|
|
|
|
|
|
|
cur_time = get_jiffies_64();
|
2005-04-16 22:20:36 +00:00
|
|
|
spin_lock(&cpufreq_stats_lock);
|
2008-03-25 22:06:53 +00:00
|
|
|
stat = per_cpu(cpufreq_stats_table, cpu);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (stat->time_in_state)
|
2011-12-15 13:56:09 +00:00
|
|
|
stat->time_in_state[stat->last_index] +=
|
|
|
|
cur_time - stat->last_time;
|
2005-05-25 21:46:50 +00:00
|
|
|
stat->last_time = cur_time;
|
2005-04-16 22:20:36 +00:00
|
|
|
spin_unlock(&cpufreq_stats_lock);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-01-18 06:49:04 +00:00
|
|
|
static ssize_t show_total_trans(struct cpufreq_policy *policy, char *buf)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-03-25 22:06:53 +00:00
|
|
|
struct cpufreq_stats *stat = per_cpu(cpufreq_stats_table, policy->cpu);
|
2006-05-30 21:57:14 +00:00
|
|
|
if (!stat)
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
return sprintf(buf, "%d\n",
|
2008-03-25 22:06:53 +00:00
|
|
|
per_cpu(cpufreq_stats_table, stat->cpu)->total_trans);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2009-01-18 06:49:04 +00:00
|
|
|
static ssize_t show_time_in_state(struct cpufreq_policy *policy, char *buf)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
ssize_t len = 0;
|
|
|
|
int i;
|
2008-03-25 22:06:53 +00:00
|
|
|
struct cpufreq_stats *stat = per_cpu(cpufreq_stats_table, policy->cpu);
|
2006-05-30 21:57:14 +00:00
|
|
|
if (!stat)
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
cpufreq_stats_update(stat->cpu);
|
|
|
|
for (i = 0; i < stat->state_num; i++) {
|
2006-02-28 05:43:23 +00:00
|
|
|
len += sprintf(buf + len, "%u %llu\n", stat->freq_table[i],
|
2009-01-18 06:49:04 +00:00
|
|
|
(unsigned long long)
|
|
|
|
cputime64_to_clock_t(stat->time_in_state[i]));
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
return len;
|
|
|
|
}
|
|
|
|
|
|
|
|
#ifdef CONFIG_CPU_FREQ_STAT_DETAILS
|
2009-01-18 06:49:04 +00:00
|
|
|
static ssize_t show_trans_table(struct cpufreq_policy *policy, char *buf)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
ssize_t len = 0;
|
|
|
|
int i, j;
|
|
|
|
|
2008-03-25 22:06:53 +00:00
|
|
|
struct cpufreq_stats *stat = per_cpu(cpufreq_stats_table, policy->cpu);
|
2006-05-30 21:57:14 +00:00
|
|
|
if (!stat)
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
cpufreq_stats_update(stat->cpu);
|
2005-05-25 21:46:50 +00:00
|
|
|
len += snprintf(buf + len, PAGE_SIZE - len, " From : To\n");
|
|
|
|
len += snprintf(buf + len, PAGE_SIZE - len, " : ");
|
|
|
|
for (i = 0; i < stat->state_num; i++) {
|
|
|
|
if (len >= PAGE_SIZE)
|
|
|
|
break;
|
|
|
|
len += snprintf(buf + len, PAGE_SIZE - len, "%9u ",
|
|
|
|
stat->freq_table[i]);
|
|
|
|
}
|
|
|
|
if (len >= PAGE_SIZE)
|
2008-02-16 10:41:25 +00:00
|
|
|
return PAGE_SIZE;
|
2005-05-25 21:46:50 +00:00
|
|
|
|
|
|
|
len += snprintf(buf + len, PAGE_SIZE - len, "\n");
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
for (i = 0; i < stat->state_num; i++) {
|
|
|
|
if (len >= PAGE_SIZE)
|
|
|
|
break;
|
2005-05-25 21:46:50 +00:00
|
|
|
|
|
|
|
len += snprintf(buf + len, PAGE_SIZE - len, "%9u: ",
|
2005-04-16 22:20:36 +00:00
|
|
|
stat->freq_table[i]);
|
|
|
|
|
2013-06-19 08:49:33 +00:00
|
|
|
for (j = 0; j < stat->state_num; j++) {
|
2005-04-16 22:20:36 +00:00
|
|
|
if (len >= PAGE_SIZE)
|
|
|
|
break;
|
2005-05-25 21:46:50 +00:00
|
|
|
len += snprintf(buf + len, PAGE_SIZE - len, "%9u ",
|
2005-04-16 22:20:36 +00:00
|
|
|
stat->trans_table[i*stat->max_state+j]);
|
|
|
|
}
|
2008-02-16 10:41:25 +00:00
|
|
|
if (len >= PAGE_SIZE)
|
|
|
|
break;
|
2005-04-16 22:20:36 +00:00
|
|
|
len += snprintf(buf + len, PAGE_SIZE - len, "\n");
|
|
|
|
}
|
2008-02-16 10:41:25 +00:00
|
|
|
if (len >= PAGE_SIZE)
|
|
|
|
return PAGE_SIZE;
|
2005-04-16 22:20:36 +00:00
|
|
|
return len;
|
|
|
|
}
|
2013-02-04 11:38:52 +00:00
|
|
|
cpufreq_freq_attr_ro(trans_table);
|
2005-04-16 22:20:36 +00:00
|
|
|
#endif
|
|
|
|
|
2013-02-04 11:38:52 +00:00
|
|
|
cpufreq_freq_attr_ro(total_trans);
|
|
|
|
cpufreq_freq_attr_ro(time_in_state);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
static struct attribute *default_attrs[] = {
|
2013-02-04 11:38:52 +00:00
|
|
|
&total_trans.attr,
|
|
|
|
&time_in_state.attr,
|
2005-04-16 22:20:36 +00:00
|
|
|
#ifdef CONFIG_CPU_FREQ_STAT_DETAILS
|
2013-02-04 11:38:52 +00:00
|
|
|
&trans_table.attr,
|
2005-04-16 22:20:36 +00:00
|
|
|
#endif
|
|
|
|
NULL
|
|
|
|
};
|
|
|
|
static struct attribute_group stats_attr_group = {
|
|
|
|
.attrs = default_attrs,
|
|
|
|
.name = "stats"
|
|
|
|
};
|
|
|
|
|
2009-01-18 06:49:04 +00:00
|
|
|
static int freq_table_get_index(struct cpufreq_stats *stat, unsigned int freq)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
int index;
|
|
|
|
for (index = 0; index < stat->max_state; index++)
|
|
|
|
if (stat->freq_table[index] == freq)
|
|
|
|
return index;
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2011-05-02 18:29:17 +00:00
|
|
|
/* should be called late in the CPU removal sequence so that the stats
|
|
|
|
* memory is still available in case someone tries to use it.
|
|
|
|
*/
|
2007-12-18 00:20:03 +00:00
|
|
|
static void cpufreq_stats_free_table(unsigned int cpu)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-03-25 22:06:53 +00:00
|
|
|
struct cpufreq_stats *stat = per_cpu(cpufreq_stats_table, cpu);
|
2013-01-14 13:23:03 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
if (stat) {
|
2013-01-14 13:23:03 +00:00
|
|
|
pr_debug("%s: Free stat table\n", __func__);
|
2005-04-16 22:20:36 +00:00
|
|
|
kfree(stat->time_in_state);
|
|
|
|
kfree(stat);
|
2013-01-14 13:23:03 +00:00
|
|
|
per_cpu(cpufreq_stats_table, cpu) = NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2011-05-02 18:29:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* must be called early in the CPU removal sequence (before
|
|
|
|
* cpufreq_remove_dev) so that policy is still valid.
|
|
|
|
*/
|
|
|
|
static void cpufreq_stats_free_sysfs(unsigned int cpu)
|
|
|
|
{
|
|
|
|
struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
|
2013-02-06 17:02:12 +00:00
|
|
|
|
2013-03-22 10:13:52 +00:00
|
|
|
if (!policy)
|
2013-02-06 17:02:12 +00:00
|
|
|
return;
|
|
|
|
|
2013-03-22 10:13:52 +00:00
|
|
|
if (!cpufreq_frequency_get_table(cpu))
|
|
|
|
goto put_ref;
|
|
|
|
|
|
|
|
if (!policy_is_shared(policy)) {
|
2013-01-14 13:23:03 +00:00
|
|
|
pr_debug("%s: Free sysfs stat\n", __func__);
|
2011-05-02 18:29:17 +00:00
|
|
|
sysfs_remove_group(&policy->kobj, &stats_attr_group);
|
2013-01-14 13:23:03 +00:00
|
|
|
}
|
2013-03-22 10:13:52 +00:00
|
|
|
|
|
|
|
put_ref:
|
|
|
|
cpufreq_cpu_put(policy);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2009-01-18 06:49:04 +00:00
|
|
|
static int cpufreq_stats_create_table(struct cpufreq_policy *policy,
|
2005-04-16 22:20:36 +00:00
|
|
|
struct cpufreq_frequency_table *table)
|
|
|
|
{
|
|
|
|
unsigned int i, j, count = 0, ret = 0;
|
|
|
|
struct cpufreq_stats *stat;
|
|
|
|
struct cpufreq_policy *data;
|
|
|
|
unsigned int alloc_size;
|
|
|
|
unsigned int cpu = policy->cpu;
|
2008-03-25 22:06:53 +00:00
|
|
|
if (per_cpu(cpufreq_stats_table, cpu))
|
2005-04-16 22:20:36 +00:00
|
|
|
return -EBUSY;
|
2009-01-18 06:49:04 +00:00
|
|
|
stat = kzalloc(sizeof(struct cpufreq_stats), GFP_KERNEL);
|
|
|
|
if ((stat) == NULL)
|
2005-04-16 22:20:36 +00:00
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
data = cpufreq_cpu_get(cpu);
|
2005-10-27 23:02:06 +00:00
|
|
|
if (data == NULL) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto error_get_fail;
|
|
|
|
}
|
|
|
|
|
2009-01-18 06:49:04 +00:00
|
|
|
ret = sysfs_create_group(&data->kobj, &stats_attr_group);
|
|
|
|
if (ret)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto error_out;
|
|
|
|
|
|
|
|
stat->cpu = cpu;
|
2008-03-25 22:06:53 +00:00
|
|
|
per_cpu(cpufreq_stats_table, cpu) = stat;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-01-18 06:49:04 +00:00
|
|
|
for (i = 0; table[i].frequency != CPUFREQ_TABLE_END; i++) {
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned int freq = table[i].frequency;
|
|
|
|
if (freq == CPUFREQ_ENTRY_INVALID)
|
|
|
|
continue;
|
|
|
|
count++;
|
|
|
|
}
|
|
|
|
|
2012-10-25 22:51:21 +00:00
|
|
|
alloc_size = count * sizeof(int) + count * sizeof(u64);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
#ifdef CONFIG_CPU_FREQ_STAT_DETAILS
|
|
|
|
alloc_size += count * count * sizeof(int);
|
|
|
|
#endif
|
|
|
|
stat->max_state = count;
|
2005-10-20 22:17:43 +00:00
|
|
|
stat->time_in_state = kzalloc(alloc_size, GFP_KERNEL);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (!stat->time_in_state) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto error_out;
|
|
|
|
}
|
|
|
|
stat->freq_table = (unsigned int *)(stat->time_in_state + count);
|
|
|
|
|
|
|
|
#ifdef CONFIG_CPU_FREQ_STAT_DETAILS
|
|
|
|
stat->trans_table = stat->freq_table + count;
|
|
|
|
#endif
|
|
|
|
j = 0;
|
|
|
|
for (i = 0; table[i].frequency != CPUFREQ_TABLE_END; i++) {
|
|
|
|
unsigned int freq = table[i].frequency;
|
|
|
|
if (freq == CPUFREQ_ENTRY_INVALID)
|
|
|
|
continue;
|
|
|
|
if (freq_table_get_index(stat, freq) == -1)
|
|
|
|
stat->freq_table[j++] = freq;
|
|
|
|
}
|
|
|
|
stat->state_num = j;
|
|
|
|
spin_lock(&cpufreq_stats_lock);
|
2005-05-25 21:46:50 +00:00
|
|
|
stat->last_time = get_jiffies_64();
|
2005-04-16 22:20:36 +00:00
|
|
|
stat->last_index = freq_table_get_index(stat, policy->cur);
|
|
|
|
spin_unlock(&cpufreq_stats_lock);
|
|
|
|
cpufreq_cpu_put(data);
|
|
|
|
return 0;
|
|
|
|
error_out:
|
|
|
|
cpufreq_cpu_put(data);
|
2005-11-02 07:13:45 +00:00
|
|
|
error_get_fail:
|
2005-04-16 22:20:36 +00:00
|
|
|
kfree(stat);
|
2008-03-25 22:06:53 +00:00
|
|
|
per_cpu(cpufreq_stats_table, cpu) = NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2013-01-14 13:23:03 +00:00
|
|
|
static void cpufreq_stats_update_policy_cpu(struct cpufreq_policy *policy)
|
|
|
|
{
|
|
|
|
struct cpufreq_stats *stat = per_cpu(cpufreq_stats_table,
|
|
|
|
policy->last_cpu);
|
|
|
|
|
|
|
|
pr_debug("Updating stats_table for new_cpu %u from last_cpu %u\n",
|
|
|
|
policy->cpu, policy->last_cpu);
|
|
|
|
per_cpu(cpufreq_stats_table, policy->cpu) = per_cpu(cpufreq_stats_table,
|
|
|
|
policy->last_cpu);
|
|
|
|
per_cpu(cpufreq_stats_table, policy->last_cpu) = NULL;
|
|
|
|
stat->cpu = policy->cpu;
|
|
|
|
}
|
|
|
|
|
2009-01-18 06:49:04 +00:00
|
|
|
static int cpufreq_stat_notifier_policy(struct notifier_block *nb,
|
|
|
|
unsigned long val, void *data)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
struct cpufreq_policy *policy = data;
|
|
|
|
struct cpufreq_frequency_table *table;
|
|
|
|
unsigned int cpu = policy->cpu;
|
2013-01-14 13:23:03 +00:00
|
|
|
|
|
|
|
if (val == CPUFREQ_UPDATE_POLICY_CPU) {
|
|
|
|
cpufreq_stats_update_policy_cpu(policy);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
if (val != CPUFREQ_NOTIFY)
|
|
|
|
return 0;
|
|
|
|
table = cpufreq_frequency_get_table(cpu);
|
|
|
|
if (!table)
|
|
|
|
return 0;
|
2009-01-18 06:49:04 +00:00
|
|
|
ret = cpufreq_stats_create_table(policy, table);
|
|
|
|
if (ret)
|
2005-04-16 22:20:36 +00:00
|
|
|
return ret;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-01-18 06:49:04 +00:00
|
|
|
static int cpufreq_stat_notifier_trans(struct notifier_block *nb,
|
|
|
|
unsigned long val, void *data)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct cpufreq_freqs *freq = data;
|
|
|
|
struct cpufreq_stats *stat;
|
|
|
|
int old_index, new_index;
|
|
|
|
|
|
|
|
if (val != CPUFREQ_POSTCHANGE)
|
|
|
|
return 0;
|
|
|
|
|
2008-03-25 22:06:53 +00:00
|
|
|
stat = per_cpu(cpufreq_stats_table, freq->cpu);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (!stat)
|
|
|
|
return 0;
|
2006-12-19 20:58:55 +00:00
|
|
|
|
2008-04-27 20:46:56 +00:00
|
|
|
old_index = stat->last_index;
|
2005-04-16 22:20:36 +00:00
|
|
|
new_index = freq_table_get_index(stat, freq->new);
|
|
|
|
|
[CPUFREQ] Don't set stat->last_index to -1 if the pol->cur has incorrect value.
If the driver submitted an non-existing pol>cur value (say it
used the default initialized value of zero), when the cpufreq
stats tries to setup its initial values it incorrectly sets
stat->last_index to -1 (or 0xfffff...). And cpufreq_stats_update
tries to update at that index location and fails.
This can be caused by:
stat->last_index = freq_table_get_index(stat, policy->cur);
not finding the appropiate frequency in the table (b/c the policy->cur
is wrong) and we end up crashing. The fix however is
concentrated in the 'cpufreq_stats_update' as the last_index
(and old_index) are updated there. Which means it can reset
the last_index to -1 again and on the next iteration cause a crash.
Without this patch, the following crash is observed:
powernow-k8: Found 1 AMD Athlon(tm) 64 Processor 3700+ (1 cpu cores) (version 2.20.00)
powernow-k8: fid 0x2 (1000 MHz), vid 0x12
powernow-k8: fid 0xa (1800 MHz), vid 0xa
powernow-k8: fid 0xc (2000 MHz), vid 0x8
powernow-k8: fid 0xe (2200 MHz), vid 0x8
Marking TSC unstable due to cpufreq changes
powernow-k8: fid trans failed, fid 0x2, curr 0x0
BUG: unable to handle kernel paging request at ffff880807e07b78
IP: [<ffffffff81479163>] cpufreq_stats_update+0x46/0x5b
.. snip..
Pid: 1, comm: swapper Not tainted 3.0.0-rc2 #45 MICRO-STAR INTERNATIONAL CO., LTD MS-7094/MS-7094
..snip..
Call Trace:
[<ffffffff81479248>] cpufreq_stat_notifier_trans+0x48/0x7c
[<ffffffff81095d68>] notifier_call_chain+0x32/0x5e
[<ffffffff81095e6b>] __srcu_notifier_call_chain+0x47/0x63
[<ffffffff81095e96>] srcu_notifier_call_chain+0xf/0x11
[<ffffffff81477e7a>] cpufreq_notify_transition+0x111/0x134
[<ffffffff8147b0d4>] powernowk8_target+0x53b/0x617
[<ffffffff8147723a>] __cpufreq_driver_target+0x2e/0x30
[<ffffffff8147a127>] cpufreq_governor_dbs+0x339/0x356
[<ffffffff81477394>] __cpufreq_governor+0xa8/0xe9
[<ffffffff81477525>] __cpufreq_set_policy+0x132/0x13e
[<ffffffff8147848d>] cpufreq_add_dev_interface+0x272/0x28c
Reported-by: Tobias Diedrich <ranma+xen@tdiedrich.de>
Tested-by: Tobias Diedrich <ranma+xen@tdiedrich.de>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Dave Jones <davej@redhat.com>
2011-06-16 19:36:38 +00:00
|
|
|
/* We can't do stat->time_in_state[-1]= .. */
|
|
|
|
if (old_index == -1 || new_index == -1)
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
|
[CPUFREQ] Don't set stat->last_index to -1 if the pol->cur has incorrect value.
If the driver submitted an non-existing pol>cur value (say it
used the default initialized value of zero), when the cpufreq
stats tries to setup its initial values it incorrectly sets
stat->last_index to -1 (or 0xfffff...). And cpufreq_stats_update
tries to update at that index location and fails.
This can be caused by:
stat->last_index = freq_table_get_index(stat, policy->cur);
not finding the appropiate frequency in the table (b/c the policy->cur
is wrong) and we end up crashing. The fix however is
concentrated in the 'cpufreq_stats_update' as the last_index
(and old_index) are updated there. Which means it can reset
the last_index to -1 again and on the next iteration cause a crash.
Without this patch, the following crash is observed:
powernow-k8: Found 1 AMD Athlon(tm) 64 Processor 3700+ (1 cpu cores) (version 2.20.00)
powernow-k8: fid 0x2 (1000 MHz), vid 0x12
powernow-k8: fid 0xa (1800 MHz), vid 0xa
powernow-k8: fid 0xc (2000 MHz), vid 0x8
powernow-k8: fid 0xe (2200 MHz), vid 0x8
Marking TSC unstable due to cpufreq changes
powernow-k8: fid trans failed, fid 0x2, curr 0x0
BUG: unable to handle kernel paging request at ffff880807e07b78
IP: [<ffffffff81479163>] cpufreq_stats_update+0x46/0x5b
.. snip..
Pid: 1, comm: swapper Not tainted 3.0.0-rc2 #45 MICRO-STAR INTERNATIONAL CO., LTD MS-7094/MS-7094
..snip..
Call Trace:
[<ffffffff81479248>] cpufreq_stat_notifier_trans+0x48/0x7c
[<ffffffff81095d68>] notifier_call_chain+0x32/0x5e
[<ffffffff81095e6b>] __srcu_notifier_call_chain+0x47/0x63
[<ffffffff81095e96>] srcu_notifier_call_chain+0xf/0x11
[<ffffffff81477e7a>] cpufreq_notify_transition+0x111/0x134
[<ffffffff8147b0d4>] powernowk8_target+0x53b/0x617
[<ffffffff8147723a>] __cpufreq_driver_target+0x2e/0x30
[<ffffffff8147a127>] cpufreq_governor_dbs+0x339/0x356
[<ffffffff81477394>] __cpufreq_governor+0xa8/0xe9
[<ffffffff81477525>] __cpufreq_set_policy+0x132/0x13e
[<ffffffff8147848d>] cpufreq_add_dev_interface+0x272/0x28c
Reported-by: Tobias Diedrich <ranma+xen@tdiedrich.de>
Tested-by: Tobias Diedrich <ranma+xen@tdiedrich.de>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Dave Jones <davej@redhat.com>
2011-06-16 19:36:38 +00:00
|
|
|
cpufreq_stats_update(freq->cpu);
|
|
|
|
|
|
|
|
if (old_index == new_index)
|
2006-12-19 20:58:55 +00:00
|
|
|
return 0;
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
spin_lock(&cpufreq_stats_lock);
|
|
|
|
stat->last_index = new_index;
|
|
|
|
#ifdef CONFIG_CPU_FREQ_STAT_DETAILS
|
|
|
|
stat->trans_table[old_index * stat->max_state + new_index]++;
|
|
|
|
#endif
|
|
|
|
stat->total_trans++;
|
|
|
|
spin_unlock(&cpufreq_stats_lock);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-06-19 17:54:04 +00:00
|
|
|
static int cpufreq_stat_cpu_callback(struct notifier_block *nfb,
|
2007-10-02 20:28:15 +00:00
|
|
|
unsigned long action,
|
|
|
|
void *hcpu)
|
2005-10-30 22:59:54 +00:00
|
|
|
{
|
|
|
|
unsigned int cpu = (unsigned long)hcpu;
|
|
|
|
|
|
|
|
switch (action) {
|
2011-05-02 18:29:17 +00:00
|
|
|
case CPU_DOWN_PREPARE:
|
|
|
|
cpufreq_stats_free_sysfs(cpu);
|
|
|
|
break;
|
2005-10-30 22:59:54 +00:00
|
|
|
case CPU_DEAD:
|
|
|
|
cpufreq_stats_free_table(cpu);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return NOTIFY_OK;
|
|
|
|
}
|
|
|
|
|
2011-05-02 18:29:17 +00:00
|
|
|
/* priority=1 so this will get called before cpufreq_remove_dev */
|
2011-04-01 22:34:47 +00:00
|
|
|
static struct notifier_block cpufreq_stat_cpu_notifier __refdata = {
|
2005-10-30 22:59:54 +00:00
|
|
|
.notifier_call = cpufreq_stat_cpu_callback,
|
2011-05-02 18:29:17 +00:00
|
|
|
.priority = 1,
|
2005-10-30 22:59:54 +00:00
|
|
|
};
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
static struct notifier_block notifier_policy_block = {
|
|
|
|
.notifier_call = cpufreq_stat_notifier_policy
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct notifier_block notifier_trans_block = {
|
|
|
|
.notifier_call = cpufreq_stat_notifier_trans
|
|
|
|
};
|
|
|
|
|
2009-01-18 06:49:04 +00:00
|
|
|
static int __init cpufreq_stats_init(void)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
unsigned int cpu;
|
2005-10-30 22:59:54 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
spin_lock_init(&cpufreq_stats_lock);
|
2009-01-18 06:49:04 +00:00
|
|
|
ret = cpufreq_register_notifier(¬ifier_policy_block,
|
|
|
|
CPUFREQ_POLICY_NOTIFIER);
|
|
|
|
if (ret)
|
2005-04-16 22:20:36 +00:00
|
|
|
return ret;
|
|
|
|
|
2012-12-14 23:22:02 +00:00
|
|
|
register_hotcpu_notifier(&cpufreq_stat_cpu_notifier);
|
|
|
|
|
2009-01-18 06:49:04 +00:00
|
|
|
ret = cpufreq_register_notifier(¬ifier_trans_block,
|
|
|
|
CPUFREQ_TRANSITION_NOTIFIER);
|
|
|
|
if (ret) {
|
2005-04-16 22:20:36 +00:00
|
|
|
cpufreq_unregister_notifier(¬ifier_policy_block,
|
|
|
|
CPUFREQ_POLICY_NOTIFIER);
|
2012-12-14 23:22:02 +00:00
|
|
|
unregister_hotcpu_notifier(&cpufreq_stat_cpu_notifier);
|
|
|
|
for_each_online_cpu(cpu)
|
|
|
|
cpufreq_stats_free_table(cpu);
|
2005-04-16 22:20:36 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2009-01-18 06:49:04 +00:00
|
|
|
static void __exit cpufreq_stats_exit(void)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
unsigned int cpu;
|
2005-10-30 22:59:54 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
cpufreq_unregister_notifier(¬ifier_policy_block,
|
|
|
|
CPUFREQ_POLICY_NOTIFIER);
|
|
|
|
cpufreq_unregister_notifier(¬ifier_trans_block,
|
|
|
|
CPUFREQ_TRANSITION_NOTIFIER);
|
2006-06-27 09:54:08 +00:00
|
|
|
unregister_hotcpu_notifier(&cpufreq_stat_cpu_notifier);
|
2005-10-30 22:59:54 +00:00
|
|
|
for_each_online_cpu(cpu) {
|
2007-10-02 20:28:15 +00:00
|
|
|
cpufreq_stats_free_table(cpu);
|
2011-06-12 20:35:28 +00:00
|
|
|
cpufreq_stats_free_sysfs(cpu);
|
2005-10-30 22:59:54 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2009-01-18 06:49:04 +00:00
|
|
|
MODULE_AUTHOR("Zou Nan hai <nanhai.zou@intel.com>");
|
|
|
|
MODULE_DESCRIPTION("'cpufreq_stats' - A driver to export cpufreq stats "
|
2006-10-26 10:50:58 +00:00
|
|
|
"through sysfs filesystem");
|
2009-01-18 06:49:04 +00:00
|
|
|
MODULE_LICENSE("GPL");
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
module_init(cpufreq_stats_init);
|
|
|
|
module_exit(cpufreq_stats_exit);
|