2019-05-19 12:08:55 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2005-04-16 22:20:36 +00:00
|
|
|
/* -*- linux-c -*-
|
|
|
|
* sysctl_net.c: sysctl interface to net subsystem.
|
|
|
|
*
|
|
|
|
* Begun April 1, 1996, Mike Shaver.
|
|
|
|
* Added /proc/sys/net directories for each protocol family. [MS]
|
|
|
|
*
|
|
|
|
* Revision 1.2 1996/05/08 20:24:40 shaver
|
|
|
|
* Added bits for NET_BRIDGE and the NET_IPV4_ARP stuff and
|
|
|
|
* NET_IPV4_IP_FORWARD.
|
|
|
|
*
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/mm.h>
|
2011-07-15 15:47:34 +00:00
|
|
|
#include <linux/export.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/sysctl.h>
|
2007-11-30 12:55:42 +00:00
|
|
|
#include <linux/nsproxy.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2005-10-03 21:16:34 +00:00
|
|
|
#include <net/sock.h>
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
#ifdef CONFIG_INET
|
2005-08-16 05:18:02 +00:00
|
|
|
#include <net/ip.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifdef CONFIG_NET
|
2005-08-16 05:18:02 +00:00
|
|
|
#include <linux/if_ether.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#endif
|
|
|
|
|
2008-07-15 01:22:20 +00:00
|
|
|
static struct ctl_table_set *
|
2016-07-16 20:22:55 +00:00
|
|
|
net_ctl_header_lookup(struct ctl_table_root *root)
|
2007-11-30 12:55:42 +00:00
|
|
|
{
|
2016-07-16 20:22:55 +00:00
|
|
|
return ¤t->nsproxy->net_ns->sysctls;
|
2008-07-15 01:22:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int is_seen(struct ctl_table_set *set)
|
|
|
|
{
|
|
|
|
return ¤t->nsproxy->net_ns->sysctls == set;
|
2007-11-30 12:55:42 +00:00
|
|
|
}
|
|
|
|
|
2008-07-25 08:48:32 +00:00
|
|
|
/* Return standard mode bits for table entry. */
|
2012-11-16 03:02:58 +00:00
|
|
|
static int net_ctl_permissions(struct ctl_table_header *head,
|
2008-07-25 08:48:32 +00:00
|
|
|
struct ctl_table *table)
|
|
|
|
{
|
2012-11-16 03:03:01 +00:00
|
|
|
struct net *net = container_of(head->set, struct net, sysctls);
|
|
|
|
|
2008-07-25 08:48:32 +00:00
|
|
|
/* Allow network administrator to have same access as root. */
|
2016-09-30 22:24:31 +00:00
|
|
|
if (ns_capable_noaudit(net->user_ns, CAP_NET_ADMIN)) {
|
2008-07-25 08:48:32 +00:00
|
|
|
int mode = (table->mode >> 6) & 7;
|
|
|
|
return (mode << 6) | (mode << 3) | mode;
|
|
|
|
}
|
2016-08-10 21:36:02 +00:00
|
|
|
|
2008-07-25 08:48:32 +00:00
|
|
|
return table->mode;
|
|
|
|
}
|
|
|
|
|
2016-08-10 21:36:02 +00:00
|
|
|
static void net_ctl_set_ownership(struct ctl_table_header *head,
|
|
|
|
struct ctl_table *table,
|
|
|
|
kuid_t *uid, kgid_t *gid)
|
|
|
|
{
|
|
|
|
struct net *net = container_of(head->set, struct net, sysctls);
|
|
|
|
kuid_t ns_root_uid;
|
|
|
|
kgid_t ns_root_gid;
|
|
|
|
|
|
|
|
ns_root_uid = make_kuid(net->user_ns, 0);
|
|
|
|
if (uid_valid(ns_root_uid))
|
|
|
|
*uid = ns_root_uid;
|
|
|
|
|
|
|
|
ns_root_gid = make_kgid(net->user_ns, 0);
|
|
|
|
if (gid_valid(ns_root_gid))
|
|
|
|
*gid = ns_root_gid;
|
|
|
|
}
|
|
|
|
|
2007-11-30 12:55:42 +00:00
|
|
|
static struct ctl_table_root net_sysctl_root = {
|
|
|
|
.lookup = net_ctl_header_lookup,
|
2008-07-25 08:48:32 +00:00
|
|
|
.permissions = net_ctl_permissions,
|
2016-08-10 21:36:02 +00:00
|
|
|
.set_ownership = net_ctl_set_ownership,
|
2007-11-30 12:55:42 +00:00
|
|
|
};
|
|
|
|
|
2010-01-17 03:35:32 +00:00
|
|
|
static int __net_init sysctl_net_init(struct net *net)
|
2007-11-30 12:55:42 +00:00
|
|
|
{
|
2012-01-23 05:26:00 +00:00
|
|
|
setup_sysctl_set(&net->sysctls, &net_sysctl_root, is_seen);
|
2007-11-30 12:55:42 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-01-17 03:35:32 +00:00
|
|
|
static void __net_exit sysctl_net_exit(struct net *net)
|
2007-11-30 12:55:42 +00:00
|
|
|
{
|
2012-01-10 06:19:13 +00:00
|
|
|
retire_sysctl_set(&net->sysctls);
|
2007-11-30 12:55:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct pernet_operations sysctl_pernet_ops = {
|
|
|
|
.init = sysctl_net_init,
|
|
|
|
.exit = sysctl_net_exit,
|
|
|
|
};
|
|
|
|
|
2012-04-19 13:19:46 +00:00
|
|
|
static struct ctl_table_header *net_header;
|
2012-04-19 13:20:32 +00:00
|
|
|
__init int net_sysctl_init(void)
|
2007-11-30 12:55:42 +00:00
|
|
|
{
|
2012-04-19 13:19:46 +00:00
|
|
|
static struct ctl_table empty[1];
|
|
|
|
int ret = -ENOMEM;
|
|
|
|
/* Avoid limitations in the sysctl implementation by
|
|
|
|
* registering "/proc/sys/net" as an empty directory not in a
|
|
|
|
* network namespace.
|
|
|
|
*/
|
|
|
|
net_header = register_sysctl("net", empty);
|
|
|
|
if (!net_header)
|
|
|
|
goto out;
|
2007-11-30 12:55:42 +00:00
|
|
|
ret = register_pernet_subsys(&sysctl_pernet_ops);
|
|
|
|
if (ret)
|
net: sysctl: fix a kmemleak warning
the returned buffer of register_sysctl() is stored into net_header
variable, but net_header is not used after, and compiler maybe
optimise the variable out, and lead kmemleak reported the below warning
comm "swapper/0", pid 1, jiffies 4294937448 (age 267.270s)
hex dump (first 32 bytes):
90 38 8b 01 c0 ff ff ff 00 00 00 00 01 00 00 00 .8..............
01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffc00020f134>] create_object+0x10c/0x2a0
[<ffffffc00070ff44>] kmemleak_alloc+0x54/0xa0
[<ffffffc0001fe378>] __kmalloc+0x1f8/0x4f8
[<ffffffc00028e984>] __register_sysctl_table+0x64/0x5a0
[<ffffffc00028eef0>] register_sysctl+0x30/0x40
[<ffffffc00099c304>] net_sysctl_init+0x20/0x58
[<ffffffc000994dd8>] sock_init+0x10/0xb0
[<ffffffc0000842e0>] do_one_initcall+0x90/0x1b8
[<ffffffc000966bac>] kernel_init_freeable+0x218/0x2f0
[<ffffffc00070ed6c>] kernel_init+0x1c/0xe8
[<ffffffc000083bfc>] ret_from_fork+0xc/0x50
[<ffffffffffffffff>] 0xffffffffffffffff <<end check kmemleak>>
Before fix, the objdump result on ARM64:
0000000000000000 <net_sysctl_init>:
0: a9be7bfd stp x29, x30, [sp,#-32]!
4: 90000001 adrp x1, 0 <net_sysctl_init>
8: 90000000 adrp x0, 0 <net_sysctl_init>
c: 910003fd mov x29, sp
10: 91000021 add x1, x1, #0x0
14: 91000000 add x0, x0, #0x0
18: a90153f3 stp x19, x20, [sp,#16]
1c: 12800174 mov w20, #0xfffffff4 // #-12
20: 94000000 bl 0 <register_sysctl>
24: b4000120 cbz x0, 48 <net_sysctl_init+0x48>
28: 90000013 adrp x19, 0 <net_sysctl_init>
2c: 91000273 add x19, x19, #0x0
30: 9101a260 add x0, x19, #0x68
34: 94000000 bl 0 <register_pernet_subsys>
38: 2a0003f4 mov w20, w0
3c: 35000060 cbnz w0, 48 <net_sysctl_init+0x48>
40: aa1303e0 mov x0, x19
44: 94000000 bl 0 <register_sysctl_root>
48: 2a1403e0 mov w0, w20
4c: a94153f3 ldp x19, x20, [sp,#16]
50: a8c27bfd ldp x29, x30, [sp],#32
54: d65f03c0 ret
After:
0000000000000000 <net_sysctl_init>:
0: a9bd7bfd stp x29, x30, [sp,#-48]!
4: 90000000 adrp x0, 0 <net_sysctl_init>
8: 910003fd mov x29, sp
c: a90153f3 stp x19, x20, [sp,#16]
10: 90000013 adrp x19, 0 <net_sysctl_init>
14: 91000000 add x0, x0, #0x0
18: 91000273 add x19, x19, #0x0
1c: f90013f5 str x21, [sp,#32]
20: aa1303e1 mov x1, x19
24: 12800175 mov w21, #0xfffffff4 // #-12
28: 94000000 bl 0 <register_sysctl>
2c: f9002260 str x0, [x19,#64]
30: b40001a0 cbz x0, 64 <net_sysctl_init+0x64>
34: 90000014 adrp x20, 0 <net_sysctl_init>
38: 91000294 add x20, x20, #0x0
3c: 9101a280 add x0, x20, #0x68
40: 94000000 bl 0 <register_pernet_subsys>
44: 2a0003f5 mov w21, w0
48: 35000080 cbnz w0, 58 <net_sysctl_init+0x58>
4c: aa1403e0 mov x0, x20
50: 94000000 bl 0 <register_sysctl_root>
54: 14000004 b 64 <net_sysctl_init+0x64>
58: f9402260 ldr x0, [x19,#64]
5c: 94000000 bl 0 <unregister_sysctl_table>
60: f900227f str xzr, [x19,#64]
64: 2a1503e0 mov w0, w21
68: f94013f5 ldr x21, [sp,#32]
6c: a94153f3 ldp x19, x20, [sp,#16]
70: a8c37bfd ldp x29, x30, [sp],#48
74: d65f03c0 ret
Add the possible error handle to free the net_header to remove the
kmemleak warning
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-10-23 12:59:49 +00:00
|
|
|
goto out1;
|
2007-11-30 12:55:42 +00:00
|
|
|
out:
|
|
|
|
return ret;
|
net: sysctl: fix a kmemleak warning
the returned buffer of register_sysctl() is stored into net_header
variable, but net_header is not used after, and compiler maybe
optimise the variable out, and lead kmemleak reported the below warning
comm "swapper/0", pid 1, jiffies 4294937448 (age 267.270s)
hex dump (first 32 bytes):
90 38 8b 01 c0 ff ff ff 00 00 00 00 01 00 00 00 .8..............
01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffc00020f134>] create_object+0x10c/0x2a0
[<ffffffc00070ff44>] kmemleak_alloc+0x54/0xa0
[<ffffffc0001fe378>] __kmalloc+0x1f8/0x4f8
[<ffffffc00028e984>] __register_sysctl_table+0x64/0x5a0
[<ffffffc00028eef0>] register_sysctl+0x30/0x40
[<ffffffc00099c304>] net_sysctl_init+0x20/0x58
[<ffffffc000994dd8>] sock_init+0x10/0xb0
[<ffffffc0000842e0>] do_one_initcall+0x90/0x1b8
[<ffffffc000966bac>] kernel_init_freeable+0x218/0x2f0
[<ffffffc00070ed6c>] kernel_init+0x1c/0xe8
[<ffffffc000083bfc>] ret_from_fork+0xc/0x50
[<ffffffffffffffff>] 0xffffffffffffffff <<end check kmemleak>>
Before fix, the objdump result on ARM64:
0000000000000000 <net_sysctl_init>:
0: a9be7bfd stp x29, x30, [sp,#-32]!
4: 90000001 adrp x1, 0 <net_sysctl_init>
8: 90000000 adrp x0, 0 <net_sysctl_init>
c: 910003fd mov x29, sp
10: 91000021 add x1, x1, #0x0
14: 91000000 add x0, x0, #0x0
18: a90153f3 stp x19, x20, [sp,#16]
1c: 12800174 mov w20, #0xfffffff4 // #-12
20: 94000000 bl 0 <register_sysctl>
24: b4000120 cbz x0, 48 <net_sysctl_init+0x48>
28: 90000013 adrp x19, 0 <net_sysctl_init>
2c: 91000273 add x19, x19, #0x0
30: 9101a260 add x0, x19, #0x68
34: 94000000 bl 0 <register_pernet_subsys>
38: 2a0003f4 mov w20, w0
3c: 35000060 cbnz w0, 48 <net_sysctl_init+0x48>
40: aa1303e0 mov x0, x19
44: 94000000 bl 0 <register_sysctl_root>
48: 2a1403e0 mov w0, w20
4c: a94153f3 ldp x19, x20, [sp,#16]
50: a8c27bfd ldp x29, x30, [sp],#32
54: d65f03c0 ret
After:
0000000000000000 <net_sysctl_init>:
0: a9bd7bfd stp x29, x30, [sp,#-48]!
4: 90000000 adrp x0, 0 <net_sysctl_init>
8: 910003fd mov x29, sp
c: a90153f3 stp x19, x20, [sp,#16]
10: 90000013 adrp x19, 0 <net_sysctl_init>
14: 91000000 add x0, x0, #0x0
18: 91000273 add x19, x19, #0x0
1c: f90013f5 str x21, [sp,#32]
20: aa1303e1 mov x1, x19
24: 12800175 mov w21, #0xfffffff4 // #-12
28: 94000000 bl 0 <register_sysctl>
2c: f9002260 str x0, [x19,#64]
30: b40001a0 cbz x0, 64 <net_sysctl_init+0x64>
34: 90000014 adrp x20, 0 <net_sysctl_init>
38: 91000294 add x20, x20, #0x0
3c: 9101a280 add x0, x20, #0x68
40: 94000000 bl 0 <register_pernet_subsys>
44: 2a0003f5 mov w21, w0
48: 35000080 cbnz w0, 58 <net_sysctl_init+0x58>
4c: aa1403e0 mov x0, x20
50: 94000000 bl 0 <register_sysctl_root>
54: 14000004 b 64 <net_sysctl_init+0x64>
58: f9402260 ldr x0, [x19,#64]
5c: 94000000 bl 0 <unregister_sysctl_table>
60: f900227f str xzr, [x19,#64]
64: 2a1503e0 mov w0, w21
68: f94013f5 ldr x21, [sp,#32]
6c: a94153f3 ldp x19, x20, [sp,#16]
70: a8c37bfd ldp x29, x30, [sp],#48
74: d65f03c0 ret
Add the possible error handle to free the net_header to remove the
kmemleak warning
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-10-23 12:59:49 +00:00
|
|
|
out1:
|
|
|
|
unregister_sysctl_table(net_header);
|
|
|
|
net_header = NULL;
|
|
|
|
goto out;
|
2007-11-30 12:55:42 +00:00
|
|
|
}
|
|
|
|
|
2021-04-12 04:24:52 +00:00
|
|
|
/* Verify that sysctls for non-init netns are safe by either:
|
|
|
|
* 1) being read-only, or
|
|
|
|
* 2) having a data pointer which points outside of the global kernel/module
|
|
|
|
* data segment, and rather into the heap where a per-net object was
|
|
|
|
* allocated.
|
|
|
|
*/
|
|
|
|
static void ensure_safe_net_sysctl(struct net *net, const char *path,
|
|
|
|
struct ctl_table *table)
|
|
|
|
{
|
|
|
|
struct ctl_table *ent;
|
|
|
|
|
|
|
|
pr_debug("Registering net sysctl (net %p): %s\n", net, path);
|
|
|
|
for (ent = table; ent->procname; ent++) {
|
|
|
|
unsigned long addr;
|
|
|
|
const char *where;
|
|
|
|
|
|
|
|
pr_debug(" procname=%s mode=%o proc_handler=%ps data=%p\n",
|
|
|
|
ent->procname, ent->mode, ent->proc_handler, ent->data);
|
|
|
|
|
|
|
|
/* If it's not writable inside the netns, then it can't hurt. */
|
|
|
|
if ((ent->mode & 0222) == 0) {
|
|
|
|
pr_debug(" Not writable by anyone\n");
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Where does data point? */
|
|
|
|
addr = (unsigned long)ent->data;
|
|
|
|
if (is_module_address(addr))
|
|
|
|
where = "module";
|
2021-11-09 02:33:51 +00:00
|
|
|
else if (is_kernel_core_data(addr))
|
2021-04-12 04:24:52 +00:00
|
|
|
where = "kernel";
|
|
|
|
else
|
|
|
|
continue;
|
|
|
|
|
|
|
|
/* If it is writable and points to kernel/module global
|
|
|
|
* data, then it's probably a netns leak.
|
|
|
|
*/
|
|
|
|
WARN(1, "sysctl %s/%s: data points to %s global data: %ps\n",
|
|
|
|
path, ent->procname, where, ent->data);
|
|
|
|
|
|
|
|
/* Make it "safe" by dropping writable perms */
|
|
|
|
ent->mode &= ~0222;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-04-19 13:18:47 +00:00
|
|
|
struct ctl_table_header *register_net_sysctl(struct net *net,
|
|
|
|
const char *path, struct ctl_table *table)
|
|
|
|
{
|
2021-04-12 04:24:52 +00:00
|
|
|
if (!net_eq(net, &init_net))
|
|
|
|
ensure_safe_net_sysctl(net, path, table);
|
|
|
|
|
2012-04-19 13:18:47 +00:00
|
|
|
return __register_sysctl_table(&net->sysctls, path, table);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(register_net_sysctl);
|
|
|
|
|
2007-11-30 12:55:42 +00:00
|
|
|
void unregister_net_sysctl_table(struct ctl_table_header *header)
|
|
|
|
{
|
2008-05-01 09:47:38 +00:00
|
|
|
unregister_sysctl_table(header);
|
2007-11-30 12:55:42 +00:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(unregister_net_sysctl_table);
|